Damian Mooyman
ecda66a1c4
Merge remote-tracking branch 'origin/3.1'
2014-04-02 17:39:47 +13:00
Damian Mooyman
4b87b2e2e6
BUG Fix ContentControllerTest
2014-03-25 17:14:05 +13:00
Stephen Shkardoon
a67ed2799d
FIX Do now allow arbitary class creation in CMS
2014-03-19 19:27:39 +13:00
Sam Minnee
d0a4fc2065
FIX: Fix failover to index template in ContentController::getViewer()
...
Historically, if you visit a foo action on Page, and Page_foo.ss doesn't exist, then it fails over
to Page.ss. The introduction of ContentController::getViewer() broke this, but this patch adds a
test for this case and fixes it.
It was identified by build failures on silverstripe/userforms when tested against the master branch.
2014-02-14 17:44:53 +13:00
Ingo Schommer
5ebb484b20
Fixed ContentControllerTest
2014-02-07 15:56:20 +13:00
Ingo Schommer
683b099308
Merge pull request #914 from micmania1/900-page-templates-without-controller
...
NEW Locate page template without needing to define a controller
2014-02-07 14:20:30 +13:00
micmania1
47582b3e3c
getViewer will now locate and use the correct templates for pages which don't have their own controller
2013-12-20 20:52:11 +00:00
Ingo Schommer
6403be518a
Backwards compat OldPageRedirector
...
Regression from f972466880
.
Passes tests in 3.1, but fails in master due to Deprecation notices.
Tests needed adjustments because OldPageRedirector::find_old_page()
doesn't have the same method signature...
2013-12-06 14:28:08 +01:00
Sean Harvey
ed8ee4e9b8
ContentControllerSearchExtensionTest doesn't clean up after itself.
...
The problem is FulltextSearchable::enable() does two things:
It enables the extension, as well as sets the MySQL create table option
to MyISAM. Later tests run with the extension enabled, because it doesn't
get removed at the end of the test, but the table type is set back to
InnoDB when the test is reset and schema recreated.
This produces side-effects where later tests in a suite tries to run
ALTER TABLE on File and add fulltext indexes when the table type
is set to InnoDB, causing an error.
2013-10-22 15:26:40 +13:00
Ingo Schommer
7ec9596b99
CMSMain assertion fail due to escaping
...
Validation messages are now HTML entity escaped when output to the user,
the assertion needs to reflect that
2013-09-30 22:44:44 +02:00
Hamish Friedlander
a5f00ae2c3
FIX Not checking stage in SiteTree#canView
...
SiteTree versions that arent the live version shouldnt be accessed by
regular users, but the logic to check that was split off into canViewStage,
which wasnt checked by code that isnt specifically SiteTree aware
(like RestfulServer)
2013-07-05 12:14:22 +12:00
Sean Harvey
c7ebf76757
Page history panel: show appropriate message when viewing latest version
2013-05-07 17:14:28 +12:00
Ingo Schommer
51c8e8639e
API Marked statics private, use Config API instead ( #8317 )
...
See "Static configuration properties are now immutable, you must use Config API." in the 3.1 change log for details.
2013-03-24 17:21:04 +01:00
Hamish Friedlander
68ebc5d221
FIX CMSMainTest to access batch_action config property properly
2013-02-27 15:00:41 +13:00
Ingo Schommer
eba4d205c3
Merge remote-tracking branch 'origin/3.0' into 3.1
2013-01-30 12:44:40 +01:00
Ingo Schommer
b15b98345f
Using new "Security.login_url" configuration value
2013-01-29 18:06:49 +01:00
Ingo Schommer
74d63791b7
Fixed regression in SiteTree->getCMSActions()
...
Caused by toolbar recent changes
2012-12-14 01:21:54 +01:00
Ingo Schommer
f9a5601fa3
BUG Enforce "add page" restrictions, improve UI ( fixes #7879 )
...
- Fix support for $allowed_children
- Added note when type selection is restricted
- Removed overly complex specs for "allowed children",
the data should be inferred from "disallowed children"
- Added support for SiteTree::$can_be_root
- Return raw JSON (not entity-encoded) from CMSMain->SiteTreeHints()
- Added tests for CMSMain->SiteTreeHints()
2012-12-03 16:52:17 +01:00
Ingo Schommer
76b99e4006
Fixed tests without assertions
2012-11-23 15:52:00 +01:00
Ingo Schommer
26bdee4f08
Merge remote-tracking branch 'origin/3.0'
...
Conflicts:
tests/model/SiteTreeTest.php
2012-11-23 15:31:03 +01:00
Ingo Schommer
ff1df3696f
Limiting redirection-follow to specific tests in CMSMainTest
...
Fixes *some* quirks when running tests with
the 'translatable' module enabled (which redirects
to URLs with ?locale=<locale> in the CMS by default).
2012-11-23 15:30:11 +01:00
Ingo Schommer
8659c27487
Remove unused set_up_once() invocations from various tests
...
SapphireTest method name was changed to instance method
and setUpOnce() naming in mid 2010 already (093da759).
Since those methods were never invoked, they're obsolete.
Checked that the SiteTree-related tests pass with
Translatable enabled.
2012-11-23 13:58:54 +01:00
Sean Harvey
b92f759963
Fixing test to be less fragile (selects the input ID directly instead of holder)
2012-09-27 12:14:14 +12:00
Ingo Schommer
cbd31e3ab2
API Removed SiteTree.MetaTitle and MetaKeywords
...
They are irrelevant in terms of SEO, general page informancy,
clutter up the CMS UI, and encourage CMS authors to waste
their time filling them out.
[1] http://www.seomoz.org/learn-seo/title-tag
[2] http://www.mattcutts.com/blog/keywords-meta-tag-in-web-search/
2012-09-21 11:31:00 +02:00
Ingo Schommer
df44239060
Method visibility according to coding conventions
2012-09-20 10:41:50 +02:00
Ingo Schommer
1cd82e2db1
BUG Enforce $allowed_children in controllers on page creation ( fixes #7694 )
...
Original bug fix contributed by @kmayo-ss
2012-09-02 18:20:22 +02:00
carlos barberis
f7b6f1de5a
BUGFIX: ticket #5239 - Infinite loop: live subpage of draft page redirects onto itself when called just by url segment
2012-07-23 17:06:37 +12:00
Mateusz Uzdowski
54fd54a2fb
BUG Change all shortcodes into the new, comma separated, format.
...
Ref http://open.silverstripe.org/ticket/7337
2012-07-12 17:57:38 +02:00
Sean Harvey
0515555ab1
MINOR Fixing CMSMainTest using old code, updating to new CMS admin/pages URL
2012-05-22 17:35:04 +12:00
Sean Harvey
2cb89ed696
MINOR Fixing invalid URL
2012-05-22 17:16:29 +12:00
Sean Harvey
c72bae3a8e
MINOR Fixing assertType() assertions with assertInstanceOf()
2012-05-09 23:06:55 +12:00
Sean Harvey
dedb9d0461
MINOR Removing use of _t() in test, assert the english text since en_US
...
is the locale set for tests by default.
2012-05-09 21:54:33 +12:00
Sean Harvey
46660e98bc
MINOR Fixing broken test
2012-05-09 21:52:32 +12:00
Ingo Schommer
0e071c9393
MINOR Fixed tests broken by recent CMS search and breadcrumbs changes
2012-04-18 23:40:27 +02:00
Ingo Schommer
1b3a634a56
MINOR Fixed hardcoded links from admin/page to admin/pages
2012-04-18 23:33:37 +02:00
Simon Welsh
b8e86ae261
MINOR Add newline to end of files without one
2012-04-15 10:56:40 +12:00
Ingo Schommer
dc0168d01b
MINOR Removed $params argument to DataObject->getCMSFields(), please use FormScaffolder directly ( fixes #7135 )
2012-04-13 15:55:32 +02:00
Sean Harvey
ded3fd8d68
MINOR Fixed broken test from json changes
2012-03-30 16:25:21 +13:00
Ingo Schommer
1827dc6727
API CHANGE Removed SiteTree->HomepageForDomain and related functionality ($write_homepage_map and generate_homepage_domain_map()), use new 'homepagefordomain' module instead ( fixes #6902 )
2012-03-27 14:50:09 +02:00
Ingo Schommer
4612b13d98
MINOR Fixed CMSMainTest to work with new breadcrumbs conventions (see 44a4e8a840
)
2012-03-12 17:25:53 +01:00
Ingo Schommer
4225c0a966
MINOR Flattened AddForm and SiteConfig CMS logic, moved from base classes to specialised classes for better overview, and less inheritance where its not necessary.
2012-03-09 23:35:43 +01:00
Ingo Schommer
f620f9b46c
MINOR Using <button> tags for CMS UI, and new 'data-icon' HTML5 attribute to denote icons
2012-02-17 15:30:37 +01:00
Ingo Schommer
f88d4006f8
ENHANCEMENT CMSMain->Breadcrumbs()
2012-02-14 16:11:38 +01:00
Ingo Schommer
0bfd866623
MINOR Skip instanciation in CMSMainTest->testThatGetCMSFieldsWorksOnEveryPageType() when can_be_root is false (will fail the write call, not related to test)
2012-01-30 17:31:22 +01:00
Ingo Schommer
908a98b55b
API CHANGE Default to /admin/pages rather than homepage edit view when CMS is first opened ( #6762 )
2012-01-24 14:20:55 +01:00
Ingo Schommer
0194080951
merge
2011-12-21 17:22:47 +01:00
Sean Harvey
748c0196cc
MINOR Fixed broken CMSPageHistoryControllerTest assuming IDs
2011-10-30 00:19:26 +13:00
Stig Lindqvist
05e90838c0
API CHANGE Switch usage from FieldSet to FieldList
2011-10-27 20:24:45 +02:00
Will Rossiter
ecae94e8c2
MINOR: added unit test for checking whether viewing an unpublished version directly selects the checkbox option
2011-09-19 17:30:47 +02:00
Will Rossiter
11821f3e43
ENHANCEMENT: implemented further tests for CMSPageHistoryController::getEditForm()
2011-09-19 17:30:47 +02:00
Will Rossiter
18471e8878
ENHANCEMENT: added tests for CMSPageHistoryController::VersionsForm(). BUGFIX: fixed VersionsForm hidden ID storing a reference to itself. ENHANCEMENT: changed url structure from /version/ to /show/ for consistency between CMSPageHistoryController and CMSMain. APICHANGE: moved performRollback() from CMSMain to CMSPageHistoryController
2011-09-19 17:30:47 +02:00
Ingo Schommer
5de2ba5628
MINOR Removing executable flag from all files (thanks miiihi)
2011-09-18 22:04:42 +02:00
Ingo Schommer
eecb401952
ENHANCEMENT Removed automatic redirection to admin URLs in ContentController, too counter-intuitive and hard to implement consistently, while still allowing linkage of pages without CMS around them.
2011-08-12 17:06:29 +02:00
Ingo Schommer
e13537e0a7
API CHANGE Refactored SilverStripeNavigator and SilverStripeNavigatorItem to instance-based utility classes, which take a DataObject record in the constructor rather than all of their methods (increasing template flexibility and code isolation).
...
ENHANCEMENT Added SilverStripeNavigatorItem->canView() for flexible permission control
MINOR Fixed duplicate priority overrides in SilverStripeNavigator
MINOR Removed unnecessary inline styling from SilverStripeNavigator HTML generation
2011-08-12 14:28:17 +02:00
Ingo Schommer
8382ebb742
MINOR Using post() instead of submitForm() in CMSMainTest to work around SimpleTest issues
2011-07-08 15:36:31 +02:00
Ingo Schommer
75ce441348
ENHANCEMENT Redirecting to cms preview in ContentController if user is logged in
2011-07-08 15:36:30 +02:00
Ingo Schommer
9a09aaf42b
ENHANCEMENT Changed CMSMain->AddForm() to a modal dialog, showing page types and their descriptions as radiobuttons rather than a dropdown
2011-04-28 22:49:34 +12:00
Ingo Schommer
f547da23a3
MINOR Relative $fixture_file links in cms/tests to facilitate moving files
2011-03-30 20:04:31 +13:00
Ingo Schommer
60abe5fb9f
MINOR Moved files into a more logical structure in cms/code
2011-03-30 20:03:44 +13:00