Nathan
a5b33ab916
Correcting an issue where page controller methods
...
would end up with the error page response code, causing them to not work. This code only looks to be causing issues from what I can see.
An example is an autocomplete that is populated using a method on page controller. The moment you end up on a 404 error page, the autocomplete will attempt to populate and end up with a 404 response.
2016-11-21 15:43:37 +11:00
Patrick Nelson
000bf09354
FIX for #1447 to ensure proper type-safe checking of file_put_contents() in ErrorPage->writeStaticPage()
2016-04-06 17:34:55 -07:00
Damian Mooyman
748866ec0f
Merge remote-tracking branch 'origin/3.2' into 3
...
Conflicts:
code/controllers/CMSMain.php
code/model/ErrorPage.php
2015-11-03 13:11:26 +13:00
Patrick Nelson
785f85047f
FIX for #1294 to workaround ErrorPage fatal errors (and undefined var) when publishing.
2015-10-08 17:38:58 -04:00
Peter Thaleikis
f291c5f365
fixing phpdoc blocks to refering to Objects to built-in types of PHP
2015-09-28 22:31:31 +13:00
Stevie Mayhew
d54e117392
UPDATE: make all response code use getResponse() method
2015-09-25 09:10:24 +12:00
Damian Mooyman
04a513b0a8
Set deprecation level for all changes in 3.x to 4.0
2015-06-19 12:00:42 +12:00
Damian Mooyman
b169823a00
API Deprecate delete in favour of archive
...
Remove "delete from live" duplicate action in favour of existing "unpublish" which is more consistent with current terminology
Add pop-up verification to destructive actions
Fix bug preventing side-by-side preview of archived pages
Fix bug in reporting publishing of error pages
Restoring a page without an available parent will restore to root
2015-06-03 14:46:16 +12:00
Stephen Shkardoon
857ade7d1d
Refactor ErrorPage to have static file building in a separate method
2015-04-27 11:56:54 +12:00
Damian Mooyman
3162d0e664
API Update ErrorPage to respect new HTTP Error codes
2014-05-06 15:29:33 +12:00
Gus King
7b4cc316ef
Numerous PHPDoc fixes.
2014-02-10 15:35:13 -05:00
Will Rossiter
ddc2e3822b
FIX: ErrorPage generating empty responses for 403/401 requests
...
Previously by setting the response status code inside the action, this prevented response bodies from being included due to 403/401 being matched by SS_HTTPResponse::isFinished() (which stops popular
I assume SS_HTTPResponse::isFinished() is valid for the permission error use case (and I would be hesitant to change it) so this simply moves the declaration of the response status code till after the parent has populated the body of the response.
2013-11-18 16:32:15 +13:00
Damian Mooyman
5f828149c3
BUG Fixed instances of loosely defined SQL predicates not qualified by table name
...
Fixed duplicate SQL escaping on SiteTree::get_by_link
2013-08-29 13:59:45 +12:00
Ingo Schommer
da515b8f65
FIX Use SSViewer.theme_enabled in CMS logic
2013-04-08 19:29:09 +12:00
Ingo Schommer
18201c05af
Fixed Config usage in ErrorPage
2013-03-27 12:00:55 +01:00
Ingo Schommer
51c8e8639e
API Marked statics private, use Config API instead ( #8317 )
...
See "Static configuration properties are now immutable, you must use Config API." in the 3.1 change log for details.
2013-03-24 17:21:04 +01:00
Ingo Schommer
23eeb99075
FIX Clear Requirements before in-memory HTTP request for ErrorPage
...
For example, avoids issues where separate controllers (calling and called) operate on the same
set of files through Requirements::combine_files().
2013-02-06 10:43:42 +01:00
Ingo Schommer
b25063b09c
Extracted ErrorPage default data to getter
...
Allows for less verbose overloading, while still keeping i18n capabilities
in place, which isn't possible with DataObject::$default_records
2013-01-30 13:07:11 +01:00
Ingo Schommer
416178b668
Reduced code duplication in ErrorPage (no functional changes)
2013-01-29 19:34:05 +01:00
Ingo Schommer
df44239060
Method visibility according to coding conventions
2012-09-20 10:41:50 +02:00
Sean Harvey
c019f22163
Fix notice when ErrorPage tries to create static error pages and can't write
2012-08-20 15:23:46 +12:00
Sean Harvey
ec3ebc91d8
MINOR Use instance methods on current Controller instance for redirect()
...
instead of static Director functions
2012-05-23 21:45:16 +12:00
Ingo Schommer
73e5c34896
BUGFIX Encoding multibyte characters in custom X-Status HTTP headers used in CMS (headers don't allow multibyte data)
2012-05-14 15:11:35 +02:00
Ingo Schommer
38f1236b1f
MINOR Switching _t() calls from sprintf() to using injection parameters ( #7170 )
2012-05-01 22:05:19 +02:00
Ingo Schommer
dc0168d01b
MINOR Removed $params argument to DataObject->getCMSFields(), please use FormScaffolder directly ( fixes #7135 )
2012-04-13 15:55:32 +02:00
Wolf Vollprecht
a18b9bd85e
ENHANCEMENT: Flyout menu to directly choose the pagetype one wants to add.
2012-04-09 21:08:15 +02:00
Sean Harvey
0ea9451014
MINOR Fixes to method arguments in cms classes for E_STRICT support.
2012-03-27 21:42:54 +13:00
Ingo Schommer
04a195b111
MINOR Stop using FormResponse, which has been removed from core
2012-03-09 23:20:09 +01:00
Fred Condo
d99e3a0927
Code cleanup: removed trailing ?> markers per code standard.
...
All cms module except lang directory.
2012-02-13 12:48:41 -08:00
phalkunz
ac79934077
ENHANCEMENT Render page tree icons as stylesheets rather than $_TREE_ICONS JS definitions. Removed file/folder swapping of SiteTree::$icon, use relative file path including extension instead.
2011-12-19 14:03:42 +01:00
Will Rossiter
e17b4a185a
MINOR: update PageTypes to use updated tab path for CMS fields. Fixes #6811
2011-12-17 16:46:26 +13:00
Sam Minnee
ddcbd650d4
BUGFIX: Fix bugs introduced by the expectation of having a DataModel.
2011-10-07 08:51:54 +02:00
Ingo Schommer
5de2ba5628
MINOR Removing executable flag from all files (thanks miiihi)
2011-09-18 22:04:42 +02:00
Ingo Schommer
e2f4dd0b44
ENHANCEMENT Added SiteTree::$description to provide more context for content authors selecting a new page type
2011-04-28 22:49:34 +12:00
Ingo Schommer
7a50608e24
API CHANGE Splitting off "Behaviour" and "Access" tabs from SiteTree->getCMSFields() into SiteTree->getSettingsFields(). Adjusting functionality to split of SiteTree->getCMSFields() into getSettingsFields(), and new tab paths ("Root.Content" instead of "Root.Content.Main")
2011-04-28 22:48:55 +12:00
Ingo Schommer
53ed7c496e
MINOR Disallow nested ErrorPage instances via canAddChildren()
2011-04-28 22:48:55 +12:00
Brian Waters
c9b5ae8b41
API CHANGE: Added SiteTree::get_create_default_pages().MINOR: Error pages no longer created on /dev/build if SiteTree::get_create_default_pages() is false. Fixes #6587 .
2011-04-23 17:52:53 +12:00
Ingo Schommer
60abe5fb9f
MINOR Moved files into a more logical structure in cms/code
2011-03-30 20:03:44 +13:00
