Commit Graph

441 Commits

Author SHA1 Message Date
Ingo Schommer
9bf3245939 BUGFIX Enforce permission checks in LeftAndMain and CMSMain through SiteTree->canView()/canEdit()/canAddChildren()/canPublish()/canDelete() (see #2701)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65152 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-03 14:56:36 +00:00
Sean Harvey
8d6d5c2501 MINOR Code formatting in CMSMenuItem
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65126 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-03 02:07:03 +00:00
Ingo Schommer
386c586b38 BUGFIX Setting menu titles for CMSMenu items in LeftAndMain::init() to get translated values for the current user locale (see #2873)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65106 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-02 22:45:49 +00:00
Ingo Schommer
e1d5fc9db6 BUGFIX Fixed menu titles entity references in CMSMain and AssetAdmin
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65104 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-02 22:45:05 +00:00
Ingo Schommer
2cdf57053f FEATURE Added CMSMenu and CMSMenuItem and adjusted existing LeftAndMain subclasses to use new notation.See #2872 (thanks to hamish for the patch!)
API CHANGE Removed LeftAndMain::add_menu_item(), LeftAndMain::remove_menu_item(), LeftAndMain::replace_menu_item(), LeftAndMain::clear_menu()
MINOR Disabled LeftAndMainTest, now covered by CMSMenuTest

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65095 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-02 21:27:55 +00:00
Ingo Schommer
18912d2cb7 ENHANCEMENT Added fieldLabels() overloading to various DataObject subclasses. Use this method instead of directly calling _t() in getCMSFields(), and use fieldLabel('MyField') to get the label for a specific FormField. This way, we can transparently support formfield scaffolding and re-use the labels for search fields automatically.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65073 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-02 20:04:26 +00:00
Ingo Schommer
e2ca30f78a BUGFIX Using SiteTree::get_by_url() (see r65060)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65061 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-02 00:24:46 +00:00
Ingo Schommer
dbcd2f6c2b ENHANCEMENT Using safer get_by_id() call in SecurityAdmin->getMemberForm()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65027 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-01 13:55:23 +00:00
Sean Harvey
aa3437c4d4 MINOR Renamed variable to avoid confusion in SecurityAdmin->SiteTreeAsUL()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64986 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-31 02:45:19 +00:00
Sam Minnee
dd8b5bafa4 API CHANGE #2857 - Renamed RequestHandlingData to RequestHandler
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64954 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-30 22:03:32 +00:00
Sean Harvey
2795dae693 BUGFIX Fixed old references to GenericDataAdmin in ModelAdmin.php and ModelAdmin_Results.ss
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64754 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-24 03:45:39 +00:00
Sean Harvey
21a61404ba MINOR Code formatting cleanup in AssetAdmin->addfolder()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64733 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-24 01:23:52 +00:00
Normann Lou
0f4698726a APICHANGE: delete GenericDataAdmin, RelatedDataEditor, DropdownField_WithAdd and their related code (js, css, etc) from cms, sapphire, "GenericDataAdmin" name space has also been deleted from lang files. They are all added in the new module "genericdataadmin"
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 00:20:00 +00:00
Sean Harvey
3579cea26e MINOR phpDoc changes in LeftAndMain - removal of @usedby which doesn't exist, replaced with @uses on the remote function
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64503 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-18 22:34:02 +00:00
Ingo Schommer
118efae75d BUGFIX Adjusted HeaderField and LabelField implementation to new constructor arguments (see r64421)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64423 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:27:12 +00:00
Ingo Schommer
62e7970a3a API CHANGE Removed MemberList, use MemberTableField
API CHANGE Removed CMSMain->getMembersByGroup()
API CHANGE Removed SecurityAdmin->listmembers()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64398 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 10:48:48 +00:00
Sean Harvey
901b285ce6 MINOR Removed deprecated method addmember() from CMSMain - this should be contained on SecurityAdmin instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64396 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 09:46:37 +00:00
Sean Harvey
1acd10f35a MINOR phpDoc for CMSMain->PageTypes()
MINOR Code syntax formatting for CMSMain->PageTypes()
MINOR Removed commented out code in CMSMain->PageTypes()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64395 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 09:37:28 +00:00
Ingo Schommer
86b81b81f5 MINOR Misc deprecation fixes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64385 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:45:14 +00:00
Sam Minnee
156fb6cf19 API CHANGE #551: Move code from CMSMain to SiteTree
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64350 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 03:21:49 +00:00
Hayden Smith
b0abb54e93 Included jquery.js before prototype.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64340 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 02:10:13 +00:00
Hayden Smith
365622c0c9 Implemented a jQuery based version of documents.getElementsBySelector
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64339 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 02:09:46 +00:00
Sean Harvey
d66ee2f738 API CHANGE Removed deprecated methods related to CanCMS and CanCMSAdmin which are now removed from the Group class in favour of the Permission system
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64332 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 01:01:59 +00:00
Ingo Schommer
08b1d974ac ENHANCMENT Making ModelAdmin translatable (#2874)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64070 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 12:15:31 +00:00
Sean Harvey
8cd9b6f4d9 BUGFIX Removed $_ALL_CLASSES in ReportAdmin::has_reports() - this doesn't need to be here anymore, due to changes in ManifestBuilder
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64038 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 01:45:14 +00:00
Sean Harvey
8b194ab627 MINOR Documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63985 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 05:54:55 +00:00
Sean Harvey
f8a02ca736 BUGFIX Fixes so ?flush=1 doesn't stop showing the Reports tab in CMS
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63983 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 05:48:28 +00:00
Sean Harvey
58077f8851 MINOR Removed unnecessary $this->extend() on SSReport->getCMSFields()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63982 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 05:47:27 +00:00
Sean Harvey
f40c5f7544 MINOR Updated inconsistent documentation on SSReport
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63961 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 02:54:09 +00:00
Sean Harvey
ab6a3eae72 MINOR Updated SSReport class documentation to make sense
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63959 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 02:53:05 +00:00
Sean Harvey
c784fdc875 MINOR Documentation and @package phpDoc code additions to ReportAdmin and SSReport
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63958 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 02:52:08 +00:00
Sean Harvey
47ca384912 ENHANCEMENT Pulled out Report::has_reports() which was hardcoded into LeftAndMain, and put into cms/_config.php which makes more sense
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63955 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 02:45:01 +00:00
Andrew O'Neil
114d6f00bf MINOR: Change memory limit to -1 on publishall to stop sapphire running out of memory on unit tests.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63897 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 21:33:07 +00:00
Sam Minnee
2ab29ed99b Removed legacy Report.php
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63843 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 04:33:31 +00:00
Sean Harvey
20e266d5cb BUGF Renamed Report class to SSReport, file name wasn't altered but class name was
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63842 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 04:31:29 +00:00
Sean Harvey
ed4103bc11 MINOR Renamed Report to SSReport as it was conflicting with project code
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63840 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 04:28:23 +00:00
Sean Harvey
a0c107a338 BUGFIX MemberTableField_Popup had an odd way of overloading saveComplexTableField() - this should be on MemberTableField instead, since that's the direct subclass of ComplexTableField for where saveComplexTableField() is defined. This broke the "Add Member" button in CMS Security, probably due to the way the form URLs have been changed. See ticket #2907 for the reported problem.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63828 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:46:19 +00:00
Hayden Smith
690cebdccd Merged from branches/nzct-trunk. Use 'svn log -c <changeset> -g' for full commit message. Merge includes stability fixes and minor refactor of TableListField and ComplexTableField.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63807 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:00:39 +00:00
Sean Harvey
e6815f2156 BUGFIX Side reports weren't working on initial opening of the side tab
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63804 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 01:49:49 +00:00
Sean Harvey
d1572b1272 BUGFIX Fixed blatant error where $SNG_member wasn't defined
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63799 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 01:00:08 +00:00
Sean Harvey
5aac6f5693 BUGFIX MemberTableField->AddLink() was calling &methodName=add - this should be just "add", as per changes to the forum URLs in sapphire
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63793 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 00:07:53 +00:00
Sean Harvey
6d5d988b08 MINOR Line break between static variables on SecurityAdmin
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63790 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 23:27:07 +00:00
Sean Harvey
b4fb295a37 BUGFIX Removed query that was causing issues displaying members in the security groups. Open ticket #2591
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63786 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 23:01:46 +00:00
Sean Harvey
5e0277cea4 BUGFIX URLs to security groups in CMS were not linked correctly. Removed Director::link() references and replaced with strings. Director::link() is deprecated and shouldn't be used.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63785 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 22:59:47 +00:00
Sean Harvey
f5194a6e0b MINOR Removed useless Requirements calls to javascript
MINOR Documentation
MINOR Code formatting cleanup

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63753 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 05:59:03 +00:00
Sean Harvey
9a667bbd2a MINOR Very minor whitespace change
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63752 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 05:57:28 +00:00
Sean Harvey
c39cbbe58a ENHANCEMENT Added missing "abstract" Report class to compliment ReportAdmin. Currently it is unclear what abstract base class you're supposed to implement from.
BUGFIX Use of getOwnerID() in ReportAdmin which doesn't make sense, since ID() is sufficient.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63748 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 05:32:09 +00:00
Sam Minnee
cc4673ff7e Added get data to a form submission of SearchForm/search, so that ResultAssembly is passed
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63733 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 03:55:43 +00:00
Ingo Schommer
4541dbb04e ENHANCEMENT Removed overloaded MemberTableField->DetailForm() and reduced overloaded constructor logic - same behaviour found in parent classes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63626 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 16:33:37 +00:00
Ingo Schommer
c3244cc821 BUGFIX typo mentioned in #2775
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63611 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 09:54:59 +00:00