Russell Michell
7d7c75414c
NEW Track broken anchors
2014-01-31 12:44:59 +13:00
Ingo Schommer
87734cdfe1
Fixed ErrorPageTest Link() usage
2013-12-06 15:35:53 +01:00
Will Rossiter
ddc2e3822b
FIX: ErrorPage generating empty responses for 403/401 requests
...
Previously by setting the response status code inside the action, this prevented response bodies from being included due to 403/401 being matched by SS_HTTPResponse::isFinished() (which stops popular
I assume SS_HTTPResponse::isFinished() is valid for the permission error use case (and I would be hesitant to change it) so this simply moves the declaration of the response status code till after the parent has populated the body of the response.
2013-11-18 16:32:15 +13:00
Andrew Short
1f4cdfced8
Fix test sometimes using cached relationship object.
...
In some circumstances, the CopyContentFrom page will be cached, so when
it is accessed the incorrect value was returned, meaning the test
would fail.
2013-10-02 15:03:50 +10:00
Damian Mooyman
5f828149c3
BUG Fixed instances of loosely defined SQL predicates not qualified by table name
...
Fixed duplicate SQL escaping on SiteTree::get_by_link
2013-08-29 13:59:45 +12:00
Hamish Friedlander
71608f0d4a
FIX Add SiteTree link tracking as an extension, and apply to SiteTree itself
2013-08-09 11:46:32 +02:00
Hamish Friedlander
a5f00ae2c3
FIX Not checking stage in SiteTree#canView
...
SiteTree versions that arent the live version shouldnt be accessed by
regular users, but the logic to check that was split off into canViewStage,
which wasnt checked by code that isnt specifically SiteTree aware
(like RestfulServer)
2013-07-05 12:14:22 +12:00
Ingo Schommer
98750a9cf1
Merge pull request #772 from chillu/pulls/sitetree-urlsegment-votes
...
API SiteTree->validURLSegment() prioritizes extension votes
2013-06-25 02:18:08 -07:00
Ingo Schommer
f2a9f9aa0a
ErrorPageTest: Reset env state
...
Otherwise SapphireTest will complain, see 0da70dafa457564a6adb02140ffeb5dd01f3a982
2013-06-19 13:17:22 +02:00
Jeremy Thomerson
b8908efdf7
ENHANCEMENT: allow sites to override meta generator tag
2013-06-17 20:35:14 +00:00
Ingo Schommer
0c4b2f8157
API SiteTree->validURLSegment() prioritizes extension votes
...
Tri-state, use NULL to ignore the extension result
2013-06-12 12:32:42 +02:00
Simon Welsh
be25c302ac
FIX Escape the sitetree_link shortcode return value
2013-05-10 14:05:06 +12:00
Ingo Schommer
6457ab2433
Regression in URL generation (dots now filtered out)
...
Caused by framework/5ec85d06f68d09ab30b124312c54f1d84ce7d6f4
2013-04-02 11:39:46 +02:00
Ingo Schommer
f73a5c68f3
FIX VirtualPageTest memory errors due to Config API quirks
2013-03-27 10:59:17 +01:00
Ingo Schommer
51c8e8639e
API Marked statics private, use Config API instead ( #8317 )
...
See "Static configuration properties are now immutable, you must use Config API." in the 3.1 change log for details.
2013-03-24 17:21:04 +01:00
Ingo Schommer
eba4d205c3
Merge remote-tracking branch 'origin/3.0' into 3.1
2013-01-30 12:44:40 +01:00
Ingo Schommer
b15b98345f
Using new "Security.login_url" configuration value
2013-01-29 18:06:49 +01:00
Ingo Schommer
8dd9bf3a1e
Merge remote-tracking branch 'origin/3.0' into 3.1
2012-12-17 17:34:20 +01:00
Ingo Schommer
894d48789c
String casting in SimpleXML tests for older phpunit versions
2012-12-17 17:32:46 +01:00
Ingo Schommer
76b99e4006
Fixed tests without assertions
2012-11-23 15:52:00 +01:00
Ingo Schommer
26bdee4f08
Merge remote-tracking branch 'origin/3.0'
...
Conflicts:
tests/model/SiteTreeTest.php
2012-11-23 15:31:03 +01:00
Ingo Schommer
8659c27487
Remove unused set_up_once() invocations from various tests
...
SapphireTest method name was changed to instance method
and setUpOnce() naming in mid 2010 already (093da759).
Since those methods were never invoked, they're obsolete.
Checked that the SiteTree-related tests pass with
Translatable enabled.
2012-11-23 13:58:54 +01:00
Andrew O'Neil
48a9bcf276
APICHANGE: Use late static binding for Object::remove_extension()
2012-11-07 11:08:36 +13:00
Andrew O'Neil
1722f00869
APICHANGE: add_extension() is now called directly on the class, instead of on Object
2012-11-07 11:08:36 +13:00
Sean Harvey
cb8c10a473
Merge branch '3.0' of github.com:silverstripe/silverstripe-cms into 3.0
2012-09-27 10:49:03 +12:00
Sean Harvey
2c4ebd3cb9
Fixing broken SiteTreeHTMLEditorFieldTest
2012-09-23 22:49:44 +12:00
Ingo Schommer
cbd31e3ab2
API Removed SiteTree.MetaTitle and MetaKeywords
...
They are irrelevant in terms of SEO, general page informancy,
clutter up the CMS UI, and encourage CMS authors to waste
their time filling them out.
[1] http://www.seomoz.org/learn-seo/title-tag
[2] http://www.mattcutts.com/blog/keywords-meta-tag-in-web-search/
2012-09-21 11:31:00 +02:00
Ingo Schommer
df44239060
Method visibility according to coding conventions
2012-09-20 10:41:50 +02:00
Ingo Schommer
8a514d8b64
BUG Correct live state in SiteTree->getAbsoluteLiveLink()
...
Was fetching the record from live (and its direct URLSegment),
but all of its parents from the current stage, which might be draft,
leading to "mixed" draft/live nested URLs which might no longer
be reachable in live mode.
2012-08-28 19:04:16 +02:00
Hamish Friedlander
d45dd34db9
FIX VirtualPageTest failing on apps with no $db on Page
...
VirtualPageTest was adding fields to Page via a decorator, but Page might
not have any fields itself. This changed Page from not having a table
to having a table, which then caused a problem on tearDown
2012-08-28 15:13:57 +12:00
Mateusz Uzdowski
54fd54a2fb
BUG Change all shortcodes into the new, comma separated, format.
...
Ref http://open.silverstripe.org/ticket/7337
2012-07-12 17:57:38 +02:00
Ingo Schommer
813ed75869
MINOR Test MenuTitle null'ing (see #7505 )
2012-06-20 18:26:55 +02:00
Ingo Schommer
e50936fe9f
MINOR Added caching to SiteTree->getStatusFlags(), as its called twice for every node now in LeftAndMain->SiteTreeAsUL() (see #7410 )
2012-06-12 19:35:15 +02:00
Sean Harvey
542d727db2
MINOR Don't use deprecated extraStatics when adding extra statics with
...
DataExtension
2012-05-23 22:13:27 +12:00
Sean Harvey
c72bae3a8e
MINOR Fixing assertType() assertions with assertInstanceOf()
2012-05-09 23:06:55 +12:00
Ingo Schommer
8563322971
BUGFIX Fixed publication of multibyte URLSegment in SiteTree->onBeforeWrite(), was wrongly detecting a change and double encoding
2012-05-08 23:45:29 +02:00
Andrew O'Neil
d1c500a5f9
MINOR: Remove checks for PHP <5.3.2, as it's no longer supported
2012-04-18 10:36:55 +12:00
Simon Welsh
b8e86ae261
MINOR Add newline to end of files without one
2012-04-15 10:56:40 +12:00
Normann Lou
c1b248e2cf
ENHANCEMENT SiteTree->getStatusFlags() which makes SiteTree->getTreeTitle() extensible
2012-04-04 23:02:53 +02:00
Sean Harvey
0ea9451014
MINOR Fixes to method arguments in cms classes for E_STRICT support.
2012-03-27 21:42:54 +13:00
Ingo Schommer
f620f9b46c
MINOR Using <button> tags for CMS UI, and new 'data-icon' HTML5 attribute to denote icons
2012-02-17 15:30:37 +01:00
Ingo Schommer
f4e3e79c0d
API CHANGE Removed ThumbnailStripField class, as it was only used for the CMS image insertion logic (which was rewritten with a more powerful file selection based on GridField)
2012-02-14 13:32:58 +01:00
Fred Condo
d99e3a0927
Code cleanup: removed trailing ?> markers per code standard.
...
All cms module except lang directory.
2012-02-13 12:48:41 -08:00
Ingo Schommer
a570e2f2a0
API CHANGE Publish ex-VirtualPage records when their page type changes, propagate type change to live (AIR-78) BUGFIX Remove extraneous database rows when changing a page from VirtualPage to another type (AIR-78)
2012-01-14 13:07:48 +01:00
Ingo Schommer
0e4e8034d6
BUGFIX Validate SiteTree::$can_be_root on saving, as well as for VirtualPage originals (AIR-80)
2012-01-14 11:20:54 +01:00
Ingo Schommer
87c318d168
BUGFIX Don't create new version on related VirtualPage records in SiteTree->onAfterWrite() when the write was triggered through writeWithoutVersion(). Use a new $_nextWriteWithoutVersion flag replacing the -1 Version number for this purpose (AIR-97) (see similar commit in sapphire)
2012-01-14 11:11:21 +01:00
Ingo Schommer
7a80e6d2ea
MINOR Ensuring assets/ folder is created before using it in FileLinkTrackingTest (and using ASSETS_PATH constant instead of hardcoding it)
2011-12-16 17:29:50 +01:00
Ingo Schommer
0b5d20513c
ENHANCEMENT Using new URLPathFilter API in SiteTree->generateURLSegment(), allowing customisation of URL filtering and transliteration
2011-11-29 10:45:19 +01:00
Stig Lindqvist
a3a50b7b6f
MINOR Skipping test when PHP Version is lower than 5.3.2
...
ReflectionMethod#setAccessible was released in PHP Version 5.3.2
2011-10-22 16:17:28 +02:00
Ingo Schommer
f98bc8480c
BUGFIX Respect writeWithoutVersion() when updating VirtualPage relationships in SiteTree->onAfterWrite() (AIR-97)
2011-10-07 11:12:52 +02:00