Commit Graph

799 Commits

Author SHA1 Message Date
Sergey Shevchenko
0db24fc038
FIX SiteTree::getCMSActions unpublish action (#2703)
* TEST SiteTree::getCMSAction produces valid actions

* FIX Fix invalid SiteTree unpublish action declaration

* refactor: moved new functions to conform with existing naming conventions

see https://github.com/silverstripe/silverstripe-cms/pull/2703#discussion_r789208512
2022-01-21 13:27:02 +13:00
Steve Boyd
854393346f
MNT Assert string 2021-11-19 09:52:29 +13:00
Maxime Rainville
b888dc1414
Merge pull request #2689 from creative-commoners/pulls/4.9/behat
MNT Update behat tests
2021-11-18 17:17:27 +13:00
Steve Boyd
96fdf6dc72 Merge branch '4.9' into 4 2021-11-18 17:07:02 +13:00
Steve Boyd
1e3970fefd MNT Update behat tests 2021-11-17 14:10:48 +13:00
Steve Boyd
c754486693
Merge pull request #2685 from GuySartorelli/patch-1
FIX: Treat absolute links in a consistent manner in get_by_link.
2021-11-15 15:10:58 +13:00
Guy Sartorelli
1db69ee91a ENH: Add tests for absolute URLs in get_by_link 2021-11-15 14:30:44 +13:00
Florian Thoma
480baa6ef8
FIX Use correct canonical tag on VirtualPage (#2688) 2021-11-04 14:59:14 +13:00
kevin-hine-innis
bcbeb6d626
FIX SiteTreeLinkTracking_Parser should use the getAnchorsOnPage (#2697)
Currently, the SiteTreeLinkTracking_Parser only checks the page's content for anchors.
As a result, any anchors that have been added or modified by the updateAnchorsOnPage extension in the getAnchorsOnPage method are marked ss-broken.

This change updates SiteTreeLinkTracking_Parser to get the anchors from the getAnchorsOnPage function on SiteTree. This will allow for more consistent RegEx matching and allow the updateAnchorsOnPage extension to be used when checking for broken links.
2021-11-04 09:31:34 +13:00
Steve Boyd
360fbcd878 API phpunit9 support 2021-10-28 10:40:52 +13:00
Aaron Carlino
f3a76ccf2d
NEW: getByLink plugin allows arrays of links (#2666)
* NEW: getByLink plugin allows arrays of links

* Allow configurable resolver

* Remove unused exception tag

* Refactor to preserve API backward compat

* Unit test

* Add plugin to readOne

* Fix test

* add new test
2021-09-07 09:34:52 +12:00
Steve Boyd
db9d86eade MNT Use logInAs() for unit tests 2021-08-18 17:18:01 +12:00
Steve Boyd
e98110d336
MNT Update tests to use logInAs() (#2679) 2021-08-18 12:35:36 +12:00
Steve Boyd
12c11e5308 Merge branch '4.8' into 4 2021-07-07 14:01:30 +12:00
Steve Boyd
c2026d06bf MNT Update embed shortcode unit test 2021-06-29 12:53:48 +12:00
Andre Kiste
87ac196378
Merge pull request #2585 from open-sausages/pulls/4/toast-react
BUG Fix Behat test to use new toast notification step
2021-05-21 15:43:24 +12:00
Steve Boyd
d7570cb0e6 MNT Use behat-extension function for clicking elements 2021-04-15 13:42:45 +12:00
Steve Boyd
acbcf4660c Merge branch '4.6' into 4.7 2021-03-21 10:25:47 +13:00
Steve Boyd
1ccf67b158 MNT Fix archive button behat test 2021-03-18 15:15:16 +13:00
Steve Boyd
babc8a462e Merge branch '4.6' into 4.7 2021-01-02 10:40:57 +13:00
Garion Herman
af5f7fc445 FIX Re-patch language in behat reports test
The language string supporting the title of this report was updated, then
reverted, then updated again, but the related behat test didn't get re-updated
at the same time.
2020-12-09 14:34:16 +13:00
Steve Boyd
9e2d04ab90 MNT Fix broken pages with no content behat test 2020-11-06 13:02:50 +13:00
Steve Boyd
4e10bcfc51 ENH Disable option to create top-level pages based on permissions 2020-10-22 21:21:15 +13:00
Garion Herman
f9f440c35d
Merge pull request #2602 from creative-commoners/pulls/4/fix-pgsql-unit-test-run
MNT Fix unit tests not running on PGSQL build
2020-10-22 15:15:50 +13:00
Garion Herman
8a16d708d4 FIX Use Live stage to fetch results during SearchFormTest
This resolves an issue with the testUnpublishedPagesNotIncluded case
when running against PostgreSQL.
2020-10-22 14:42:27 +13:00
Maxime Rainville
fd2184e7d1 Merge branch '4.6' into 4 2020-10-22 13:33:16 +13:00
Maxime Rainville
f4edd35989 Merge branch '4.5' into 4.6 2020-10-22 10:50:44 +13:00
Maxime Rainville
aaf4fb4d7a BUG Remove broken RESOURCES_DIR test 2020-10-15 15:12:44 +13:00
Mojmir Fendek
0fcda80f02 BUG: URL segment filter correction for CMS page search. 2020-10-06 08:37:22 +13:00
Maxime Rainville
2332831a2d BUG Fix Behat test to use new toast notification step 2020-09-17 17:48:32 +12:00
Steve Boyd
c5a96a2a87 FIX Flush embed shortcode provider cache on SiteTree write 2020-08-26 10:13:39 +12:00
Maxime Rainville
31fa262475 BUG Honour URL suffix on URL Segment field 2020-08-06 14:23:58 +12:00
Nicolaas Thiemen
bbb69cfb5a PATCH: fixing behat wording 2020-07-08 13:50:47 +12:00
Michal Kleiner
d8331c1e0a Use short array syntax across the module's codebase 2020-04-19 16:18:01 +12:00
Ingo Schommer
e51bd421a6 FIX InnoDB FULLTEXT compat in tests
> InnoDB FULLTEXT indexes have special transaction handling characteristics due its caching and batch processing behavior. Specifically, updates and insertions on a FULLTEXT index are processed at transaction commit time, which means that a FULLTEXT search can only see committed data. The following example demonstrates this behavior. The FULLTEXT search only returns a result after the inserted lines are committed.

https://dev.mysql.com/doc/refman/5.6/en/innodb-fulltext-index.html#innodb-fulltext-index-transaction
2020-04-09 11:05:19 +12:00
Ingo Schommer
dd839ca2d9 FIX Remove searchEngine() test that's using API wrong
Required to allow InnoDB usage, see https://github.com/silverstripe/silverstripe-framework/pull/9454.

This came up in https://github.com/silverstripe/silverstripe-cms/issues/1452, and wasn't fully addressed.
Either we allow boolean mode and all the constraints this brings around special character usage,
or we filter out those special characters, which makes boolean mode pointless.
You can't just pass arbitrary user input in a power-user function like this.
See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html

Context: This used to work for some examples like "foo>*" under MyISAM,
presumably because it had a more lenient parser. InnoDB rightfully complains about this now.
2020-04-09 09:59:53 +12:00
Serge Latyntcev
ac123ee700 Merge branch '4.4' into 4 2019-09-23 16:34:24 +12:00
Serge Latyntcev
4fdcb8180a Merge branch '4.3' into 4.4 2019-09-23 16:22:29 +12:00
Serge Latyntcev
80bcc70d38 Merge branch '4.2' into 4.3 2019-09-23 16:21:50 +12:00
Robbie Averill
6d7cc4f5c0
Merge pull request #2431 from muskie9/pull/pageTypeDropdown#2430
BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false
2019-09-16 18:04:23 -07:00
Robbie Averill
a083fc5d5b Merge branch '4.4' into 4 2019-07-19 11:50:38 +02:00
Dylan Wagstaff
68f6eaa663 FIX display recognisable names for dependent content with no title
Content blocks and other DataObjects that contain HTMLText fields are
also used in the 'Dependent pages' report for each page in the CMS,
however these objects may have neither a Title field, nor a name to
describe them. Instead of showing an empty field in the Title column for
this table, we can instead show "Untitled " with the localised singular
name appended.
2019-07-17 15:30:07 +12:00
Sam Minnee
469e7ca01b FIX: Make test comparison less brittle in MigrateSiteTreeLinkingTaskTest
Comparing every single field is unnecessary and brittle, only the IDs
need to be compared.

Notably this tripped over a potential bug fix in
https://github.com/silverstripe/silverstripe-framework/pull/8591
but the change should be incorporated regardless.
2019-05-28 12:51:23 +12:00
Nic Horstmeier
1b3a4aea96 BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false
resolves #2430
2019-05-16 19:53:59 -05:00
Loz Calver
7592db918f FIX: VirtualPage missing methods from target page (fixes #2408) 2019-04-18 14:01:26 +01:00
Robbie Averill
79e1b06d17
Merge pull request #2373 from sminnee/search-or-choose-page
MINOR: Change “Choose Page” to “Search or choose Page”
2019-04-17 12:30:46 +12:00
ttunua
0b56a563c0 FIX: Fixes #2110 added default Title value for saved pages. (#2366)
* FIX: Fixes #2110 added default Title value for saved pages.

* FIX: Fixes #2110 fixed linting and unit test failure

* BUG Rename default wording for untitled page
2019-04-15 14:33:15 +12:00
Robbie Averill
d4571d927d Merge branch '4.3' into 4 2019-04-11 11:46:19 +12:00
Serge Latyntcev
de5fc49917 Remove flush from CMSPageHistoryControllerTest
flushing in tests is futile
2019-04-01 10:58:53 +13:00
Robbie Averill
abd661bfab SiteTreeTest::testReadArchiveDate() now tests ORM results rather than underlying sql arguments 2019-02-11 14:30:25 +03:00