tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity
6,525 Commits 29 Branches 403 Tags 28 MiB
4f37770864
Commit Graph

2929 Commits

Author SHA1 Message Date
kevin-hine-innis
bcbeb6d626
FIX SiteTreeLinkTracking_Parser should use the getAnchorsOnPage (#2697) 
Currently, the SiteTreeLinkTracking_Parser only checks the page's content for anchors.
As a result, any anchors that have been added or modified by the updateAnchorsOnPage extension in the getAnchorsOnPage method are marked ss-broken.

This change updates SiteTreeLinkTracking_Parser to get the anchors from the getAnchorsOnPage function on SiteTree. This will allow for more consistent RegEx matching and allow the updateAnchorsOnPage extension to be used when checking for broken links.
 2021-11-04 09:31:34 +13:00
Adrian Humphreys
ecd9759f83
FIX Remove unused code (#2693) 2021-10-19 12:30:00 +13:00
kevin-hine-innis
2bf691f548
FIX ensure updateAnchorsOnPage extension is called (#2686) 
Currently, if there are no anchors found in the page content, the updateAnchorsOnPage extension is not called.
This change will call the updateAnchorsOnPage extension regardless of the page content.
 2021-09-28 12:36:37 -07:00
GuySartorelli
734eb3921f
FIX: Treat absolute links in a consistent manner in get_by_link. 
Fixes #2580 

The call to `Director::makeRelative` transforms absolute links into relative links. Previously, this meant that you could pass in "https://example.co.nz/about-us" or "about-us" and get the same result, but passing in "https://example.co.nz/" and "/"  would give _different_ results.
This commit performs the transformation to a relative link _before_ checking if the path should be for the home page, which leads to more consistent results.
 2021-09-21 17:09:48 +12:00
Aaron Carlino
f3a76ccf2d
NEW: getByLink plugin allows arrays of links (#2666) 
* NEW: getByLink plugin allows arrays of links

* Allow configurable resolver

* Remove unused exception tag

* Refactor to preserve API backward compat

* Unit test

* Add plugin to readOne

* Fix test

* add new test
 2021-09-07 09:34:52 +12:00
Nicolaas
10e2c1f271
PATCH: docblock for return value fixed for get_by_link 2021-07-17 11:39:18 +12:00
Steve Boyd
ac35e94a19 Merge branch '4.7' into 4.8 2021-05-28 13:31:35 +12:00
Nic Horstmeier
85c3b1096b
UPDATE generate canonical via MetaComponents 
This replaces using the `MetaTags` method as replacing or removing a canonical requires string manipulation vs unsetting an array key, and is preferred.
 2021-04-05 19:52:35 -05:00
Steve Boyd
f892205b9b
Merge pull request #2638 from wilr/pulls/undefined 
FIX undefined variable inChangeSets
 2021-03-22 14:13:07 +13:00
Will Rossiter
db7efad6ca
FIX undefined variable inChangeSets 2021-03-05 14:48:08 +13:00
Steve Boyd
7886e51f81 Merge branch '4.7' into 4 2021-01-02 10:48:03 +13:00
Steve Boyd
babc8a462e Merge branch '4.6' into 4.7 2021-01-02 10:40:57 +13:00
Steve Boyd
3bbc4aa6b3 Merge branch '4.5' into 4.6 2021-01-02 10:17:51 +13:00
Aaron Carlino
e415d41856 BUGFIX: Restore, refactor getByLink plugin 2020-12-08 11:16:52 +13:00
Aaron Carlino
7b960c1537
NEW: Compliance with new SchemaConfig API (#2617) 2020-12-01 21:27:16 +13:00
Andre Kiste
e67012d571
Merge pull request #2562 from kinglozzer/2561-virtualpage-savetreenode 
FIX: Incorrect method call in savetreenode (fixes #2561)
 2020-11-19 10:12:28 +13:00
Aaron Carlino
ee3e51e5e5 Move graphql legacy code to _legacy for PSR-4 compat 2020-11-13 21:02:08 +13:00
Aaron Carlino
5ab1ff3e69
NEW: GraphQL Compatibility (#2607) 
* Add GraphQL4 compatibility

* Add getPageByLink

* Blacklist sitetree fields

* Remove getByLink from default schema. use linkable plugin

* getByLink compatability with new readOne filter anything

* Remove return type

* Compliance with new modelConfig

* Prep for travis

* Improvements for versioned-admin compat

* BC class guards

* New graphql 3 compat

* Fix travis syntax error

* New backward graphqlphp dependency

* Lint, build

* New phpcs exclusion

* Tidy up travis

* Fix rollback mutation

* Update code/GraphQL/_legacy/ReadOneResolver.php

Co-authored-by: Ingo Schommer <ingo@silverstripe.com>

* Address ingo feedback

* Deprecated GraphQL v3 classes

* Remove deleted branches

Co-authored-by: Ingo Schommer <ingo@silverstripe.com>
Co-authored-by: Ingo Schommer <me@chillu.com>
 2020-11-13 13:50:44 +13:00
Steve Boyd
4e10bcfc51 ENH Disable option to create top-level pages based on permissions 2020-10-22 21:21:15 +13:00
Maxime Rainville
fd2184e7d1 Merge branch '4.6' into 4 2020-10-22 13:33:16 +13:00
Maxime Rainville
f9c26cefa3 BUG Fix parsing error on CMSSiteTreeFilter 2020-10-22 11:52:02 +13:00
Maxime Rainville
f4edd35989 Merge branch '4.5' into 4.6 2020-10-22 10:50:44 +13:00
brynwhyman
73460f9ee0 FIX remove old syntax from meta tag label 2020-10-13 09:38:03 +13:00
Mojmir Fendek
0fcda80f02 BUG: URL segment filter correction for CMS page search. 2020-10-06 08:37:22 +13:00
Guy Marriott
a8e8ed71c5
Merge pull request #2588 from creative-commoners/add-docs 
Add docs to $enforce_strict_hierarchy
 2020-10-04 17:20:42 -07:00
Robbie Averill
d17f058622 ENH Replace E_USER_ERROR errors with exceptions 2020-09-24 17:06:31 -07:00
bergice
3bf25681be Add docs to $enforce_strict_hierarchy 2020-09-24 19:27:52 +12:00
Maxime Rainville
edbe5ad069 BUG Remove old boostrap 3 CSS class 2020-09-16 11:06:36 +12:00
Steve Boyd
72e406aa63 Merge branch '4.6' into 4 2020-09-08 14:28:09 +12:00
Steve Boyd
9739308601 Merge branch '4.5' into 4.6 2020-09-08 14:27:46 +12:00
Mojmir Fendek
39b8d14634 BUG: Unpublish permission decoupled from publish permission. 2020-08-31 12:48:43 +12:00
Steve Boyd
c5a96a2a87 FIX Flush embed shortcode provider cache on SiteTree write 2020-08-26 10:13:39 +12:00
Maxime Rainville
31fa262475 BUG Honour URL suffix on URL Segment field 2020-08-06 14:23:58 +12:00
Nicolaas
b799262976
PATCH: better english 2020-07-08 10:16:19 +12:00
Loz Calver
69825da30a FIX: Incorrect method call in savetreenode (fixes #2561) 2020-06-24 17:23:10 +01:00
Lukas Erni
926571a2bf https://github.com/silverstripe/silverstripe-cms/issues/2557 - remove FQN if lang != EN on SiteType dropdown in page-settings 2020-06-17 16:28:23 +02:00
Maxime Rainville
9974c6e206 Merge branch '4.5' into 4 2020-05-26 14:27:33 +12:00
Klemen Dolinšek
c92e3b9d79 BUG Prioritise same-level pages in OldPageRedirector 
Added option to pass integer ParentID=0 to OldPageRedirector::find_old_page to ensure search through nested pages from the root of SiteTree structure. Added new call of function and still offering fallback to old behaviour if first call returns false (fixed #2522)
 2020-05-04 09:11:19 +02:00
Garion Herman
891f068202 FIX Correct placement of 'Page location' field title 2020-05-01 15:45:08 +12:00
Nicolaas
22694c7474
PATCH: fixing properties in comments 2020-05-01 11:01:51 +12:00
Michal Kleiner
d8331c1e0a Use short array syntax across the module's codebase 2020-04-19 16:18:01 +12:00
Mojmir Fendek
d7c76bdbba BUG: Published pages filter correction (missing default filter) 2020-04-15 13:31:02 +12:00
mattclegg
58795a2324
REFACTOR: Remove duplication and set SiteTree instances to use generic CMSEditLink() 2020-04-10 09:12:39 +05:45
mattclegg
d85cc24aa0
DOCS: Set @var to SiteTree where appropriate 2020-04-10 09:11:00 +05:45
Robbie Averill
e81659344c
Merge pull request #2536 from mattclegg/1585990198 
ENHANCEMENT: Remove unused $controller from lambda function
 2020-04-05 19:16:44 -07:00
mattclegg
2bbc280ce6
ENHANCEMENT: Remove unused $controller from lambda function 2020-04-04 16:20:24 +05:45
Klemen Dolinšek
ed41f15799 BUG Prioritise same-level pages in OldPageRedirector 
Added option to pass integer ParentID=0 to OldPageRedirector::find_old_page to ensure search through nested pages from the root of SiteTree structure. Added new call of function and still offering fallback to old behaviour if first call returns false (fixed #2522)
 2020-02-11 22:30:42 +01:00
Will Rossiter
6ee17a83e3
NEW Add extension hook updateRedirectionLink() 2020-01-24 22:13:03 +13:00
Amol Wankhede
de96188c8a FIX: If no parent in RelativeLink() return null 2019-12-04 17:08:49 +13:00
Guy Marriott
3a028ac1ec
Negotiator amends: Make it possible to disable Preview links in… (#2492) 
Negotiator amends: Make it possible to disable Preview links in the CMS
 2019-11-28 09:18:32 -08:00
Adrian Humphreys
7045082a06 BUG Cache page icons (#2493) 2019-11-13 10:21:52 +13:00
Lee Bradley
c8ccd6a8c4 Amends made requested during Pull Request 
Requested by @andrewandante & @ScopeyNZ
 2019-10-30 09:02:18 +00:00
Lee Bradley
31f99445bd Negotiator amends: Make it possible to disable Preview links in the CMS 
Existing functionality is limited to `RedirectorPage`

Another option would be to use the HiddenClass methodology
 2019-10-29 17:43:17 +00:00
Serge Latyntcev
c1159c849f Merge branch '4.4' into 4 2019-10-18 13:20:01 +13:00
Serge Latyntcev
06c481bb8d Merge branch '4.3' into 4.4 2019-09-24 14:55:57 +12:00
Serge Latyntsev
c7e44f85aa
Merge pull request #7 from silverstripe-security/pulls/4.3/joseph-installin 
[CVE-2019-12204]: install.php warning does not account for public dir
 2019-09-24 11:25:49 +12:00
Serge Latyntcev
ac123ee700 Merge branch '4.4' into 4 2019-09-23 16:34:24 +12:00
Serge Latyntcev
4fdcb8180a Merge branch '4.3' into 4.4 2019-09-23 16:22:29 +12:00
Serge Latyntcev
80bcc70d38 Merge branch '4.2' into 4.3 2019-09-23 16:21:50 +12:00
Robbie Averill
6d7cc4f5c0
Merge pull request #2431 from muskie9/pull/pageTypeDropdown#2430 
BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false
 2019-09-16 18:04:23 -07:00
Dileep Ratnayake
075c98ed8e
Change self:: to static:: for better extensibility 2019-09-11 11:09:14 +12:00
Adrian Humphreys
0872a23aa8
Keep a more shared understanding of Archived 2019-09-09 07:50:10 +12:00
bergice
644376272c Add warnings when trying to remove the homepage 
Warnings are triggered when:
* Changing the URL Segment
* Unpublishing
* Unpublishing & Archiving
* Moving the homepage to another parent in the tree view

Also add `SiteTree->isHomePage()`
 2019-08-29 17:38:56 +12:00
Robbie Averill
abf026c500
Merge pull request #2471 from creative-commoners/pulls/4.4/no-caching-on-previews-or-drafts 
FIX Disable caching on page previews (CMSPreviews or stage=Stage)
 2019-08-22 14:09:11 +12:00
Garion Herman
8e3072922f FIX Disable caching on page previews (CMSPreviews or stage=Stage) 2019-08-22 13:52:54 +12:00
Aaron Carlino
f98a59deb5 [CVE-2019-12204]: install.php warning does not account for public dir 2019-08-20 21:45:29 +12:00
James Cocker
1316245b37 Updated “URL Segment” & “Main Content” to sentence case 2019-08-14 17:38:36 +01:00
Robbie Averill
59b9a0d664
Merge pull request #2411 from kinglozzer/virtualpage-definemethods 
FIX: VirtualPage missing methods from target page (fixes #2408)
 2019-08-05 13:16:08 +12:00
hirenpatel
9bcb395387 Changing to protected to match the rest of the changes 2019-08-02 15:08:05 +01:00
Robbie Averill
a083fc5d5b Merge branch '4.4' into 4 2019-07-19 11:50:38 +02:00
Dylan Wagstaff
68f6eaa663 FIX display recognisable names for dependent content with no title 
Content blocks and other DataObjects that contain HTMLText fields are
also used in the 'Dependent pages' report for each page in the CMS,
however these objects may have neither a Title field, nor a name to
describe them. Instead of showing an empty field in the Title column for
this table, we can instead show "Untitled " with the localised singular
name appended.
 2019-07-17 15:30:07 +12:00
Aaron Carlino
8a44071ec6 Merge branch '4.4' into 4 2019-06-10 16:26:55 +12:00
Aaron Carlino
3bf78e05df Merge branch '4.3' into 4.4 2019-06-10 16:26:32 +12:00
Aaron Carlino
b7707f319c Merge branch '4.2' into 4.3 2019-06-10 16:26:08 +12:00
Robbie Averill
325d227fe0 FIX Virtual page notice now uses Bootstrap 4 alerts 2019-05-31 14:50:46 +12:00
Robbie Averill
cd70aecf8d
Merge pull request #2421 from creative-commoners/pulls/4.4/adding-removing-overlapping-icons 
FIX Only add page font icon classes if there's no icon image defined
 2019-05-31 13:56:14 +12:00
Garion Herman
c569cec4ea NEW Add updateHintsCacheKey extension point to fix invalid caching 
If a module augments the allowed pagetypes based on external conditions,
the Hints Cache Key will not cover these conditions and may cause
incorrect output. An example of this is Subsites, which allows each
Subsite to have a different set of allowed pagetypes.
 2019-05-31 10:21:07 +12:00
Maxime Rainville
46b77f3592 MINOR Do not assume SiteTree's table will always be call SiteTree. 2019-05-17 13:40:15 +12:00
Nic Horstmeier
1b3a4aea96 BUGFIX Page Type listed in Page Type dropdown when $can_be_root is false 
resolves #2430
 2019-05-16 19:53:59 -05:00
Guy Marriott
892a91ae3e
FIX Only add page font icon classes if there's no icon image defined 2019-05-08 16:13:33 +12:00
Robbie Averill
7cfa771681 FIX Use Bootstrap 4 alert for page type restriction message when adding a page 
Bootstrap 4 alerts are the default in SilverStripe 4.4, this one is custom so was missed during the update
 2019-05-03 15:35:08 +12:00
Loz Calver
7592db918f FIX: VirtualPage missing methods from target page (fixes #2408) 2019-04-18 14:01:26 +01:00
ttunua
0b56a563c0 FIX: Fixes #2110 added default Title value for saved pages. (#2366) 
* FIX: Fixes #2110 added default Title value for saved pages.

* FIX: Fixes #2110 fixed linting and unit test failure

* BUG Rename default wording for untitled page
 2019-04-15 14:33:15 +12:00
Ingo Schommer
ab01ac99e3 API Deprecated CMSMain->publishall() 
The current implementation doesn't scale,
and due to the proliferation of versioned objects
no longer fully works (e.g. doesn't publish all files).

Fixes https://github.com/silverstripe/silverstripe-cms/issues/2406
 2019-04-10 10:44:14 +12:00
Guy Marriott
432266dcd2
Merge pull request #2391 from sachajudd/pulls/4.4/add-new-page 
FIX Deprecate creatableChildren and add new function to support font-icon classes for allowedChildren
 2019-04-08 14:08:14 +12:00
Guy Marriott
d2236f0954
Update code/Model/SiteTree.php 
Co-Authored-By: sachajudd <sjudd@silverstripe.com>
 2019-04-08 11:45:52 +12:00
Guy Marriott
10ff962ece
Update code/Model/SiteTree.php 
Co-Authored-By: sachajudd <sjudd@silverstripe.com>
 2019-04-08 11:45:44 +12:00
Guy Marriott
4685523b9b
Update code/Model/SiteTree.php 
Co-Authored-By: sachajudd <sjudd@silverstripe.com>
 2019-04-08 11:10:07 +12:00
Al Twohill
dcfb502e5c Addresses #2401 
Note, I've got no idea behind the logic of should_be_on_root - the change is a best guess based on the fact that `Translatable` doesn't exist in SS4 yet
 2019-03-28 20:40:33 +13:00
Sacha Judd
a0aaf050d4 FIX Deprecate creatableChildren and add new function to support font-icon classes for allowedChildren 2019-02-25 17:00:47 +13:00
Robbie Averill
12512e84b1 NEW BrokenLinksReport now uses injector for fields, uses short array syntax and single quotes 2019-02-22 16:11:15 +07:00
Robbie Averill
c1c9d7706a Merge branch '4.3' into 4 2019-02-06 22:25:40 +03:00
Robbie Averill
23ae682b35 Merge branch '4.2' into 4.3 2019-02-06 22:24:53 +03:00
Robbie Averill
976bbc1014 Merge branch '4.1' into 4.2 2019-02-06 22:24:32 +03:00
Robbie Averill
668670b5a1 Merge branch '4.0' into 4.1 2019-02-06 22:24:14 +03:00
Ingo Schommer
f8a8b38a0a Consistent check of allow_multibyte 
It uses an injected instance everywhere else.
See https://github.com/silverstripe/silverstripe-cms/pull/2365#discussion_r247383809
 2019-02-05 16:45:28 +03:00
Ingo Schommer
5c3b95ac89 FIX Multibyte URL routing 
Was double url encoding (once in database value, then again in request)
Fixes https://github.com/silverstripe/silverstripe-framework/issues/8723
 2019-02-05 16:45:28 +03:00
Guy Marriott
97ee18d463
Merge pull request #2382 from creative-commoners/pulls/4.4/remove-add-to-campaign-button 
FIX Remove coupling from SiteTree to campaign admin module
 2019-02-04 22:20:35 +13:00
Ingo Schommer
12274fb6ec Consistent check of allow_multibyte 
It uses an injected instance everywhere else.
See https://github.com/silverstripe/silverstripe-cms/pull/2365#discussion_r247383809
 2019-02-04 22:04:48 +13:00
Ingo Schommer
c61ba88d82 FIX Multibyte URL routing 
Was double url encoding (once in database value, then again in request)
Fixes https://github.com/silverstripe/silverstripe-framework/issues/8723
 2019-02-04 22:02:15 +13:00