Commit Graph

239 Commits

Author SHA1 Message Date
Ingo Schommer
45f87288fc API CHANGE Moved CMSMain/AssetAdmin/SecurityAdmin implementations for getEditForm() and save() to a common parent: LeftAndMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92834 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:20:26 +00:00
Ingo Schommer
98ce1b1f07 MINOR Moved batch actions code from AssetAdmin/CMSMain to a common LeftAndMain parent (which is now reused by SecurityAdmin as well)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:20:21 +00:00
Ingo Schommer
0c52d36846 BUGFIX Fixed undefined variable in CMSMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:19:49 +00:00
Ingo Schommer
343044e89c ENHANCEMENT Using built-in TableListField javascript deletion for AssetTableField
ENHANCEMENT Less template overloading in AssetTableField.ss

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:19:47 +00:00
Ingo Schommer
2e7f100a1c MINOR Moved LeftAndMain.BatchActions.js to LeftAndMain, its used in AssetAdmin as well
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92809 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:19:20 +00:00
Ingo Schommer
e47ce88853 ENHANCEMENT Making CMSBatchActionHandler specific to record class, in order to have different batch actions for AssetAdmin (removing folders). Added CMSBatchActionHandler->batchActions() and changed internal representation of batch actions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92801 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:19:02 +00:00
Ingo Schommer
58cd7beb33 MINOR Renamed CMSMain->addpage() to CMSMain->doAdd()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92800 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:18:59 +00:00
Ingo Schommer
34f8f9eaf3 MINOR Moved batch actions javascript from CMSMain.BatchAction.js to LeftAndMain.BatchActions.js to make it reuseable in AssetAdmin
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92798 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:18:55 +00:00
Ingo Schommer
b9bfcc99b5 API CHANGE Renamed CMSMain->AddPageOptionsForm() to AddForm()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92797 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:18:51 +00:00
Ingo Schommer
23bac6e84f API CHANGE LeftAndMain->EditForm() returns EmptyForm() by default, as not all subclasses might want to implement the previously used getEditForm() method (e.g. ModelAdmin, which has its own sub-controllers to handle requests). Added specialized EditForm() overrides to AssetAdmin and CMSMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:17:16 +00:00
Ingo Schommer
e22fdb94ca BUGFIX Defaulting to current page ID in CMSMain->EditForm()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92757 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:17:11 +00:00
Ingo Schommer
94eada294e API CHANGE Removed unnecessary CMSMain->getpagecount() method
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92751 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:57 +00:00
Ingo Schommer
44e3966d96 ENHANCEMENT Removed manual SiteTree->Status setting in LeftAndMain controllers, use specific getters like SiteTree->IsAddedToStage for this purpose
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92745 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:42 +00:00
Ingo Schommer
64e042a2a3 ENHANCEMENT Removed unused LeftAndMain->DeleteItemsForm
ENHANCEMENT Moved LeftAndMain->deleteitems() into SecurityAdmin, its the only place where its not replaced by CMSBatchAction yet

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92743 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:38 +00:00
Ingo Schommer
420d0a5c57 MINOR Removed unused LeftAndMain->PublishItemsForm(), has been replaced by CMSBatchAction a while ago
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92742 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:35 +00:00
Ingo Schommer
cb1895866a ENHANCEMENT Refactored versions panel in CMS: Removed "compare mode" checkbox in UI, and replaced with explicit checkboxes and a "compare versions" button. Added manual "refresh" button. Replaced custom markup with a form generated through CMSMain->VersionsForm(), and adjusted markup in CMSMain_versions.ss accordingly
API CHANGE Removed CMSMain->sendFormToBrowser(), replaced with custom code

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:09 +00:00
Ingo Schommer
c50e2fce6b MINOR Moved form related javascript from CMSMain.js to new CMSMain.EditForm.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92729 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:03 +00:00
Ingo Schommer
01d06dd47e API CHANGE Replaced CMSMain->LangSelector() with CMSMain->LangForm() to provide more accessible backend and properly wrap existing <select> tag in a form
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92728 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:00 +00:00
Ingo Schommer
2796a37a02 API CHANGE Removed SideReport javascript class, replaced with concrete implementation in CMSMain.js
ENHANCEMENT Using full form for 'site reports' panel in CMSMain->ReportForm(). Removed CMSMain->ReportSelector()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92727 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:55 +00:00
Ingo Schommer
1760759992 MINOR Moved LeftAndMain_left.js to LeftAndMain.Tree.js
MINOR Moved CMSMain_left.js to CMSMain.Tree.js

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92726 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:51 +00:00
Ingo Schommer
49ff1648bd MINOR Fixed parameters in CMSMain->getfilteredsubtree()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:43 +00:00
Ingo Schommer
44e16b9620 API CHANGE Removed CMSBatchAction->getDoingText(), is now using button loading indicators in the UI
API CHANGE Removed LeftAndMain->BatchActionList(), no longer necessary as we're creating the batch actions form in the same class
ENHANCEMENT Changed CMSBatchAction logic to return JSON status changes rather than eval'ed JavaScript via FormResponse
ENHANCEMENT Ported batchactions in CMSMain_left.js to concrete javascript, and moved to new CMSMain.BatchActions.js file
ENHANCEMENT Using native CMSMain->BatchActionsForm() to render form instead of custom template markup in CMSMain_TreeTools.ss

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92722 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:40 +00:00
Ingo Schommer
9e88dbb8c5 MINOR Adding css classes to CMSMain->AddPageOptionsForm
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92711 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:16 +00:00
Ingo Schommer
dc4375a383 API CHANGE Removed LeftAndMain->EditForm(), please use getEditForm() instead
API CHANGE Returning LeftAndMain->EmptyForm() as a welcome/placeholder message from LeftAndMain->getEditForm() if no record is found. Removed this placeholder from LeftAndMain_right.ss
ENHANCEMENT Allowing optional $id parameter in LeftAndMain->getEditForm() (and subclasses)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:13 +00:00
Ingo Schommer
e30f92a2f8 API CHANGE Returning empty form from getEditForm() method in CMSMain, AssetAdmin, SecurityAdmin to avoid an <% if %> condition in the template. The previous placeholder text is now always stored alongside the form template. This also allows for easier class overloading with different URLs, as the form action is no longer hardcoded in the template placeholder form.
BUGFIX Adjusted AssetAdmin_left.ss, CommentAdmin_left.ss
MINOR Removed CommentAdmin_right.ss, SecurityAdmin_right.ss - inherits a more generic LeftAndMain_right.ss instead
MINOR Merged CommentAdmin_SiteTree.ss template back into CommentAdmin_left.ss

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92705 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:00 +00:00
Ingo Schommer
40e3f96ce8 MINOR PHP Notice in CMSMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92704 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:56 +00:00
Ingo Schommer
febe9f6e8b MINOR Removed unnecessary CMSMain_right.js javascript, was only used for form changetracking which has changed its API since
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:45 +00:00
Ingo Schommer
c2d24f9022 FEATURE Changed CMSMain and LeftAndMain form submissions to return raw HTML instead of using FormResponse logic and evaluated javascript. This allows a more customizeable UI layer that is decoupled from the serverside logic. Any state changes should be propagated through the form itself.
ENHANCEMENT Using new 'X-STATUS' HTTP response header for CMS form responses, as it is more robust for submitting variable length strings than the original 'Status' header. The status is evaluated in LeftAndMain.EditForm.js
API CHANGE Removed CMSMain->tellBrowserAboutPublicationChange(), LeftAndMain->returnItemToUser(), LeftAndMain->getActionUpdateJS(), LeftAndMain->addTreeNodeJS(), LeftAndMain->deleteTreeNodeJS(). Use javascript to respond to state changes
API CHANGE Removed CMSForm and CMSRightForm javascript classes, superseded by LeftAndMain.EditForm.js
ENHANCEMENT Removed custom change detection in LeftAndMain->save(), this should be handled by DataObject->write()
ENHANCEMENT Removed switch in LeftAndMain->save() which doesnt process saving if the record hasn't been altered, to simplify the saving logic
ENHANCEMENT Removed custom add/remove tree node logic in LeftAndMain->save() which was retrieving state from DataObjectLog. This was never actively used, and should be handled by custom clientside logic.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92674 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:12 +00:00
Ingo Schommer
b99ee16d88 ENHANCEMENT Removed CMSMain->jsDeclaration(), it was replicating functionality already present in Convert::raw2js()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92671 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:04 +00:00
Ingo Schommer
0b9f4ab533 MINOR Adjusted to SiteTree->getTreeTitle() api change
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92669 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:59 +00:00
Ingo Schommer
87a6e331e9 ENHANCEMENT Disabling validator in CMSMain->getCMSFields() unless its explicitly set through SiteTree->getCMSValidator(). We don't fully support validation in the CMS (yet), and it causes unnecessary bloat in the document body for now.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92660 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:39 +00:00
Ingo Schommer
b96a69d716 MINOR Setting ID fields in CMSMain->getEditForm()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92659 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:37 +00:00
Ingo Schommer
61a3d03883 MINOR Fixed indentation and documentation in CMSMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92658 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:35 +00:00
Ingo Schommer
0d5ee9d775 ENHANCEMENT Migrated translation dropdown javascript to concrete and renamed js include from LangSelector.js to CMSMain.Translatable.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92644 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:05 +00:00
Ingo Schommer
671961cf45 ENHANCEMENT Refactored tree search javascript to support concrete and jquery, and build less UI scaffold on the serverside
API CHANGE Removed CMSMain::site_tree_filter_options
API CHANGE Removed CMSMain::SiteTreeFilterOptions() and T_SiteTreeFilterOptions(), now handled inline in CMSMain::TreeSearchForm()
ENHANCEMENT Refactored tree search PHP in CMSMain: Generate form in PHP instead of template, require less UI state, pass filtered/sanitized paramers straight into CMSMainMarkingFilter instead of relying on

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92618 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:37:06 +00:00
Ingo Schommer
afc285cb12 ENHANCEMENT Removed some javascript handlers for ajax submission in CMS: action_save_right(), action_publish_right() - they're now using the same unified saving method
ENHANCEMENT Moved javascript handlers in CMS to concrete: action_print_right(), action_email_right(), action_rollback_right()
ENHANCEMENT Moved javascript ParentID UI element in CMS to concrete

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:36:13 +00:00
Ingo Schommer
ae56eba853 ENHANCEMENT Using jQuery layout manager plugin to size panels in main CMS interface. Removed custom javascript resizing and CSS rules.
API CHANGE Removed custom resizing javascript methods: window.ontabschanged, window.onresize, fixRightWidth(), fixHeight_left()
API CHANGE Removed DraggableSeparator, SideTabs, SideTabItem javascript classes
API CHANGE Removed Effect.ReSize and Highlighter javascript helper classes
API CHANGE Modified template structure in CMSMain_left.ss, CMSMain_right.ss and LeftAndMain.ss
API CHANGE Modified markup IDs in LeftAndMain/CMSMain templates, removed "left", "right", "contentPanel", "bottom"
ENHANCEMENT Using jquery-latest (currently 1.3) in CMSMain and LeftAndMain
ENHANCEMENT Added jQuery UI library and "smoothness" theme to default CMS interface

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:35:20 +00:00
Ingo Schommer
094c30ea4a API CHANGE Removed ModalForm, ModalDialog, GBModalDialog javascript classes from cms, were superseded by a simple javascript alert a while ago (see r11727 and r12245)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92577 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:35:07 +00:00
Ingo Schommer
e68fca146a MINOR Removed references to empty CMSMain.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:35:03 +00:00
Ingo Schommer
3587ba8a85 BUGFIX: Pass locale rather than language to spellchecker_languages (from r87869)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90854 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 01:17:52 +00:00
Ingo Schommer
966c869cd4 BUGFIX: Tied rollback action to edit, rather than publish, permission, since it only involves editing the draft site. (from r84957)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90852 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 01:15:15 +00:00
Ingo Schommer
bb87f843ca BUGFIX: Fixed bugs in content differencer, and improved styling. BUGFIX: fixed notice when getting title of member which didnt exist. Merged from trunk r77661. (from r81942)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 01:10:38 +00:00
Ingo Schommer
2cada6ff3a MINOR Reverted accidental commit in r90823
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-04 22:52:15 +00:00
Ingo Schommer
38d179b2a3 MINOR Correct labels for "delete from draft" batch actions (#4420)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90823 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-04 22:46:54 +00:00
Sam Minnee
0071e37840 BUGFIX: Fixed glitch in permission code formats.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-31 00:58:30 +00:00
Tom Rix
1d281472ab MINOR i18n'd a whole bunch of the new permission codes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90493 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-30 01:43:34 +00:00
Tom Rix
bb59c48078 MINOR categorized reports, fixed a few translations issues.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90394 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-29 02:50:47 +00:00
Tom Rix
e3d678f8ad MINOR shuffled permissions around, gave them help text and categorized them.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90371 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-29 00:55:20 +00:00
Tom Rix
b820fb6975 MINOR permission name changes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90332 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-28 21:23:08 +00:00
Tom Rix
22702dc8a4 MINOR SideReports now have a canView method
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90286 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-28 02:21:01 +00:00
Sam Minnee
f71804e465 API CHANGE: Renamed conflicting classes to have an "SS_" namespace, and renamed existing "SS" namespace to "SS_". The affected classes are: HTTPRequest, HTTPResponse, Query, Database, SSBacktrace, SSCli, SSDatetime, SSDatetimeTest, SSLog, SSLogTest, SSLogEmailWriter, SSLogErrorEmailFormatter, SSLogErrorFileFormatter, SSLogFileWriter and SSZendLog.
MINOR: Replaced usage of renamed classes with the new namespaced name.

From: Sam Minnee <sam@silverstripe.com>


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@90076 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-26 03:06:42 +00:00
Sam Minnee
b9f59ae925 MINOR three step workflow test
MINOR prettified side reports with form labels (from r85521)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@89223 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:44:24 +00:00
Sam Minnee
a7c07369e0 FEATURE batch actions for setting/resetting embargo/expiry (from r85397)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@89221 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:44:08 +00:00
Sam Minnee
2294857460 ENHANCMENT side reports can now have parameters (from r85329)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@89220 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:43:58 +00:00
Sam Minnee
53d735c4f6 FEATURE SiteConfig (from r85339)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@89194 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:33:14 +00:00
Andrew Short
0362821d7a MINOR: Replaced usage of the deprecated SiteTree::get_by_url() with get_by_link().
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@88514 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-11 00:08:05 +00:00
Ingo Schommer
ed127fabf3 BUGFIX Changed CMSMain->LangSelector() to always return a DropdownField, which ensures the 'Locale' parameter is always available to be passed along with ajax queries
ENHANCEMENT Passing sitetree instance to CMSMain->LangSelector() in order to trigger canTranslate() filtering

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@88139 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-05 20:41:54 +00:00
Geoff Munn
85ee1007c4 MINOR FIX: prevents looping over an empty array
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@86166 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-13 22:25:41 +00:00
Ingo Schommer
61776f1e74 MINOR Using raw2sql in CMSMain->delete()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@85984 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-09 23:47:56 +00:00
Julian Seidenberg
d60fc2fdce BUGFIX: moved $versionAuthor variable invocation into a check for the existence of the $record variable on which it depends (Ticket #4458)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@85713 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-04 01:18:07 +00:00
Sam Minnee
6a209ce8df BUGFIX #4423: Don't allow page duplication if canCreate is false.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@85157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-25 05:52:52 +00:00
Tom Rix
59f0eda007 MINOR removed development artefact
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@83675 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-04 03:10:19 +00:00
Tom Rix
6a0f21ca05 ENHANCEMENT sitetree filters now show up in a dropdown, and you can add your own by extending CMSSiteTreeFilter
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@83674 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-04 03:09:26 +00:00
Ingo Schommer
eebaebca0e BUGFIX Setting lang-code instead of locale in CMSMain->init() for TinyMCE spell checking
BUGFIX Always choosing translatable default language in CMSMain->init() for TinyMCE spell checking. Always setting $CMSMain->Locale in order to have it available for the spell checking

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@81716 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-13 21:11:03 +00:00
Sam Minnee
adeb3ea5ec BUGFIX If a page revision has no author, don't completely break the CMS when trying to view that revision
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@81463 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 05:41:42 +00:00
Sam Minnee
ed70de49b8 BUGFIX "Page type" dropdown for site tree filters is now sorted alphabetically, to be consistent with the "Create" page type dropdown list
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@81462 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 05:41:30 +00:00
Sam Minnee
0690d9f4a4 BUGFIX: Correct behaviour if CMSMain::tellBrowserAboutPublicationChange() isn't passed a status message
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@81461 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 05:41:12 +00:00
Sean Harvey
a1b04f1018 BUGFIX Ensure that CMSMainMarkingFilter::mark() always passes an integer into array_key_exists() or it will break
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@77832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-26 04:06:33 +00:00
Sam Minnee
646ed9342a BUGFIX: Fixed bugs in content differencer, and improved styling.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@77661 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-23 03:30:57 +00:00
Sean Harvey
f27122e102 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@77033 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-18 00:23:52 +00:00
Sean Harvey
c69994f98f Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@77023 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-17 23:19:51 +00:00
Ingo Schommer
b62bb7ab77 MINOR Updated CMSMain to Translatable API changes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@77007 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-17 05:36:51 +00:00
Ingo Schommer
8362026b12 BUGFIX Fixed CMSMain->LangSelector() default language selection
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@76870 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-14 21:27:10 +00:00
Sean Harvey
b360ad9cd7 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@76857 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-14 06:11:18 +00:00
Ingo Schommer
7fc439dcd3 MINOR Adapted to API change in r76853 (Translatable::get_current_locale())
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@76854 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-14 06:06:34 +00:00
Ingo Schommer
e99ef98e89 ENHANCEMENT Using standard LanguageDropdownField in CMSMain->LangSelector()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@76840 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-14 05:18:37 +00:00
Ingo Schommer
9da24cdfb5 BUGFIX Removed obsolete CMSMain->EditingLang(), not used any longer (see #3997)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@76731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-13 06:02:31 +00:00
Sean Harvey
182d1061a9 Merged from 2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@76270 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-06 06:37:45 +00:00
Sean Harvey
4e4810bbb6 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@75780 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-04-30 22:47:28 +00:00
Sean Harvey
42a6692d79 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@75592 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-04-29 01:44:28 +00:00
Ingo Schommer
893df91e33 ENHANCEMENT Adjusted CMSMain and LeftAndMain to use locales instead of short lang codes when reading and writing translations. See r73468 for details on the underlying Translatable datamodel change
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@73469 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-20 08:49:27 +00:00
Ingo Schommer
15454352bb ENHANCEMENT Showing all available languages in language selector above sitetree in CMS - you can now create new pages in completely new languages without any relation to an "original"
ENHANCEMENT Added CMSMain->IsTranslatableEnabled
API CHANGE Removed CMSMain->switchlanguage() - createTranslation() is sufficient for new, ajax refreshing of CMS state got way too complicated for switching languages, we now just reload the entire CMS with a different ?lang GET parameter

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@73345 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-18 17:18:52 +00:00
Ingo Schommer
be985afd24 API CHANGE Using RequiredFields or DataObject->getCMSValidator() in CMSMain->getEditForm(), which means all pages in the CMS will have validation enabled, e.g. for date fields. This is necessary to avoid a global disabling of javascript validation through Validator::set_javascript_validation_handler('none') breaking the CMS, which relies on javascript responses through Form->validate() and the FormResponse class (without specifically requesting them through HTTP Accept headers). See #3386 and #2915
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@73336 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-18 13:03:52 +00:00
Geoff Munn
75b1484fca API CHANGE: column names escaped
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@72425 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-03 21:43:47 +00:00
Sean Harvey
31f530cb0f Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@71279 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-03 03:56:56 +00:00
Sean Harvey
3680bbea46 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@71264 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-03 03:22:20 +00:00
Sean Harvey
3d4630a2c8 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@71259 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-03 02:50:25 +00:00
Ingo Schommer
fd65285cfc ENHANCEMENT Simplifying creation logic of new languages in CMS by reloading complete interface, rather than refreshing partial interface, language dropdown etc.
API CHANGE Removed CMSMain->switchlanguage()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@70307 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-16 04:16:19 +00:00
Ingo Schommer
c8beba696c Merged, debugged and enhanced Translatable patches from branches/translatable at r64523, r64523, 64523, thanks wakeless!
API CHANGE Changed Translatable schema from auxilliary tables (SiteTree_lang, SiteTree_lang_Live) to automatically filtered records on the original table (SiteTree, SiteTree_Live), using $Lang and $OriginalID properties. Incompatible update to old schema, migration script is in the works.
API CHANGE Removed Translatable::get_one(), Translatable::write()
ENHANCEMENT Simplified Translatable tree generation by using getSiteTreeFor() in CMSMain->createtranslation()
ENHANCEMENT Added AllChildrenIncludingDeleted(), augmentNumChildrenCountQuery(),  augmentAllChildrenIncludingDeleted(), augmentStageChildren() to Translatable class to allow for more stable tree generation.
ENHANCEMENT Moved definition of Translatable schema from augmentDatabase() to Translatable->extraStatics()
ENHANCEMENT Changes to the CMS language selection refresh the whole admin interface instead of the tree only. This way we can add a URL parameter ?lang=<lang> to /admin, which makes the specific language bookmarkable and reloadable. Changes to LangSelector.js
ENHANCEMENT Added fallback to ModelAsController->getNestedController() to fetch page with matching URLSegment but different language in case no page is found in the current language.
ENHANCEMENT Added helper methods to Translatable: getTranslation(), hasTranslation(), isTranslation(), findOriginalIDs()
ENHANCEMENT Getters and setters for Translatable->getOriginalPage() etc.
ENHANCEMENT Hooking Translatable into ModelAsController and ContentController initialization in order to call choose_site_lang()
ENHANCEMENT Simplified Translatable->augmentSQL(), augmentWrite() by not using auxilliary tables
ENHANCEMENT Showing clickable links for Translations in Translatable->updateCMSFields()
BUGFIX Modifying Hierarchy/SiteTree Children getters to accept optional "context" which can be used to set a language explicitly through the $Lang property, rather than implicitly reyling on the static Translatable::current_lang()
BUGFIX Fixed TranslatableTest to work with new datamodel
BUGFIX Temporarily disabled cookie/session selection in Translatable::choose_site_lang() until we have a good test suite for the side effects.
MINOR Added "untranslated" CSS styles to tree nodes and marking them as inactive/grey


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@69959 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-10 12:15:30 +00:00
Ingo Schommer
300435fb13 MINOR Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@69958 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-10 11:36:30 +00:00
Ingo Schommer
7e09cc8a18 MINOR merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@69858 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-07 23:01:47 +00:00
Ingo Schommer
266acd409d ENHANCEMENT Moved batch forms in CMSMain and AssetAdmin from hardcoded templates to SilverStripe forms. Enhances styling capabilities, unifies HTML syntax, better support for unobtrusive scripting, validation and field additions.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@69744 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-06 02:18:33 +00:00
Ingo Schommer
7b3068ac4f MINOR Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@69703 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-05 06:17:59 +00:00
Ingo Schommer
a495e561d3 ENHANCEMENT Removed object state setting in CMSMain/SiteTree publication process: DeletedFromStage, CheckedPublicationDifferences, IsAddedToStage and added getters for them. Improves testability as we don't have to rely on random methods like MenuTitle() being called to set object state.
ENHANCEMENT Flushing cache in SiteTree->onAfterWrite() and SiteTree->onAfterDelete() to ensure the publication state is up to date


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@69410 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-12-17 22:41:07 +00:00
Ingo Schommer
3c8e45f65a MINOR merged branches/2.3 into trunk
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@67466 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-12-04 22:38:58 +00:00
Sam Minnee
e79dd5558b Updating queries to be more DB agnostic
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@66506 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-24 09:30:41 +00:00
Sam Minnee
f067bd1304 Adding double-quotes to table and field references
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@66417 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-23 22:58:18 +00:00
Sam Minnee
a93a0c3c95 Updated SQL queries to be ansi compatable
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@66402 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-23 00:31:13 +00:00
Sam Minnee
2ee0c0991b Merged branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@66109 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-18 01:48:50 +00:00
Josh Kosmala
987edc9522 Minor php notice fix
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65916 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-14 02:23:26 +00:00