Commit Graph

2974 Commits

Author SHA1 Message Date
Steve Boyd
e63774061d FIX Call parent::contruct() 2022-10-18 16:35:11 +13:00
Steve Boyd
55b17c920c API Update deprecations 2022-10-18 15:23:59 +13:00
Steve Boyd
ea92339d8d ENH Update deprecation messages 2022-10-18 15:17:19 +13:00
Guy Sartorelli
9b64c7de24
Merge branch '4' into 5 2022-10-13 11:18:14 +13:00
Guy Sartorelli
6ff98c4201
ENH Records can be made previewable via an extension 2022-10-06 15:51:30 +13:00
Guy Sartorelli
d7857ebbe0
API Migrate SilverStripeNagivator classes
These classes are useful with `silverstripe/admin` and
`silverstripe/versioned` without needing `silverstripe/cms`.
2022-10-05 14:24:11 +13:00
Steve Boyd
d162fab123
[CVE-2022-37421] Sanitise ExtraMeta field for XSS 2022-10-03 12:55:04 +13:00
Guy Sartorelli
1f360c9c26
ENH Use the new CMSEditLinkExtension on SiteTree (#2778) 2022-09-30 15:10:49 +13:00
Guy Sartorelli
d56682509c
Merge branch '4' into 5 2022-09-02 11:01:22 +12:00
Guy Sartorelli
2b8bee7970
ENH Don't use deprecated method doRevertTo() (#2775) 2022-09-02 10:56:28 +12:00
Steve Boyd
aa4ba82f38
Merge pull request #2769 from creative-commoners/pulls/5/rescue-master-remove-history-viewer
API Rescue Master Branch PR: Remove deprecated CMSPageHistoryViewer
2022-09-01 14:50:58 +12:00
Florian Thoma
1711c0c88e
API Move updateRelativeLink hook after concatination (#2770)
* move updateRelativeLink hook after concatination to make it actually updatable

* keep existing parameters the same

* revert to link parameter be first

* update updateRelativeLink method signature in SiteTreeExtension

* don't pass old parameters by reference
2022-08-31 12:33:05 +12:00
Aaron Carlino
cda7857e12
API: Remove deprecated CMSPageHistoryViewer 2022-08-25 16:18:01 +12:00
Mike Cochrane
b46876b8a8
FIX Don't offer to restore to root if can_be_root is false 2022-08-25 14:18:50 +12:00
Benjamin
aca0defe16 BatchActionsExtension - Added blank end line 2022-07-07 12:46:22 -06:00
Benjamin Blake
fa1c6ae3db Created a batch action extension for LeftAndMain
+ Created an extension to add the `BatchActionParameters` fields from CMSMain to the `BatchActionsForm` in LeftAndMain
+ Applied the extension to LeftAndMain using YAML
2022-07-06 22:49:24 -06:00
Benjamin Blake
35d12228d0 CMSMain - Added HTML class attribute for styling
+ Added an `action-parameters` class to the BatchActionParameters field so we can style it without using ID selectors
2022-07-06 22:45:50 -06:00
Michal Kleiner
6bd3618f09
Fix CS 2022-07-07 10:32:19 +12:00
Benjamin Blake
654fa5a681 CMSMain - Linting changes + Added Docblock
+ Made the linting changes requested by @GuySartorelli
+ Added method documentation for BatchActionParameters()
2022-07-05 20:11:20 -06:00
Benjamin Blake
81593057de CMSMain - Fixed and enhanced BatchActionParameters
+ Fixed the $batchActions variable by making it use the `registeredActions()` method
+ Made the loop use `FieldHolder` instead of `Field` so CMS fields display correctly
+ Added hidden styles to the batch action div for jQuery show/hide functionality (found in Admin module PR)
2022-07-04 22:14:53 -06:00
Guy Sartorelli
83104da329 FIX Ensure unstaged versioned objects can be previewed. 2022-05-11 13:58:47 +12:00
Guy Sartorelli
c02549cf30 FIX Allow empty PreviewURLs for CMSPreviewable objects
An empty PreviewURL will result in the "no preview available" message
displaying instead of a 404 error.
2022-05-06 14:37:35 +12:00
Steve Boyd
1563ab3fcf Merge branch '4.10' into 4 2022-04-26 15:22:21 +12:00
Guy Sartorelli
bb158e4f2e
Merge pull request #2730 from creative-commoners/pulls/4/php81
ENH PHP 8.1 compatibility
2022-04-22 16:18:11 +12:00
Guy Sartorelli
4e757759ec FIX Translate pagetype names in list view 2022-04-19 16:04:20 +12:00
Guy Sartorelli
5840285d43
Merge pull request #2488 from andrewandante/FEAT/ground_control_to_pager_tom
FEATURE add config var for namespace mapping page->control
2022-04-14 16:02:20 +12:00
Steve Boyd
1b0b2154b4 ENH PHP 8.1 compatibility 2022-04-13 17:07:59 +12:00
Guy Sartorelli
13c1ae487f
Merge pull request #2731 from creative-commoners/pulls/4/p81fix
ENH Various fixes for PHP 8.1 compatibility
2022-04-13 16:10:56 +12:00
Andrew Aitken-Fincham
863ed24920 add config var for namespace mapping page->control, add test to confirm 2022-04-13 12:05:13 +12:00
Will Rossiter
ee69d75904
NEW add ability to redirect to a file on the website 2022-04-12 12:42:58 +12:00
Steve Boyd
6bea5778d7 ENH Various fixes for PHP 8.1 compatibility 2022-04-08 12:38:38 +12:00
Steve Boyd
cc43326de6 Merge branch '4.10' into 4 2022-04-06 10:33:36 +12:00
3Dgoo
ceeed65465
Ensure start var is not a negative number 2022-03-29 10:06:46 +01:00
Steve Boyd
3b62336180
NEW Include version number in meta generator tag (#2721) 2022-03-09 14:48:02 +13:00
Guy Sartorelli
b4e3a08b8a ENH Prefer dependency injection for GridFieldComponents
GridFieldComponents packaged with silverstripe/framework are injectable as of 4.11.0
Explicitly invoking the injector here instead of using `create()` allows backwards compatability with framework < 4.11.0 while ensuring dependency injection is still used from 4.11.0 onwards.
2022-02-12 18:48:17 +13:00
Steve Boyd
6ab92e8f74 Merge branch '4.10' into 4 2022-02-01 13:58:32 +13:00
Steve Boyd
101b17f16e Merge branch '4.9' into 4.10 2022-02-01 13:58:00 +13:00
GuySartorelli
803f19b3a4
NEW Add preview state for non-versioned DataObjects. (#2692)
Currently only Versioned DataObjects are enabled for the CMS preview.
Without a navigator item, non-versioned DataObjects aren't allowed to
display in the preview panel even if they implement CMSPreviewable.
2022-01-31 14:28:02 +13:00
Steve Boyd
ab22108c85 Merge branch '4.10' into 4 2022-01-27 09:43:54 +13:00
Florian Thoma
b539924550 FIX SiteTree visibility field name 2022-01-25 11:49:11 +11:00
Sergey Shevchenko
0db24fc038
FIX SiteTree::getCMSActions unpublish action (#2703)
* TEST SiteTree::getCMSAction produces valid actions

* FIX Fix invalid SiteTree unpublish action declaration

* refactor: moved new functions to conform with existing naming conventions

see https://github.com/silverstripe/silverstripe-cms/pull/2703#discussion_r789208512
2022-01-21 13:27:02 +13:00
Nicolaas / Sunn Side Up
1338538cb9
ENH: better coding standards (#2710) 2022-01-17 12:29:25 +13:00
Steve Boyd
96fdf6dc72 Merge branch '4.9' into 4 2021-11-18 17:07:02 +13:00
Steve Boyd
c754486693
Merge pull request #2685 from GuySartorelli/patch-1
FIX: Treat absolute links in a consistent manner in get_by_link.
2021-11-15 15:10:58 +13:00
Florian Thoma
480baa6ef8
FIX Use correct canonical tag on VirtualPage (#2688) 2021-11-04 14:59:14 +13:00
kevin-hine-innis
bcbeb6d626
FIX SiteTreeLinkTracking_Parser should use the getAnchorsOnPage (#2697)
Currently, the SiteTreeLinkTracking_Parser only checks the page's content for anchors.
As a result, any anchors that have been added or modified by the updateAnchorsOnPage extension in the getAnchorsOnPage method are marked ss-broken.

This change updates SiteTreeLinkTracking_Parser to get the anchors from the getAnchorsOnPage function on SiteTree. This will allow for more consistent RegEx matching and allow the updateAnchorsOnPage extension to be used when checking for broken links.
2021-11-04 09:31:34 +13:00
Adrian Humphreys
ecd9759f83
FIX Remove unused code (#2693) 2021-10-19 12:30:00 +13:00
kevin-hine-innis
2bf691f548
FIX ensure updateAnchorsOnPage extension is called (#2686)
Currently, if there are no anchors found in the page content, the updateAnchorsOnPage extension is not called.
This change will call the updateAnchorsOnPage extension regardless of the page content.
2021-09-28 12:36:37 -07:00
GuySartorelli
734eb3921f
FIX: Treat absolute links in a consistent manner in get_by_link.
Fixes #2580 

The call to `Director::makeRelative` transforms absolute links into relative links. Previously, this meant that you could pass in "https://example.co.nz/about-us" or "about-us" and get the same result, but passing in "https://example.co.nz/" and "/"  would give _different_ results.
This commit performs the transformation to a relative link _before_ checking if the path should be for the home page, which leads to more consistent results.
2021-09-21 17:09:48 +12:00
Aaron Carlino
f3a76ccf2d
NEW: getByLink plugin allows arrays of links (#2666)
* NEW: getByLink plugin allows arrays of links

* Allow configurable resolver

* Remove unused exception tag

* Refactor to preserve API backward compat

* Unit test

* Add plugin to readOne

* Fix test

* add new test
2021-09-07 09:34:52 +12:00
Nicolaas
10e2c1f271
PATCH: docblock for return value fixed for get_by_link 2021-07-17 11:39:18 +12:00
Steve Boyd
ac35e94a19 Merge branch '4.7' into 4.8 2021-05-28 13:31:35 +12:00
Nic Horstmeier
85c3b1096b
UPDATE generate canonical via MetaComponents
This replaces using the `MetaTags` method as replacing or removing a canonical requires string manipulation vs unsetting an array key, and is preferred.
2021-04-05 19:52:35 -05:00
Steve Boyd
f892205b9b
Merge pull request #2638 from wilr/pulls/undefined
FIX undefined variable inChangeSets
2021-03-22 14:13:07 +13:00
Will Rossiter
db7efad6ca
FIX undefined variable inChangeSets 2021-03-05 14:48:08 +13:00
Steve Boyd
7886e51f81 Merge branch '4.7' into 4 2021-01-02 10:48:03 +13:00
Steve Boyd
babc8a462e Merge branch '4.6' into 4.7 2021-01-02 10:40:57 +13:00
Steve Boyd
3bbc4aa6b3 Merge branch '4.5' into 4.6 2021-01-02 10:17:51 +13:00
Aaron Carlino
e415d41856 BUGFIX: Restore, refactor getByLink plugin 2020-12-08 11:16:52 +13:00
Aaron Carlino
7b960c1537
NEW: Compliance with new SchemaConfig API (#2617) 2020-12-01 21:27:16 +13:00
Andre Kiste
e67012d571
Merge pull request #2562 from kinglozzer/2561-virtualpage-savetreenode
FIX: Incorrect method call in savetreenode (fixes #2561)
2020-11-19 10:12:28 +13:00
Aaron Carlino
ee3e51e5e5 Move graphql legacy code to _legacy for PSR-4 compat 2020-11-13 21:02:08 +13:00
Aaron Carlino
5ab1ff3e69
NEW: GraphQL Compatibility (#2607)
* Add GraphQL4 compatibility

* Add getPageByLink

* Blacklist sitetree fields

* Remove getByLink from default schema. use linkable plugin

* getByLink compatability with new readOne filter anything

* Remove return type

* Compliance with new modelConfig

* Prep for travis

* Improvements for versioned-admin compat

* BC class guards

* New graphql 3 compat

* Fix travis syntax error

* New backward graphqlphp dependency

* Lint, build

* New phpcs exclusion

* Tidy up travis

* Fix rollback mutation

* Update code/GraphQL/_legacy/ReadOneResolver.php

Co-authored-by: Ingo Schommer <ingo@silverstripe.com>

* Address ingo feedback

* Deprecated GraphQL v3 classes

* Remove deleted branches

Co-authored-by: Ingo Schommer <ingo@silverstripe.com>
Co-authored-by: Ingo Schommer <me@chillu.com>
2020-11-13 13:50:44 +13:00
Steve Boyd
4e10bcfc51 ENH Disable option to create top-level pages based on permissions 2020-10-22 21:21:15 +13:00
Maxime Rainville
fd2184e7d1 Merge branch '4.6' into 4 2020-10-22 13:33:16 +13:00
Maxime Rainville
f9c26cefa3 BUG Fix parsing error on CMSSiteTreeFilter 2020-10-22 11:52:02 +13:00
Maxime Rainville
f4edd35989 Merge branch '4.5' into 4.6 2020-10-22 10:50:44 +13:00
brynwhyman
73460f9ee0 FIX remove old syntax from meta tag label 2020-10-13 09:38:03 +13:00
Mojmir Fendek
0fcda80f02 BUG: URL segment filter correction for CMS page search. 2020-10-06 08:37:22 +13:00
Guy Marriott
a8e8ed71c5
Merge pull request #2588 from creative-commoners/add-docs
Add docs to $enforce_strict_hierarchy
2020-10-04 17:20:42 -07:00
Robbie Averill
d17f058622 ENH Replace E_USER_ERROR errors with exceptions 2020-09-24 17:06:31 -07:00
bergice
3bf25681be Add docs to $enforce_strict_hierarchy 2020-09-24 19:27:52 +12:00
Maxime Rainville
edbe5ad069 BUG Remove old boostrap 3 CSS class 2020-09-16 11:06:36 +12:00
Steve Boyd
72e406aa63 Merge branch '4.6' into 4 2020-09-08 14:28:09 +12:00
Steve Boyd
9739308601 Merge branch '4.5' into 4.6 2020-09-08 14:27:46 +12:00
Mojmir Fendek
39b8d14634 BUG: Unpublish permission decoupled from publish permission. 2020-08-31 12:48:43 +12:00
Steve Boyd
c5a96a2a87 FIX Flush embed shortcode provider cache on SiteTree write 2020-08-26 10:13:39 +12:00
Maxime Rainville
31fa262475 BUG Honour URL suffix on URL Segment field 2020-08-06 14:23:58 +12:00
Nicolaas
b799262976
PATCH: better english 2020-07-08 10:16:19 +12:00
Loz Calver
69825da30a FIX: Incorrect method call in savetreenode (fixes #2561) 2020-06-24 17:23:10 +01:00
Lukas Erni
926571a2bf https://github.com/silverstripe/silverstripe-cms/issues/2557 - remove FQN if lang != EN on SiteType dropdown in page-settings 2020-06-17 16:28:23 +02:00
Maxime Rainville
9974c6e206 Merge branch '4.5' into 4 2020-05-26 14:27:33 +12:00
Klemen Dolinšek
c92e3b9d79 BUG Prioritise same-level pages in OldPageRedirector
Added option to pass integer ParentID=0 to OldPageRedirector::find_old_page to ensure search through nested pages from the root of SiteTree structure. Added new call of function and still offering fallback to old behaviour if first call returns false (fixed #2522)
2020-05-04 09:11:19 +02:00
Garion Herman
891f068202 FIX Correct placement of 'Page location' field title 2020-05-01 15:45:08 +12:00
Nicolaas
22694c7474
PATCH: fixing properties in comments 2020-05-01 11:01:51 +12:00
Michal Kleiner
d8331c1e0a Use short array syntax across the module's codebase 2020-04-19 16:18:01 +12:00
Mojmir Fendek
d7c76bdbba BUG: Published pages filter correction (missing default filter) 2020-04-15 13:31:02 +12:00
mattclegg
58795a2324
REFACTOR: Remove duplication and set SiteTree instances to use generic CMSEditLink() 2020-04-10 09:12:39 +05:45
mattclegg
d85cc24aa0
DOCS: Set @var to SiteTree where appropriate 2020-04-10 09:11:00 +05:45
Robbie Averill
e81659344c
Merge pull request #2536 from mattclegg/1585990198
ENHANCEMENT: Remove unused $controller from lambda function
2020-04-05 19:16:44 -07:00
mattclegg
2bbc280ce6
ENHANCEMENT: Remove unused $controller from lambda function 2020-04-04 16:20:24 +05:45
Klemen Dolinšek
ed41f15799 BUG Prioritise same-level pages in OldPageRedirector
Added option to pass integer ParentID=0 to OldPageRedirector::find_old_page to ensure search through nested pages from the root of SiteTree structure. Added new call of function and still offering fallback to old behaviour if first call returns false (fixed #2522)
2020-02-11 22:30:42 +01:00
Will Rossiter
6ee17a83e3
NEW Add extension hook updateRedirectionLink() 2020-01-24 22:13:03 +13:00
Amol Wankhede
de96188c8a FIX: If no parent in RelativeLink() return null 2019-12-04 17:08:49 +13:00
Guy Marriott
3a028ac1ec
Negotiator amends: Make it possible to disable Preview links in… (#2492)
Negotiator amends: Make it possible to disable Preview links in the CMS
2019-11-28 09:18:32 -08:00
Adrian Humphreys
7045082a06 BUG Cache page icons (#2493) 2019-11-13 10:21:52 +13:00
Lee Bradley
c8ccd6a8c4 Amends made requested during Pull Request
Requested by @andrewandante & @ScopeyNZ
2019-10-30 09:02:18 +00:00
Lee Bradley
31f99445bd Negotiator amends: Make it possible to disable Preview links in the CMS
Existing functionality is limited to `RedirectorPage`

Another option would be to use the HiddenClass methodology
2019-10-29 17:43:17 +00:00
Serge Latyntcev
c1159c849f Merge branch '4.4' into 4 2019-10-18 13:20:01 +13:00
Serge Latyntcev
06c481bb8d Merge branch '4.3' into 4.4 2019-09-24 14:55:57 +12:00