Commit Graph

2919 Commits

Author SHA1 Message Date
Guy Sartorelli 55eabd6694
FIX Don't require jquery on the frontend (#2854) 2023-05-08 12:53:10 +12:00
Dylan Wagstaff e20036482b FIX undefined index error in CMS
With the CMS 4.12 update functionality was altered to utilise an
Extension to obtain the CMS Edit link for a page, rather than having
SiteTree do it internally. Unfortunately the default return case for
`extend` (see Extensible) is an _empty_ array. This leave code
potentially referencing an array offset that doesn't exist ([0]). PHP 8
is less forgiving that it's predecessors on this kind of behaviour. We
should check that the responses from extensions exist before trying to
reference them.
2023-03-28 18:58:55 +13:00
Steve Boyd 4c3bd3713d Merge branch '4.11' into 4.12-release 2022-11-21 13:53:57 +13:00
Steve Boyd e63774061d FIX Call parent::contruct() 2022-10-18 16:35:11 +13:00
Steve Boyd 55b17c920c API Update deprecations 2022-10-18 15:23:59 +13:00
Steve Boyd ea92339d8d ENH Update deprecation messages 2022-10-18 15:17:19 +13:00
Steve Boyd d162fab123
[CVE-2022-37421] Sanitise ExtraMeta field for XSS 2022-10-03 12:55:04 +13:00
Guy Sartorelli 1f360c9c26
ENH Use the new CMSEditLinkExtension on SiteTree (#2778) 2022-09-30 15:10:49 +13:00
Guy Sartorelli 2b8bee7970
ENH Don't use deprecated method doRevertTo() (#2775) 2022-09-02 10:56:28 +12:00
Benjamin aca0defe16 BatchActionsExtension - Added blank end line 2022-07-07 12:46:22 -06:00
Benjamin Blake fa1c6ae3db Created a batch action extension for LeftAndMain
+ Created an extension to add the `BatchActionParameters` fields from CMSMain to the `BatchActionsForm` in LeftAndMain
+ Applied the extension to LeftAndMain using YAML
2022-07-06 22:49:24 -06:00
Benjamin Blake 35d12228d0 CMSMain - Added HTML class attribute for styling
+ Added an `action-parameters` class to the BatchActionParameters field so we can style it without using ID selectors
2022-07-06 22:45:50 -06:00
Michal Kleiner 6bd3618f09
Fix CS 2022-07-07 10:32:19 +12:00
Benjamin Blake 654fa5a681 CMSMain - Linting changes + Added Docblock
+ Made the linting changes requested by @GuySartorelli
+ Added method documentation for BatchActionParameters()
2022-07-05 20:11:20 -06:00
Benjamin Blake 81593057de CMSMain - Fixed and enhanced BatchActionParameters
+ Fixed the $batchActions variable by making it use the `registeredActions()` method
+ Made the loop use `FieldHolder` instead of `Field` so CMS fields display correctly
+ Added hidden styles to the batch action div for jQuery show/hide functionality (found in Admin module PR)
2022-07-04 22:14:53 -06:00
Guy Sartorelli 83104da329 FIX Ensure unstaged versioned objects can be previewed. 2022-05-11 13:58:47 +12:00
Guy Sartorelli c02549cf30 FIX Allow empty PreviewURLs for CMSPreviewable objects
An empty PreviewURL will result in the "no preview available" message
displaying instead of a 404 error.
2022-05-06 14:37:35 +12:00
Steve Boyd 1563ab3fcf Merge branch '4.10' into 4 2022-04-26 15:22:21 +12:00
Guy Sartorelli bb158e4f2e
Merge pull request #2730 from creative-commoners/pulls/4/php81
ENH PHP 8.1 compatibility
2022-04-22 16:18:11 +12:00
Guy Sartorelli 4e757759ec FIX Translate pagetype names in list view 2022-04-19 16:04:20 +12:00
Guy Sartorelli 5840285d43
Merge pull request #2488 from andrewandante/FEAT/ground_control_to_pager_tom
FEATURE add config var for namespace mapping page->control
2022-04-14 16:02:20 +12:00
Steve Boyd 1b0b2154b4 ENH PHP 8.1 compatibility 2022-04-13 17:07:59 +12:00
Guy Sartorelli 13c1ae487f
Merge pull request #2731 from creative-commoners/pulls/4/p81fix
ENH Various fixes for PHP 8.1 compatibility
2022-04-13 16:10:56 +12:00
Andrew Aitken-Fincham 863ed24920 add config var for namespace mapping page->control, add test to confirm 2022-04-13 12:05:13 +12:00
Will Rossiter ee69d75904
NEW add ability to redirect to a file on the website 2022-04-12 12:42:58 +12:00
Steve Boyd 6bea5778d7 ENH Various fixes for PHP 8.1 compatibility 2022-04-08 12:38:38 +12:00
Steve Boyd cc43326de6 Merge branch '4.10' into 4 2022-04-06 10:33:36 +12:00
3Dgoo ceeed65465
Ensure start var is not a negative number 2022-03-29 10:06:46 +01:00
Steve Boyd 3b62336180
NEW Include version number in meta generator tag (#2721) 2022-03-09 14:48:02 +13:00
Guy Sartorelli b4e3a08b8a ENH Prefer dependency injection for GridFieldComponents
GridFieldComponents packaged with silverstripe/framework are injectable as of 4.11.0
Explicitly invoking the injector here instead of using `create()` allows backwards compatability with framework < 4.11.0 while ensuring dependency injection is still used from 4.11.0 onwards.
2022-02-12 18:48:17 +13:00
Steve Boyd 6ab92e8f74 Merge branch '4.10' into 4 2022-02-01 13:58:32 +13:00
Steve Boyd 101b17f16e Merge branch '4.9' into 4.10 2022-02-01 13:58:00 +13:00
GuySartorelli 803f19b3a4
NEW Add preview state for non-versioned DataObjects. (#2692)
Currently only Versioned DataObjects are enabled for the CMS preview.
Without a navigator item, non-versioned DataObjects aren't allowed to
display in the preview panel even if they implement CMSPreviewable.
2022-01-31 14:28:02 +13:00
Steve Boyd ab22108c85 Merge branch '4.10' into 4 2022-01-27 09:43:54 +13:00
Florian Thoma b539924550 FIX SiteTree visibility field name 2022-01-25 11:49:11 +11:00
Sergey Shevchenko 0db24fc038
FIX SiteTree::getCMSActions unpublish action (#2703)
* TEST SiteTree::getCMSAction produces valid actions

* FIX Fix invalid SiteTree unpublish action declaration

* refactor: moved new functions to conform with existing naming conventions

see https://github.com/silverstripe/silverstripe-cms/pull/2703#discussion_r789208512
2022-01-21 13:27:02 +13:00
Nicolaas / Sunn Side Up 1338538cb9
ENH: better coding standards (#2710) 2022-01-17 12:29:25 +13:00
Steve Boyd 96fdf6dc72 Merge branch '4.9' into 4 2021-11-18 17:07:02 +13:00
Steve Boyd c754486693
Merge pull request #2685 from GuySartorelli/patch-1
FIX: Treat absolute links in a consistent manner in get_by_link.
2021-11-15 15:10:58 +13:00
Florian Thoma 480baa6ef8
FIX Use correct canonical tag on VirtualPage (#2688) 2021-11-04 14:59:14 +13:00
kevin-hine-innis bcbeb6d626
FIX SiteTreeLinkTracking_Parser should use the getAnchorsOnPage (#2697)
Currently, the SiteTreeLinkTracking_Parser only checks the page's content for anchors.
As a result, any anchors that have been added or modified by the updateAnchorsOnPage extension in the getAnchorsOnPage method are marked ss-broken.

This change updates SiteTreeLinkTracking_Parser to get the anchors from the getAnchorsOnPage function on SiteTree. This will allow for more consistent RegEx matching and allow the updateAnchorsOnPage extension to be used when checking for broken links.
2021-11-04 09:31:34 +13:00
Adrian Humphreys ecd9759f83
FIX Remove unused code (#2693) 2021-10-19 12:30:00 +13:00
kevin-hine-innis 2bf691f548
FIX ensure updateAnchorsOnPage extension is called (#2686)
Currently, if there are no anchors found in the page content, the updateAnchorsOnPage extension is not called.
This change will call the updateAnchorsOnPage extension regardless of the page content.
2021-09-28 12:36:37 -07:00
GuySartorelli 734eb3921f
FIX: Treat absolute links in a consistent manner in get_by_link.
Fixes #2580 

The call to `Director::makeRelative` transforms absolute links into relative links. Previously, this meant that you could pass in "https://example.co.nz/about-us" or "about-us" and get the same result, but passing in "https://example.co.nz/" and "/"  would give _different_ results.
This commit performs the transformation to a relative link _before_ checking if the path should be for the home page, which leads to more consistent results.
2021-09-21 17:09:48 +12:00
Aaron Carlino f3a76ccf2d
NEW: getByLink plugin allows arrays of links (#2666)
* NEW: getByLink plugin allows arrays of links

* Allow configurable resolver

* Remove unused exception tag

* Refactor to preserve API backward compat

* Unit test

* Add plugin to readOne

* Fix test

* add new test
2021-09-07 09:34:52 +12:00
Nicolaas 10e2c1f271
PATCH: docblock for return value fixed for get_by_link 2021-07-17 11:39:18 +12:00
Steve Boyd ac35e94a19 Merge branch '4.7' into 4.8 2021-05-28 13:31:35 +12:00
Nic Horstmeier 85c3b1096b
UPDATE generate canonical via MetaComponents
This replaces using the `MetaTags` method as replacing or removing a canonical requires string manipulation vs unsetting an array key, and is preferred.
2021-04-05 19:52:35 -05:00
Steve Boyd f892205b9b
Merge pull request #2638 from wilr/pulls/undefined
FIX undefined variable inChangeSets
2021-03-22 14:13:07 +13:00
Will Rossiter db7efad6ca
FIX undefined variable inChangeSets 2021-03-05 14:48:08 +13:00