Commit Graph

41 Commits

Author SHA1 Message Date
Sean Harvey
8089e04879 BUGFIX #6291 Remove rollback action from CMSMain allowed_actions and rely on form action_rollback instead which is safer (from r115440)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@115919 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:30 +13:00
Ingo Schommer
d91759d958 API CHANGE Fixed various controllers to enforce CSRF protection through Form_SecurityToken on GET actions that are not routed through Form->httpSubmission(): AssetAdmin, CMSBatchActionHandler, CMSMain, CommentTableField, LeftAndMain, MemberTableField, PageComment, PageComment_Controller (from r113282)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@113318 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:29 +13:00
Sean Harvey
74d06a584d MINOR Added test for FilesystemPublisher::__construct() to ensure DataObject::defineMethods() doesn't break, even when FilesystemPublisher is disabled
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@83582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:26 +13:00
Sean Harvey
66eb9d190f Reverted r77384
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@77386 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:23 +13:00
Sean Harvey
60ff36ea47 MINOR Removed cases where GhostPage was being unset from the tests
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@77384 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:23 +13:00
Sean Harvey
88600e41ec MINOR Fixed faulty test case CMSMainTest->testPublish() to make use of $this->session() instead of creating a new one
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@76887 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:21 +13:00
Ingo Schommer
292ccddad8 MINOR Merged from trunk
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@76879 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:21 +13:00
Sam Minnee
dad1e68bcf MINOR: Fixed tests
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@76749 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:20 +13:00
Sam Minnee
b2aa86140a API CHANGE: Made ModelAdmin's configuration statics public rather than protected, so that they can be accessed with Object::get_static()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@76124 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:19 +13:00
Sam Minnee
5f8839b6d8 MINOR: Added additional tests for LeftAndMain and ModelAdmin
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@76112 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:19 +13:00
Sam Minnee
d33c2869a7 BUGFIX: Let CMS users open pages deleted from draft; bug introduced by translatable.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@75611 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:15 +13:00
Ingo Schommer
74fad6a1d0 Merging refactored Translatable from trunk, and related changes to CMSMain
------------------------------------------------------------------------
r69959 | ischommer | 2009-01-11 01:15:30 +1300 (Sun, 11 Jan 2009) | 18 lines

Merged, debugged and enhanced Translatable patches from branches/translatable at r64523, r64523, 64523, thanks wakeless!
API CHANGE Changed Translatable schema from auxilliary tables (SiteTree_lang, SiteTree_lang_Live) to automatically filtered records on the original table (SiteTree, SiteTree_Live), using $Lang and $OriginalID properties. Incompatible update to old schema, migration script is in the works.
API CHANGE Removed Translatable::get_one(), Translatable::write()
ENHANCEMENT Simplified Translatable tree generation by using getSiteTreeFor() in CMSMain->createtranslation()
ENHANCEMENT Added AllChildrenIncludingDeleted(), augmentNumChildrenCountQuery(),  augmentAllChildrenIncludingDeleted(), augmentStageChildren() to Translatable class to allow for more stable tree generation.
ENHANCEMENT Moved definition of Translatable schema from augmentDatabase() to Translatable->extraStatics()
ENHANCEMENT Changes to the CMS language selection refresh the whole admin interface instead of the tree only. This way we can add a URL parameter ?lang=<lang> to /admin, which makes the specific language bookmarkable and reloadable. Changes to LangSelector.js
ENHANCEMENT Added fallback to ModelAsController->getNestedController() to fetch page with matching URLSegment but different language in case no page is found in the current language.
ENHANCEMENT Added helper methods to Translatable: getTranslation(), hasTranslation(), isTranslation(), findOriginalIDs()
ENHANCEMENT Getters and setters for Translatable->getOriginalPage() etc.
ENHANCEMENT Hooking Translatable into ModelAsController and ContentController initialization in order to call choose_site_lang()
ENHANCEMENT Simplified Translatable->augmentSQL(), augmentWrite() by not using auxilliary tables
ENHANCEMENT Showing clickable links for Translations in Translatable->updateCMSFields()
BUGFIX Modifying Hierarchy/SiteTree Children getters to accept optional "context" which can be used to set a language explicitly through the $Lang property, rather than implicitly reyling on the static Translatable::current_lang()
BUGFIX Fixed TranslatableTest to work with new datamodel
BUGFIX Temporarily disabled cookie/session selection in Translatable::choose_site_lang() until we have a good test suite for the side effects.
MINOR Added "untranslated" CSS styles to tree nodes and marking them as inactive/grey

------------------------------------------------------------------------
r70307 | ischommer | 2009-01-16 17:16:19 +1300 (Fri, 16 Jan 2009) | 2 lines

ENHANCEMENT Simplifying creation logic of new languages in CMS by reloading complete interface, rather than refreshing partial interface, language dropdown etc.
API CHANGE Removed CMSMain->switchlanguage()
------------------------------------------------------------------------
r70308 | ischommer | 2009-01-16 17:17:37 +1300 (Fri, 16 Jan 2009) | 2 lines

ENHANCEMENT Moved language selector in CMS above tree for better visibility, added padding and adjusted dropdown width
ENHANCEMENT Removed "Translating mode" status message above edit form - should be clear by the language dropdown above the CMS tree now
------------------------------------------------------------------------
r70322 | ischommer | 2009-01-19 13:09:55 +1300 (Mon, 19 Jan 2009) | 1 line

BUGFIX Ensuring that new pages can't be created when in translation mode by disabling the "create..." tree action
------------------------------------------------------------------------
r70323 | ischommer | 2009-01-19 13:11:08 +1300 (Mon, 19 Jan 2009) | 1 line

BUGFIX Fixed expanded/unexpanded flags on new tree items - was showing expanded styling (plus icon) with newly created pages
------------------------------------------------------------------------
r70324 | ischommer | 2009-01-19 13:26:02 +1300 (Mon, 19 Jan 2009) | 1 line

BUGFIX Making sure that LeftAndMain->CurrentPage() respects language settings - was returning pages in different language from session after switching between languages in cms
------------------------------------------------------------------------
r71297 | sharvey | 2009-02-03 18:12:42 +1300 (Tue, 03 Feb 2009) | 1 line

BUGFIX Only show the LangSelector dropdown if there's multiple languages available on the site
------------------------------------------------------------------------
r73343 | ischommer | 2009-03-19 06:14:02 +1300 (Thu, 19 Mar 2009) | 1 line

BUGFIX Changed CSS selector for TranslationTab javascript behaviour to be less specific
------------------------------------------------------------------------
r73344 | ischommer | 2009-03-19 06:14:59 +1300 (Thu, 19 Mar 2009) | 1 line

BUGFIX Checking for existence of original before trying to get translation in LeftAndMain->currentPage()
------------------------------------------------------------------------
r73345 | ischommer | 2009-03-19 06:18:52 +1300 (Thu, 19 Mar 2009) | 3 lines

ENHANCEMENT Showing all available languages in language selector above sitetree in CMS - you can now create new pages in completely new languages without any relation to an "original"
ENHANCEMENT Added CMSMain->IsTranslatableEnabled
API CHANGE Removed CMSMain->switchlanguage() - createTranslation() is sufficient for new, ajax refreshing of CMS state got way too complicated for switching languages, we now just reload the entire CMS with a different ?lang GET parameter
------------------------------------------------------------------------
r73469 | ischommer | 2009-03-20 21:49:27 +1300 (Fri, 20 Mar 2009) | 1 line

ENHANCEMENT Adjusted CMSMain and LeftAndMain to use locales instead of short lang codes when reading and writing translations. See r73468 for details on the underlying Translatable datamodel change
------------------------------------------------------------------------
r74071 | ischommer | 2009-04-04 10:24:59 +1300 (Sat, 04 Apr 2009) | 1 line

BUGFIX Fixed Form_EditForm_Locale reference in LeftAndMain_right.js (used to be Form_EditForm_Lang)
------------------------------------------------------------------------
r74072 | ischommer | 2009-04-04 10:26:51 +1300 (Sat, 04 Apr 2009) | 1 line

MINOR Using Translatable::choose_site_locale() instead of choose_site_lang() in LeftAndMain->init()
------------------------------------------------------------------------
r74951 | ischommer | 2009-04-22 16:23:56 +1200 (Wed, 22 Apr 2009) | 1 line

BUGFIX Fixed CMSMainTest->testThatGetCMSFieldsWorksOnEveryPageType() - was comparing a string $class with instanceof() instead of comparing the actually created instance
------------------------------------------------------------------------



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@74988 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:48:13 +13:00
Ingo Schommer
d9e9e5f348 ENHANCEMENT Using LeftAndMain->canView() in LeftAndMain->init() - if current admin interface can't be viewed, iterate over remaining interfaces until we find a valid one. This only includes admin interfaces with a valid controller, so it should fix the obnoxious redirect to userhelp.silverstripe.com when a website-user tries to access the CMS.
ENHANCEMENT Added LeftAndMain->canView() to check for logged-in member and CMS_ACCESS_* permissions in a testable way
ENHANCEMENT Don't show "Reports" admin section if no subclasses of SSReport are found (or none of the existing subclasses returns a valid canView())
ENHANCEMENT Added CMSMenu::get_viewable_menu_items() and using it in LeftAndMain->MainMenu()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@68460 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:47:46 +13:00
Ingo Schommer
b2bbb3945d MINOR formatting
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@67705 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:47:45 +13:00
Sam Minnee
767a2d8538 Merged pre-2.3-oct08 into 2.3 (via trunk)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@66356 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:47:39 +13:00
Sam Minnee
45c4d670b6 API CHANGE: Revamped CMSMenu system to not instantiate any objects, so that _config.php doesn't get fskd
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@66264 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 17:47:38 +13:00
Ingo Schommer
2cdf57053f FEATURE Added CMSMenu and CMSMenuItem and adjusted existing LeftAndMain subclasses to use new notation.See #2872 (thanks to hamish for the patch!)
API CHANGE Removed LeftAndMain::add_menu_item(), LeftAndMain::remove_menu_item(), LeftAndMain::replace_menu_item(), LeftAndMain::clear_menu()
MINOR Disabled LeftAndMainTest, now covered by CMSMenuTest

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65095 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-02 21:27:55 +00:00
Ingo Schommer
c6a8ad67fa BUGFIX Fixed SecurityAdminTest to work with i18n enabled
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65028 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-01 13:55:47 +00:00
Ingo Schommer
fa2a2df551 BUGFIX Fixed CMSMainTest to check for translated entities to avoid failing tests with i18n enabled
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65024 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-01 13:42:19 +00:00
Ingo Schommer
b4d519d2cb MINOR moved RestfulServerTest from cms to sapphire module, same as the actual RestfulServer class
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64442 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 17:37:44 +00:00
Ingo Schommer
c0a94a7c82 BUGFIX Unit tests for RestfulServer (see r64439)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64440 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 17:35:59 +00:00
Ingo Schommer
db25cf0d59 BUGFIX Unsetting $_SERVER globals in RestfulServerTest to avoid side-effects across unit tests
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64310 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 16:24:50 +00:00
Ingo Schommer
18843624bb BUGFIX Added RestfulServerTest->testApiAccessBoolean()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64309 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 16:19:37 +00:00
Ingo Schommer
b9f9e74306 FEATURE Allowing for field-level permissions in DataObject::$api_access - respecting those permissions for reading and writing in RestfulServer (#2918)
BUGFIX Fixed RestfulServerTest->testAuthenticatedGET()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64307 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 15:47:13 +00:00
Sam Minnee
1034826574 API CHANGE: Added initial CMS tests to the system. These will execute tests on the data model provided by a user's project code
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63827 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:38:32 +00:00
Hayden Smith
690cebdccd Merged from branches/nzct-trunk. Use 'svn log -c <changeset> -g' for full commit message. Merge includes stability fixes and minor refactor of TableListField and ComplexTableField.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63807 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:00:39 +00:00
Sam Minnee
155269c389 Added tests for security group export
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 02:26:23 +00:00
Sam Minnee
9222af6829 Windmill test - whacked up timeout on CMS load for slow build slave
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@61634 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 10:56:55 +00:00
Sam Minnee
10546a00b5 Fixed setup of windmill admin tests
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@61631 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 10:51:36 +00:00
Sam Minnee
221e7b574f Fixed glitch in test
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@61628 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 08:23:47 +00:00
Sam Minnee
dfa227cbe5 Updated windmill tests to use python syntax, as this will scale better
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@61626 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 08:18:54 +00:00
Ingo Schommer
d5b37fab3d ENHANCEMENT Added default /admin/cms route to cms/_config.php to clear default namespace for other controllers
BUGFIX Fixed CMSMainTest to use /admin/crm as a standard URL rather than /admin (which could be overloaded by other admins for application-like interfaces without CMS components)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@60635 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 07:54:34 +00:00
Sam Minnee
387b5edd21 Merged changes from branches/2.2.2-assets:
Static publishing
Ability to lock down comments to logged-in members only

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@60470 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 02:59:27 +00:00
Ingo Schommer
109f207e16 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@60338 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-11 03:13:53 +00:00
Ingo Schommer
e29feeecac (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@60235 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-09 07:03:24 +00:00
Ingo Schommer
a894ad377d MINOR Unified @package PHPdoc (added where missing, removed duplicates)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@56212 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-06-15 13:33:53 +00:00
Ingo Schommer
ea1b6cd66e moved LeftAndMain test from sapphire to cms
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@52183 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-04-06 03:38:27 +00:00
Sam Minnee
dc173c6d5c Updated windmill tests - sleeps and waits
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@48424 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-01-22 05:13:04 +00:00
Sam Minnee
35adb02921 Added Windmill test for editing content
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@48166 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-01-17 05:01:32 +00:00
Sam Minnee
99a0cb43b5 Fixed login test
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@48042 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-01-16 00:42:29 +00:00
Sam Minnee
5f5b69b130 Added initial windmill test
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@48035 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-01-15 22:30:55 +00:00