tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity

FIX ReportAdmin report links regression

Browse Source 
Regression from 79996a76fe,
escaped quotes are no longer necessary because the string
doesn't get eval'ed.
This commit is contained in:
Ingo Schommer 2013-10-01 11:17:36 +02:00
parent c2a34ff4a7
commit fb9d7a595b
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/controllers/ReportAdmin.php
View File

@ -166,7 +166,7 @@ class ReportAdmin extends LeftAndMain implements PermissionProvider {
$columns->setFieldFormatting(array( $columns->setFieldFormatting(array(
'title' => function($value, &$item) { 'title' => function($value, &$item) {
return sprintf( return sprintf(
'<a href=\"%s\" class=\"cms-panel-link\">%s</a>', '<a href="%s" class="cms-panel-link">%s</a>',
Convert::raw2xml($item->Link), Convert::raw2xml($item->Link),
Convert::raw2xml($value) Convert::raw2xml($value)
); );

15
tests/behat/features/view-reports.feature Normal file
View File

@ -0,0 +1,15 @@
Feature: View Reports
As an author
I want to review aggregate reports on pages
So that I can keep an overview on the health of my website data
Background:
Given a "page" "Empty Page"
And a "page" "Filled Page" with "Content"="Some Content"
And I am logged in with "ADMIN" permissions
And I go to "/admin/reports"
Scenario: I can view the "Pages with no content" report
When I follow "Pages with no content"
Then I should see "Empty Page"
But I should not see "Filled Page"