Merge pull request #2898 from creative-commoners/pulls/5.1/remove-todo

MNT Remove TODO comments

_config.php

@@ -32,7 +32,6 @@ ShortcodeParser::get('default')->register(
     [SiteTree::class, 'link_shortcode_handler']
 );
 
-// TODO Remove once we can configure CMSMenu through static, nested configuration files
 CMSMenu::remove_menu_class(CMSMain::class);
 CMSMenu::remove_menu_class(CMSPageEditController::class);
 CMSMenu::remove_menu_class(CMSPageSettingsController::class);

code/Controllers/CMSMain.php

@@ -80,8 +80,6 @@ use SilverStripe\View\Requirements;
  * This class creates a 2-frame layout - left-tree and right-form - to sit beneath the main
  * admin menu.
  *
- * @todo Create some base classes to contain the generic functionality that will be replicated.
- *
  * @mixin LeftAndMainPageIconsExtension
  */
 class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionProvider, Flushable, MemberCacheFlusher
@@ -702,7 +700,6 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr
             $markingSet->markUnexpanded($record);
 
             // Find the next & previous nodes, for proper positioning (Sort isn't good enough - it's not a raw offset)
-            // TODO: These methods should really be in hierarchy - for a start it assumes Sort exists
             $prev = null;
 
             $className = $this->config()->get('tree_class');
@@ -1372,7 +1369,6 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr
             }
         }
 
-        // TODO Can't merge $FormAttributes in template at the moment
         $form->addExtraClass('center ' . $this->BaseCSSClasses());
         // Set validation exemptions for specific actions
         $form->setValidationExemptActions([
@@ -1768,7 +1764,6 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr
             return Security::permissionFailure($this);
         }
 
-        // TODO Coupling to SiteTree
         $record->HasBrokenLink = 0;
         $record->HasBrokenFile = 0;
 

code/Controllers/CMSPageAddController.php

@@ -132,10 +132,6 @@ class CMSPageAddController extends CMSPageEditController
                 ]);
         });
 
-        // TODO Re-enable search once it allows for HTML title display,
-        // see http://open.silverstripe.org/ticket/7455
-        // $parentField->setShowSearch(true);
-
         $parentModeField->addExtraClass('parent-mode');
 
         // CMSMain->currentPageID() automatically sets the homepage,

code/Controllers/ContentController.php

@@ -45,7 +45,6 @@ use SilverStripe\View\SSViewer;
  * Subclasses of ContentController are generally instantiated by ModelAsController; this will create
  * a controller based on the URLSegment action variable, by looking in the SiteTree table.
  *
- * @todo Can this be used for anything other than SiteTree controllers?
  */
 class ContentController extends Controller
 {
@@ -303,8 +302,6 @@ class ContentController extends Controller
     /**
      * Returns the default log-in form.
      *
-     * @todo Check if here should be returned just the default log-in form or
-     *       all available log-in forms (also OpenID...)
      * @return \SilverStripe\Security\MemberAuthenticator\MemberLoginForm
      */
     public function LoginForm()
@@ -449,7 +446,6 @@ HTML;
             $this->httpError(410);
         }
 
-        // TODO Allow this to work when allow_url_fopen=0
         if (isset($_SESSION['StatsID']) && $_SESSION['StatsID']) {
             $url = 'http://ss2stat.silverstripe.com/Installation/installed?ID=' . $_SESSION['StatsID'];
             @file_get_contents($url ?? '');

code/Model/RedirectorPage.php

@@ -164,7 +164,6 @@ class RedirectorPage extends Page
                 $this->HasBrokenLink = true;
             }
         } else {
-            // TODO implement checking of a remote site
             $this->HasBrokenLink = false;
         }
     }

code/Model/SiteTree.php

@@ -1958,7 +1958,6 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
      */
     public function BackLinkTracking()
     {
-        // @todo - Implement PolymorphicManyManyList to replace this
         $list = ArrayList::create();
 
         $siteTreelinkTable = SiteTreeLink::singleton()->baseTable();

code/Reports/BrokenFilesReport.php

@@ -46,7 +46,7 @@ class BrokenFilesReport extends Report
     {
         return [
             "Title" => [
-                "title" => "Title", // todo: use NestedTitle(2)
+                "title" => "Title",
                 "link" => true,
             ],
         ];

code/Reports/BrokenRedirectorPagesReport.php

@@ -39,7 +39,7 @@ class BrokenRedirectorPagesReport extends Report
     {
         return [
             "Title" => [
-                "title" => "Title", // todo: use NestedTitle(2)
+                "title" => "Title",
                 "link" => true,
             ],
         ];

code/Reports/BrokenVirtualPagesReport.php

@@ -39,7 +39,7 @@ class BrokenVirtualPagesReport extends Report
     {
         return [
             "Title" => [
-                "title" => "Title", // todo: use NestedTitle(2)
+                "title" => "Title",
                 "link" => true,
             ],
         ];

code/Reports/EmptyPagesReport.php

@@ -43,7 +43,7 @@ class EmptyPagesReport extends Report
     {
         return [
             "Title" => [
-                "title" => "Title", // todo: use NestedTitle(2)
+                "title" => "Title",
                 "link" => true,
             ],
         ];

code/Reports/RecentlyEditedReport.php

@@ -38,7 +38,7 @@ class RecentlyEditedReport extends Report
     {
         return [
             "Title" => [
-                "title" => "Title", // todo: use NestedTitle(2)
+                "title" => "Title",
                 "link" => true,
             ],
         ];

tests/behat/features/preview-a-page.feature

@@ -19,10 +19,6 @@ Feature: Preview a page
     And the preview contains "About Us"
     Then I set the CMS mode to "Edit mode"
 
-  # TODO:
-  # - Only tests correctly on fresh database
-  # - We should continue testing against it after we have fixtures ready
-  @javascript
   Scenario: I can see an updated preview when editing content
     And I go to "/admin/pages"
     Then I should see "About Us" in the tree

tests/php/Model/SiteTreePermissionsTest.php

@@ -12,10 +12,6 @@ use SilverStripe\SiteConfig\SiteConfig;
 use SilverStripe\Subsites\Extensions\SiteTreeSubsites;
 use SilverStripe\Versioned\Versioned;
 
-/**
- * @todo Test canAddChildren()
- * @todo Test canCreate()
- */
 class SiteTreePermissionsTest extends FunctionalTest
 {
     protected static $fixture_file = "SiteTreePermissionsTest.yml";

tests/php/Search/ZZZSearchFormTest.php

@@ -21,9 +21,6 @@ use SilverStripe\Versioned\Versioned;
 use TractorCow\Fluent\Extension\FluentSiteTreeExtension;
 
 /**
- * @todo Fix unpublished pages check in testPublishedPagesMatchedByTitle()
- * @todo All tests run on unpublished pages at the moment, due to the searchform not distinguishing between them
- *
  * Because this manipulates the test database in severe ways, I've renamed the test to force it to run last...
  */
 class ZZZSearchFormTest extends FunctionalTest