From ee2b1a9070e4c49466b8a6c9f98bf7de23874934 Mon Sep 17 00:00:00 2001 From: Mateusz Uzdowski Date: Fri, 20 Jul 2012 14:04:52 +1200 Subject: [PATCH] BUG Check for the parameter existence. The specific situation is if the SearchForm.ss is overriden, and the $SearchQuery parameter is used in the template. This will throw a Notice in case the form is rendered without searching. --- code/search/SearchForm.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/code/search/SearchForm.php b/code/search/SearchForm.php index 1b91f28b..579ebbc9 100644 --- a/code/search/SearchForm.php +++ b/code/search/SearchForm.php @@ -172,7 +172,8 @@ class SearchForm extends Form { // legacy usage: $data was defaulting to $_REQUEST, parameter not passed in doc.silverstripe.org tutorials if(!isset($data)) $data = $_REQUEST; - return Convert::raw2xml($data['Search']); + // The form could be rendered without the search being done, so check for that. + if (isset($data['Search'])) return Convert::raw2xml($data['Search']); } /**