diff --git a/code/AssetAdmin.php b/code/AssetAdmin.php index f8b6789d..b8dbf4a6 100755 --- a/code/AssetAdmin.php +++ b/code/AssetAdmin.php @@ -313,9 +313,16 @@ HTML; if(!$record->canEdit()) { $form->makeReadonly(); } - - return $form; + } else { + $form = new Form( + $this, + "EditForm", + new FieldSet(), + new FieldSet() + ); } + + return $form; } /** diff --git a/code/CMSMain.php b/code/CMSMain.php index a5ac0852..4cede842 100755 --- a/code/CMSMain.php +++ b/code/CMSMain.php @@ -395,18 +395,21 @@ JS; $readonlyFields = $form->Fields()->makeReadonly(); $form->setFields($readonlyFields); } - - return $form; - } if ($id == 0) { + } elseif ($id == 0) { $siteConfig = SiteConfig::current_site_config(); $form = new Form($this, "EditForm", $siteConfig->getFormFields(), $siteConfig->getFormActions()); $form->loadDataFrom($siteConfig); return $form; - } else if($id) { - return new Form($this, "EditForm", new FieldSet( - new LabelField('PageDoesntExistLabel',_t('CMSMain.PAGENOTEXISTS',"This page doesn't exist"))), new FieldSet()); - + } else { + $form = new Form( + $this, + "EditForm", + new FieldSet(), + new FieldSet() + ); } + + return $form; } diff --git a/code/SecurityAdmin.php b/code/SecurityAdmin.php index 7db78469..42072e7e 100644 --- a/code/SecurityAdmin.php +++ b/code/SecurityAdmin.php @@ -55,21 +55,28 @@ class SecurityAdmin extends LeftAndMain implements PermissionProvider { $record = DataObject::get_by_id($this->stat('tree_class'), $id); } - if(!$record) return false; + if($record) { + $fields = $record->getCMSFields(); - $fields = $record->getCMSFields(); - - $actions = new FieldSet( - new FormAction('addmember',_t('SecurityAdmin.ADDMEMBER','Add Member')), - new FormAction('save',_t('SecurityAdmin.SAVE','Save')) - ); + $actions = new FieldSet( + new FormAction('addmember',_t('SecurityAdmin.ADDMEMBER','Add Member')), + new FormAction('save',_t('SecurityAdmin.SAVE','Save')) + ); - $form = new Form($this, "EditForm", $fields, $actions); - $form->loadDataFrom($record); + $form = new Form($this, "EditForm", $fields, $actions); + $form->loadDataFrom($record); - if(!$record->canEdit()) { - $readonlyFields = $form->Fields()->makeReadonly(); - $form->setFields($readonlyFields); + if(!$record->canEdit()) { + $readonlyFields = $form->Fields()->makeReadonly(); + $form->setFields($readonlyFields); + } + } else { + $form = new Form( + $this, + "EditForm", + new FieldSet(), + new FieldSet() + ); } return $form; diff --git a/templates/Includes/AssetAdmin_left.ss b/templates/Includes/AssetAdmin_left.ss index 0060f144..d614e5b4 100755 --- a/templates/Includes/AssetAdmin_left.ss +++ b/templates/Includes/AssetAdmin_left.ss @@ -1,30 +1,61 @@ -

<% _t('FOLDERS','Folders') %>

-
- -
-