tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity

FIX undefined index error in CMS

Browse Source 
With the CMS 4.12 update functionality was altered to utilise an
Extension to obtain the CMS Edit link for a page, rather than having
SiteTree do it internally. Unfortunately the default return case for
`extend` (see Extensible) is an _empty_ array. This leave code
potentially referencing an array offset that doesn't exist ([0]). PHP 8
is less forgiving that it's predecessors on this kind of behaviour. We
should check that the responses from extensions exist before trying to
reference them.
This commit is contained in:
Dylan Wagstaff 2023-03-28 16:34:11 +13:00
parent 9907209a07
commit e20036482b
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
code/Model/SiteTree.php
View File

@ -739,13 +739,15 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
/** /**
* Generates a link to edit this page in the CMS. * Generates a link to edit this page in the CMS.
* *
* Implemented here to satisfy the CMSPreviewable interface, but data is intended to be loaded via Extension
*
* @see SilverStripe\Admin\CMSEditLinkExtension
*
* @return string * @return string
*/ */
public function CMSEditLink() public function CMSEditLink()
{ {
// This method has to be implemented here to satisfy the CMSPreviewable interface. return $this->extend('CMSEditLink')[0] ?? '';
// See the actual implementation in CMSEditLinkExtension.
return $this->extend('CMSEditLink')[0];
} }
/** /**