From c9b67367e6364c59b1b644fe99024ed9d8fa777a Mon Sep 17 00:00:00 2001
From: Will Rossiter <will@silverstripe.com>
Date: Sun, 5 Apr 2009 03:20:30 +0000
Subject: [PATCH] MINOR: fixed minor isset() issues when no groups exist

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@74074 467b73ca-7a2a-4603-9d3b-597d59a354a9
---
 code/MemberTableField.php | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/code/MemberTableField.php b/code/MemberTableField.php
index 505dc53b..89f842ff 100755
--- a/code/MemberTableField.php
+++ b/code/MemberTableField.php
@@ -66,7 +66,7 @@ class MemberTableField extends ComplexTableField {
 			} elseif(is_numeric($group)) {
 				$this->group = DataObject::get_by_id('Group', $group);
 			}
-		} else if(is_numeric($_REQUEST['ctf'][$this->Name()]["ID"])) {
+		} else if(isset($_REQUEST['ctf']) && is_numeric($_REQUEST['ctf'][$this->Name()]["ID"])) {
 			$this->group = DataObject::get_by_id('Group', $_REQUEST['ctf'][$this->Name()]["ID"]);
 		}
 
@@ -132,7 +132,7 @@ class MemberTableField extends ComplexTableField {
 	}
 
 	function sourceID() {
-		return $this->group->ID;
+		return ($this->group) ? $this->group->ID : 0;
 	}
 
 	function AddLink() {
@@ -140,9 +140,11 @@ class MemberTableField extends ComplexTableField {
 	}
 
 	function SearchForm() {
+		$groupID = (isset($this->group)) ? $this->group->ID : 0;
+		
 		$searchFields = new FieldGroup(
 			new TextField('MemberSearch', _t('MemberTableField.SEARCH', 'Search')),
-			new HiddenField("ctf[ID]", '', $this->group->ID),
+			new HiddenField("ctf[ID]", '', $groupID),
 			new HiddenField('MemberFieldName', '', $this->name),
 			new HiddenField('MemberDontShowPassword', '', $this->hidePassword)
 		);
@@ -262,8 +264,9 @@ class MemberTableField extends ComplexTableField {
 				$fields->push(new TextField($fieldName));
 			}
 		}
-		$fields->push(new HiddenField('ctf[ID]', null, $this->group->ID));
-
+		if($this->group) {
+			$fields->push(new HiddenField('ctf[ID]', null, $this->group->ID));
+		}
 		$actions = new FieldSet(
 			new FormAction('addtogroup', _t('MemberTableField.ADD','Add'))
 		);
@@ -330,14 +333,16 @@ class MemberTableField extends ComplexTableField {
 				
 		// We use the group to get the members, as they already have the bulk of the look up functions
 		$start = isset($_REQUEST['ctf'][$this->Name()]['start']) ? $_REQUEST['ctf'][$this->Name()]['start'] : 0; 
-
-		$this->sourceItems = $this->group->Members( 
-			$this->pageSize, // limit 
-			$start, // offset 
-			$this->sourceFilter,
-			$this->sourceSort
-		);
 		
+		$this->sourceItems = false;
+		if($this->group) {
+			$this->sourceItems = $this->group->Members( 
+				$this->pageSize, // limit 
+				$start, // offset 
+				$this->sourceFilter,
+				$this->sourceSort
+			);	
+		}
 		// Because we are not used $this->upagedSourceItems any more, and the DataObjectSet is usually the source
 		// that a large member set runs out of memory. we disable it here.
 		//$this->unpagedSourceItems = $this->group->Members('', '', $this->sourceFilter, $this->sourceSort);