FIX Direct edit file by URL

Trying to navigate directly to the edit view of a file by URL would fail if a folder other than the file’s parent was held in session data. Removed reliance on current ID in session and added folder detection for edit view.

.travis.yml

@@ -12,7 +12,7 @@ addons:
 
 env:
   global:
-    - CORE_RELEASE=3
+    - CORE_RELEASE=3.4
     - "ARTIFACTS_AWS_REGION=us-east-1"
     - "ARTIFACTS_S3_BUCKET=silverstripe-travis-artifacts"
     - secure: "7V20Qk3bIG2AlTJaA5D/uzB8vUVvRwQp+xjRYUxlahtj9FcuqEV3HIyjwwJe0T6Z1bnRYuu28ZnCT2CfP9BBZ3FE7AwSZbPase9c0/at2qDJNqkvIdC1xZ1H6Fcy2LSwNB9wLQPe613ItVdanitEuwE41iowxBPslxUUTnwx7eY="

code/controllers/AssetAdmin.php

@@ -47,18 +47,28 @@ class AssetAdmin extends LeftAndMain implements PermissionProvider{
 	);
 
 	/**
-	 * Return fake-ID "root" if no ID is found (needed to upload files into the root-folder)
+	 * Return fake-ID 0 (root) if no ID is found (needed to upload files into the root-folder)
 	 */
 	public function currentPageID() {
-		if(is_numeric($this->getRequest()->requestVar('ID')))	{
+		$id = 0;
-			return $this->getRequest()->requestVar('ID');
+		$request = $this->getRequest();
-		} elseif (is_numeric($this->urlParams['ID'])) {
+		if(is_numeric($request->requestVar('ID')))	{
-			return $this->urlParams['ID'];
+			$id = $request->requestVar('ID');
-		} elseif(Session::get("{$this->class}.currentPage")) {
+		} elseif (is_numeric($request->param('ID'))) {
-			return Session::get("{$this->class}.currentPage");
+			$id = $request->param('ID');
-		} else {
-			return 0;
 		}
+
+		// Detect current folder in gridfield item edit view
+		if ($id && $id > 0) {
+			if (!Folder::get()->filter('ID', $id)->exists()) {
+				$file = File::get()->byID($id);
+				$id = ($file) ? $file->ParentID : 0;
+			}
+		}
+
+		$id = (int)$id;
+		$this->setCurrentPageID($id);
+		return $id;
 	}
 
 	/**
@@ -153,8 +163,9 @@ JS
 	}
 
 	public function getEditForm($id = null, $fields = null) {
+
 		$form = parent::getEditForm($id, $fields);
-		$folder = ($id && is_numeric($id)) ? DataObject::get_by_id('Folder', $id, false) : $this->currentPage();
+		$folder = $this->currentPage();
 		$fields = $form->Fields();
 		$title = ($folder && $folder->isInDB()) ? $folder->Title : _t('AssetAdmin.FILES', 'Files');
 		$fields->push(new HiddenField('ID', false, $folder ? $folder->ID : null));
@@ -338,8 +349,8 @@ JS
 		if($record && !$record->canDelete()) return Security::permissionFailure();
 		if(!$record || !$record->ID) throw new SS_HTTPResponse_Exception("Bad record ID #" . (int)$data['ID'], 404);
 		$parentID = $record->ParentID;
+		$this->setCurrentPageID($parentID);
 		$record->delete();
-		$this->setCurrentPageID(null);
 
 		$this->getResponse()->addHeader('X-Status', rawurlencode(_t('LeftAndMain.DELETED', 'Deleted.')));
 		$this->getResponse()->addHeader('X-Pjax', 'Content');
@@ -518,12 +529,13 @@ JS
 	 */
 	public function currentPage() {
 		$id = $this->currentPageID();
-		if($id && is_numeric($id) && $id > 0) {
+		if ($id > 0) {
-			$folder = DataObject::get_by_id('Folder', $id);
+			$folder = Folder::get()->byID($id);
 			if ($folder && $folder->isInDB()) {
 				return $folder;
 			}
 		}
+		// Fallback to root
 		$this->setCurrentPageID(null);
 		return new Folder();
 	}

code/controllers/CMSFileAddController.php

@@ -36,12 +36,11 @@ class CMSFileAddController extends LeftAndMain {
 	 * Return fake-ID "root" if no ID is found (needed to upload files into the root-folder)
 	 */
 	public function currentPageID() {
-		if(is_numeric($this->getRequest()->requestVar('ID')))	{
+		$request = $this->getRequest();
-			return $this->getRequest()->requestVar('ID');
+		if (is_numeric($request->requestVar('ID')))	{
-		} elseif (is_numeric($this->urlParams['ID'])) {
+			return $request->requestVar('ID');
-			return $this->urlParams['ID'];
+		} elseif (is_numeric($request->param('ID'))) {
-		} elseif(Session::get("{$this->class}.currentPage")) {
+			return $request->param('ID');
-			return Session::get("{$this->class}.currentPage");
 		} else {
 			return 0;
 		}
@@ -57,10 +56,6 @@ class CMSFileAddController extends LeftAndMain {
 		Requirements::javascript(FRAMEWORK_DIR . '/javascript/AssetUploadField.js');
 		Requirements::css(FRAMEWORK_DIR . '/css/AssetUploadField.css');
 
-		if($currentPageID = $this->currentPageID()){
-			Session::set("{$this->class}.currentPage", $currentPageID);	
-		}
-		
 		$folder = $this->currentPage();
 
 		$uploadField = UploadField::create('AssetUploadField', '');