tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-06-30 08:29:34 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1901 from robbieaverill/pulls/4.0/fix-active-tab-state-logic

Browse Source 
FIX Use better inheritance based logic for deciding which active tab to display in edit page
This commit is contained in:
Damian Mooyman 2017-07-18 16:55:01 +12:00 committed by GitHub
commit c8d22442af
4 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
code/Controllers/CMSMain.php
View File

@ -351,17 +351,13 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr
} }
/** /**
* Decide which is the active primary tab in a CMS edit screen * Return the active tab identifier for the CMS. Used by templates to decide which tab to give the active state.
* The default value is "edit", as the primary content tab. Child controllers will override this.
* *
* @return string * @return string
*/ */
public function getActiveTab() public function getTabIdentifier()
{ {
if ($this instanceof CMSPageSettingsController) {
return 'settings';
} elseif ($this instanceof CMSPageHistoryController) {
return 'history';
}
return 'edit'; return 'edit';
} }

5
code/Controllers/CMSPageHistoryController.php
View File

@ -464,4 +464,9 @@ class CMSPageHistoryController extends CMSMain
{ {
return $this->versionID; return $this->versionID;
} }
public function getTabIdentifier()
{
return 'history';
}
} }

5
code/Controllers/CMSPageSettingsController.php
View File

@ -26,4 +26,9 @@ class CMSPageSettingsController extends CMSMain
$crumbs[0]->Title = _t('SilverStripe\\CMS\\Controllers\\CMSPagesController.MENUTITLE', 'Pages'); $crumbs[0]->Title = _t('SilverStripe\\CMS\\Controllers\\CMSPagesController.MENUTITLE', 'Pages');
return $crumbs; return $crumbs;
} }
public function getTabIdentifier()
{
return 'settings';
}
} }

6
templates/SilverStripe/CMS/Controllers/Includes/CMSMain_Content.ss
View File

@ -10,17 +10,17 @@
<div class="cms-content-header-tabs cms-tabset"> <div class="cms-content-header-tabs cms-tabset">
<ul class="cms-tabset-nav-primary nav nav-tabs"> <ul class="cms-tabset-nav-primary nav nav-tabs">
<li class="nav-item content-treeview<% if $ActiveTab == 'edit' %> ui-tabs-active<% end_if %>"> <li class="nav-item content-treeview<% if $TabIdentifier == 'edit' %> ui-tabs-active<% end_if %>">
<a href="$LinkPageEdit" class="nav-link cms-panel-link" title="Form_EditForm" data-href="$LinkPageEdit"> <a href="$LinkPageEdit" class="nav-link cms-panel-link" title="Form_EditForm" data-href="$LinkPageEdit">
<% _t('SilverStripe\CMS\Controllers\CMSMain.TabContent', 'Content') %> <% _t('SilverStripe\CMS\Controllers\CMSMain.TabContent', 'Content') %>
</a> </a>
</li> </li>
<li class="nav-item content-listview<% if $ActiveTab == 'settings' %> ui-tabs-active<% end_if %>"> <li class="nav-item content-listview<% if $TabIdentifier == 'settings' %> ui-tabs-active<% end_if %>">
<a href="$LinkPageSettings" class="nav-link cms-panel-link" title="Form_EditForm" data-href="$LinkPageSettings"> <a href="$LinkPageSettings" class="nav-link cms-panel-link" title="Form_EditForm" data-href="$LinkPageSettings">
<% _t('SilverStripe\CMS\Controllers\CMSMain.TabSettings', 'Settings') %> <% _t('SilverStripe\CMS\Controllers\CMSMain.TabSettings', 'Settings') %>
</a> </a>
</li> </li>
<li class="nav-item content-listview<% if $ActiveTab == 'history' %> ui-tabs-active<% end_if %>"> <li class="nav-item content-listview<% if $TabIdentifier == 'history' %> ui-tabs-active<% end_if %>">
<a href="$LinkPageHistory" class="nav-link cms-panel-link" title="Form_EditForm" data-href="$LinkPageHistory"> <a href="$LinkPageHistory" class="nav-link cms-panel-link" title="Form_EditForm" data-href="$LinkPageHistory">
<% _t('SilverStripe\CMS\Controllers\CMSMain.TabHistory', 'History') %> <% _t('SilverStripe\CMS\Controllers\CMSMain.TabHistory', 'History') %>
</a> </a>