tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity

Adds cacheing for SiteTree::allowedChildren()

Browse Source 
This reduces the time for the page load in admin as it doesn't
  have to call `singleton()` as many times
This commit is contained in:
Lee Bradley 2017-02-10 10:31:25 +00:00 committed by Damian Mooyman
parent eed7359526
commit bd86251043
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
code/Model/SiteTree.php
View File

@ -119,6 +119,13 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
self::class self::class
]; ];
/**
* Used as a cache for `self::allowedChildren()`
* Drastically reduces admin page load when there are a lot of page types
* @var array
*/
protected static $_allowedChildren = array();
/** /**
* The default child class for this page. * The default child class for this page.
* Note: Value might be cached, see {@link $allowed_chilren}. * Note: Value might be cached, see {@link $allowed_chilren}.
@ -2459,6 +2466,9 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
*/ */
public function allowedChildren() public function allowedChildren()
{ {
if (isset(static::$_allowedChildren[$this->ClassName])) {
return static::$_allowedChildren[$this->ClassName];
}
// Get config based on old FIRST_SET rules // Get config based on old FIRST_SET rules
$candidates = null; $candidates = null;
$class = get_class($this); $class = get_class($this);
@ -2489,7 +2499,8 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
} }
} }
} }
return $allowedChildren;
return static::$_allowedChildren[$this->ClassName] = $allowedChildren;
} }
/** /**