Merge pull request #2044 from mikenz/asset-admin-missing-cms-usage

File Form missing CMS Usage information

_config/asset-admin.yml

@@ -0,0 +1,8 @@
+---
+Name: cms-asset-admin
+OnlyIf:
+  ModuleExists: silverstripe/asset-admin
+---
+SilverStripe\AssetAdmin\Forms\FileFormFactory:
+  extensions:
+    - SilverStripe\CMS\Model\SiteTreeFileFormFactoryExtension

code/Model/SiteTreeFileExtension.php

@@ -41,20 +41,6 @@ class SiteTreeFileExtension extends DataExtension
         'BackLinkHTMLList' => 'HTMLFragment'
     );
 
-    public function updateCMSFields(FieldList $fields)
-    {
-        $fields->insertAfter(
-            'LastEdited',
-            ReadonlyField::create(
-                'BackLinkCount',
-                _t(__CLASS__.'.BACKLINKCOUNT', 'Used on:'),
-                $this->BackLinkTracking()->count() . ' ' . _t(__CLASS__.'.PAGES', 'page(s)')
-            )
-                ->addExtraClass('cms-description-toggle')
-                ->setDescription($this->BackLinkHTMLList())
-        );
-    }
-
     /**
      * Generate an HTML list which provides links to where a file is used.
      *

code/Model/SiteTreeFileFormFactoryExtension.php

@@ -0,0 +1,46 @@
+<?php
+
+namespace SilverStripe\CMS\Model;
+
+use SilverStripe\Assets\File;
+use SilverStripe\Forms\FieldList;
+use SilverStripe\Forms\ReadonlyField;
+use SilverStripe\Forms\Tab;
+use SilverStripe\Forms\TabSet;
+use SilverStripe\ORM\DataExtension;
+use SilverStripe\ORM\FieldType\DBHTMLText;
+
+/**
+ * Extension applied to {@see FileFormFactory} to decorate with a "Used on:" information area.
+ * Uses tracking provided by {@see SiteTreeFileExtension} to generate this.
+ *
+ * @property File $owner
+ */
+class SiteTreeFileFormFactoryExtension extends DataExtension
+{
+    public function updateFormFields(FieldList $fields, $controller, $formName, $context)
+    {
+        // Create field
+        /** @var File|SiteTreeFileExtension $record */
+        $record = $context['Record'];
+        $usedOnField = ReadonlyField::create(
+            'BackLinkCount',
+            _t(__CLASS__.'.BACKLINKCOUNT', 'Used on:'),
+            $record->BackLinkTrackingCount() . ' ' . _t(__CLASS__.'.PAGES', 'page(s)')
+        )
+            ->addExtraClass('cms-description-toggle');
+
+        // Add table
+        /** @var DBHTMLText $backlinkHTML */
+        $backlinkHTML = $record->BackLinkHTMLList();
+        if (trim($backlinkHTML->forTemplate())) {
+            $usedOnField->setDescription($backlinkHTML);
+        }
+
+        // Add field to new tab
+        $tab = Tab::create('Usage', _t(__CLASS__.'.USAGE', 'Usage'), $usedOnField);
+        /** @var TabSet $tabset */
+        $tabset = $fields->fieldByName('Editor');
+        $tabset->push($tab);
+    }
+}

templates/SilverStripe/CMS/Model/Includes/SiteTreeFileExtension_description.ss

@@ -10,14 +10,14 @@
         <tbody>
         <% loop $BackLinkTracking %>
             <tr>
-				<th>$Pos</th>
+                <td>$Pos</td>
                 <td><a href="$CMSEditLink">$MenuTitle</a></td>
                 <td>
                     $i18n_singular_name
                     <% if $isPublished %>
-						<span class="label label-success">Published</span>
+                        <span class="badge badge-success">Published</span>
                     <% else %>
-						<span class="label label-info">Draft</span>
+                        <span class="badge status-addedtodraft">Draft</span>
                     <% end_if %>
                 </td>
             </tr>