tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity

Extracted ErrorPage default data to getter

Browse Source 
Allows for less verbose overloading, while still keeping i18n capabilities
in place, which isn't possible with DataObject::$default_records
This commit is contained in:
Ingo Schommer 2013-01-30 13:07:11 +01:00
parent 416178b668
commit b25063b09c
1 changed files with 35 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
code/model/ErrorPage.php
View File

@ -21,7 +21,7 @@ class ErrorPage extends Page {
"ShowInMenus" => 0, "ShowInMenus" => 0,
"ShowInSearch" => 0 "ShowInSearch" => 0
); );
static $allowed_children = array(); static $allowed_children = array();
static $description = 'Custom content for different error cases (e.g. "Page not found")'; static $description = 'Custom content for different error cases (e.g. "Page not found")';
@ -57,7 +57,7 @@ class ErrorPage extends Page {
return $response; return $response;
} }
} }
/** /**
* Ensures that there is always a 404 page * Ensures that there is always a 404 page
* by checking if there's an instance of * by checking if there's an instance of
@ -73,25 +73,7 @@ class ErrorPage extends Page {
mkdir(ASSETS_PATH); mkdir(ASSETS_PATH);
} }
$defaultPages = array( $defaultPages = $this->getDefaultRecords();
array(
'ErrorCode' => 404,
'Title' => _t('ErrorPage.DEFAULTERRORPAGETITLE', 'Page not found'),
'Content' => _t(
'ErrorPage.DEFAULTERRORPAGECONTENT',
'<p>Sorry, it seems you were trying to access a page that doesn\'t exist.</p>'
. '<p>Please check the spelling of the URL you were trying to access and try again.</p>'
)
),
array(
'ErrorCode' => 500,
'Title' => _t('ErrorPage.DEFAULTSERVERERRORPAGETITLE', 'Server error'),
'Content' => _t(
'ErrorPage.DEFAULTSERVERERRORPAGECONTENT',
'<p>Sorry, there was a problem with handling your request.</p>'
)
)
);
foreach($defaultPages as $defaultData) { foreach($defaultPages as $defaultData) {
$code = $defaultData['ErrorCode']; $code = $defaultData['ErrorCode'];
@ -103,10 +85,7 @@ class ErrorPage extends Page {
$pagePath = self::get_filepath_for_errorcode($code); $pagePath = self::get_filepath_for_errorcode($code);
if(!($pageExists && file_exists($pagePath))) { if(!($pageExists && file_exists($pagePath))) {
if(!$pageExists) { if(!$pageExists) {
$page = new ErrorPage(); $page = new ErrorPage($defaultData);
$page->ErrorCode = $code;
$page->Title = $defaultData['Title'];
$page->Content = $defaultData['Title'];
$page->write(); $page->write();
$page->publish('Stage', 'Live'); $page->publish('Stage', 'Live');
} }
@ -140,6 +119,37 @@ class ErrorPage extends Page {
} }
} }
/**
* Returns an array of arrays, each of which defines
* properties for a new ErrorPage record.
*
* @return Array
*/
protected function getDefaultRecords() {
$data = array(
array(
'ErrorCode' => 404,
'Title' => _t('ErrorPage.DEFAULTERRORPAGETITLE', 'Page not found'),
'Content' => _t(
'ErrorPage.DEFAULTERRORPAGECONTENT',
'<p>Sorry, it seems you were trying to access a page that doesn\'t exist.</p>'
. '<p>Please check the spelling of the URL you were trying to access and try again.</p>'
)
),
array(
'ErrorCode' => 500,
'Title' => _t('ErrorPage.DEFAULTSERVERERRORPAGETITLE', 'Server error'),
'Content' => _t(
'ErrorPage.DEFAULTSERVERERRORPAGECONTENT',
'<p>Sorry, there was a problem with handling your request.</p>'
)
)
);
$this->extend('getDefaultRecords', $data);
return $data;
}
public function getCMSFields() { public function getCMSFields() {
$fields = parent::getCMSFields(); $fields = parent::getCMSFields();