Merge pull request #2959 from creative-commoners/pulls/5.2/fix-behat

MNT Fix siteconfig behat test running on kitchen-sink
This commit is contained in:
Guy Sartorelli 2024-06-11 10:54:22 +12:00 committed by GitHub
commit ab332163a3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -5,6 +5,7 @@ namespace SilverStripe\CMS\Tests\Behaviour;
use Page;
use PHPUnit\Framework\Assert;
use SilverStripe\BehatExtension\Context\LoginContext as BehatLoginContext;
use SilverStripe\SiteConfig\SiteConfig;
class LoginContext extends BehatLoginContext
{
@ -26,7 +27,11 @@ class LoginContext extends BehatLoginContext
$password = 'Password!456';
$member = $this->generateMemberWithPermission($email, $password, $permCode);
$canEdit = strstr($negative ?? '', 'not') ? false : true;
// Flush the SiteConfig cache so that siteconfig behat tests that update a
// SiteConfig DataObject will not be referring to a stale verion of itself
// which can happen because SiteConfig::current_site_config() uses DataObject::get_one()
// which will caches its result by default
SiteConfig::current_site_config()->flushCache();
if ($canEdit) {
Assert::assertTrue($page->canEdit($member), 'The member can edit this page');
} else {