From 4a5e22cc60d8faeb0a8bdf5ab54906389fb2f3b9 Mon Sep 17 00:00:00 2001
From: Steve Boyd <emteknetnz@gmail.com>
Date: Tue, 20 Dec 2022 14:41:32 +1300
Subject: [PATCH 1/2] MNT Update unit test to handle HTML5Value

---
 tests/php/Model/SiteTreeTest.php | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/tests/php/Model/SiteTreeTest.php b/tests/php/Model/SiteTreeTest.php
index 71bb02ab..2f6c305d 100644
--- a/tests/php/Model/SiteTreeTest.php
+++ b/tests/php/Model/SiteTreeTest.php
@@ -39,6 +39,8 @@ use SilverStripe\View\Parsers\URLSegmentFilter;
 use SilverStripe\View\Shortcodes\EmbedShortcodeProvider;
 use TractorCow\Fluent\Extension\FluentSiteTreeExtension;
 use const RESOURCES_DIR;
+use SilverStripe\View\Parsers\HTMLValue;
+use SilverStripe\HTML5\HTML5Value;
 
 class SiteTreeTest extends SapphireTest
 {
@@ -2023,10 +2025,20 @@ class SiteTreeTest extends SapphireTest
      */
     public function testSanitiseExtraMeta(string $extraMeta, string $expected, string $message): void
     {
+        // If using HTML5Value then the 'somethingdodgy' test won't be converted to valid html
+        // However if using the default HTMLValue, then it will be converted to valid html
+        $isDodgyAndUsingHTML5 = strpos($expected, 'somethingdodgy') !== false &&
+            (HTMLValue::create() instanceof HTML5Value);
+        if ($isDodgyAndUsingHTML5) {
+            $this->expectException(ValidationException::class);
+            $this->expectExceptionMessage('Custom Meta Tags does not contain valid HTML');
+        }
         $siteTree = new SiteTree();
         $siteTree->ExtraMeta = $extraMeta;
         $siteTree->write();
-        $this->assertSame($expected, $siteTree->ExtraMeta, $message);
+        if (!$isDodgyAndUsingHTML5) {
+            $this->assertSame($expected, $siteTree->ExtraMeta, $message);
+        }
     }
 
     public function provideSanitiseExtraMeta(): array

From 9811579203df35e40273f4502b5e3e9afa5a1987 Mon Sep 17 00:00:00 2001
From: Steve Boyd <emteknetnz@gmail.com>
Date: Thu, 12 Jan 2023 13:55:37 +1300
Subject: [PATCH 2/2] FIX Behat test

---
 tests/behat/features/edit-a-page.feature | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/behat/features/edit-a-page.feature b/tests/behat/features/edit-a-page.feature
index 1d12d47e..98e48aee 100644
--- a/tests/behat/features/edit-a-page.feature
+++ b/tests/behat/features/edit-a-page.feature
@@ -54,7 +54,7 @@ Feature: Edit a page
     Then the rendered HTML should contain "/about-modified-us"
 
     # Add metadata
-    When I click on the "#ui-accordion-Form_EditForm_Metadata-header-0" element
+    When I click on the ".ui-accordion-header" element
     And I wait for 1 second
     And I fill in "Meta Description" with "MyMetaDesc"