tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 06:05:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1377 from tractorcow/pulls/4.0/virtualpage-permissions

Browse Source 
API VirtualPage permissions now can be set independently of the mirrored page
This commit is contained in:
Daniel Hensby 2016-01-26 22:58:50 +00:00
commit 92546b481e
3 changed files with 83 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/model/VirtualPage.php
View File

@ -29,6 +29,8 @@ class VirtualPage extends Page {
'Version',
"Embargo",
"Expiry",
"CanViewType",
"CanEditType",
);
/**

36
tests/model/VirtualPageTest.php
View File

@ -208,6 +208,42 @@ class VirtualPageTest extends FunctionalTest {
$this->assertTrue($vp->doDeleteFromLive());
$this->assertNull(DB::query("SELECT \"ID\" FROM \"SiteTree_Live\" WHERE \"ID\" = $vp->ID")->value());
}
public function testCanEdit() {
$parentPage = $this->objFromFixture('Page', 'master3');
$virtualPage = $this->objFromFixture('VirtualPage', 'vp3');
$bob = $this->objFromFixture('Member', 'bob');
$andrew = $this->objFromFixture('Member', 'andrew');
// Bob can edit the mirrored page, but he shouldn't be able to edit the virtual page.
$this->logInAs($bob);
$this->assertTrue($parentPage->canEdit());
$this->assertFalse($virtualPage->canEdit());
// Andrew can only edit the virtual page, but not the original.
$this->logInAs($andrew);
$this->assertFalse($parentPage->canEdit());
$this->assertTrue($virtualPage->canEdit());
}
public function testCanView() {
$parentPage = $this->objFromFixture('Page', 'master3');
$parentPage->publish('Stage', 'Live');
$virtualPage = $this->objFromFixture('VirtualPage', 'vp3');
$virtualPage->publish('Stage', 'Live');
$cindy = $this->objFromFixture('Member', 'cindy');
$alice = $this->objFromFixture('Member', 'alice');
// Cindy can see both pages
$this->logInAs($cindy);
$this->assertTrue($parentPage->canView());
$this->assertTrue($virtualPage->canView());
// Alice can't see the virtual page, since it's restricted to cindy
$this->logInAs($alice);
$this->assertTrue($parentPage->canView());
$this->assertFalse($virtualPage->canView());
}
public function testVirtualPagesArentInappropriatelyPublished() {
// Fixture

45
tests/model/VirtualPageTest.yml
View File

@ -1,3 +1,36 @@
Group:
bobgroup:
Title: BobGroup
code: bobgroup
andrewgroup:
Title: AndrewGroup
code: andrewgroup
cindygroup:
Title: CindyGroup
code: cindygroup
alicegroup:
Title: AliceGroup
code: alicegrouip
Permission:
bobpermission:
Code: CMS_ACCESS_CMSMain
Group: =>Group.bobgroup
andrewpermission:
Code: CMS_ACCESS_CMSMain
Group: =>Group.andrewgroup
Member:
bob:
Email: bob@bobby.com
Groups: =>Group.bobgroup
andrew:
Email: andrew@andrew.com
Groups: =>Group.andrewgroup
cindy:
Email: cindy@cindy.com
Groups: =>Group.cindygroup
alice:
Email: alice@alice.com
Groups: =>Group.alicegroup
Page:
master:
Title: My Page
@ -7,6 +40,11 @@ Page:
MenuTitle: My Other Page Nav
holder:
Title: Sub-pages
master3:
Title: CanEditBob
CanEditType: OnlyTheseUsers
CanViewType: Inherit
EditorGroups: =>Group.bobgroup
VirtualPage:
vp1:
Title: vp1
@ -16,3 +54,10 @@ VirtualPage:
Title: vp2
CopyContentFrom: =>Page.master
Parent: =>Page.holder
vp3:
CopyContentFrom: =>Page.master3
Parent: =>Page.holder
CanEditType: OnlyTheseUsers
CanViewType: OnlyTheseUsers
EditorGroups: =>Group.andrewgroup
ViewerGroups: =>Group.cindygroup