tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity

Simplify code to use dataFields()

Browse Source
This commit is contained in:
Damian Mooyman 2017-02-28 16:34:46 +13:00
parent 2fafff084f
commit 8537d6ddb1
No known key found for this signature in database
GPG Key ID: 78B823A10DE27D1A
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
code/Controllers/CMSPageHistoryController.php
View File

@ -473,17 +473,20 @@ class CMSPageHistoryController extends CMSMain
return $crumbs; return $crumbs;
} }
/**
* Replace all data fields with HTML readonly fields to display diff
*
* @param FieldList $fields
* @return FieldList
*/
public function transformReadonly(FieldList $fields) public function transformReadonly(FieldList $fields)
{ {
foreach($fields as &$field) { foreach ($fields->dataFields() as $field) {
if ($field instanceof CompositeField) { if ($field instanceof HiddenField) {
$subfields = $this->transformReadonly($field->FieldList()); continue;
$field->setChildren($subfields);
}
if ($field->hasData() && !$field instanceof HiddenField) {
$newField = $field->castedCopy(HTMLReadonlyField::class);
$fields->replaceField($field->getName(), $newField);
} }
$newField = $field->castedCopy(HTMLReadonlyField::class);
$fields->replaceField($field->getName(), $newField);
} }
return $fields; return $fields;
} }