From 8089e04879ac02858f62d73a8a85eda2338810db Mon Sep 17 00:00:00 2001 From: Sean Harvey Date: Mon, 31 Jan 2011 03:06:35 +0000 Subject: [PATCH] BUGFIX #6291 Remove rollback action from CMSMain allowed_actions and rely on form action_rollback instead which is safer (from r115440) git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@115919 467b73ca-7a2a-4603-9d3b-597d59a354a9 --- code/CMSMain.php | 15 +++++++-------- tests/CMSMainTest.php | 17 +++++++++++++++-- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/code/CMSMain.php b/code/CMSMain.php index 984f95da..3c2519e4 100644 --- a/code/CMSMain.php +++ b/code/CMSMain.php @@ -331,12 +331,15 @@ JS; * Get a database record to be managed by the CMS */ public function getRecord($id) { - $treeClass = $this->stat('tree_class'); if($id && is_numeric($id)) { - // First, try getting a record from the stage site - $record = DataObject::get_one( $treeClass, "`$treeClass`.ID = $id"); + $version = isset($_REQUEST['Version']) ? $_REQUEST['Version'] : null; + if(is_numeric($version)) { + $record = Versioned::get_version($treeClass, $id, $version); + } else { + $record = DataObject::get_one($treeClass, "`$treeClass`.ID = $id"); + } // Then, try getting a record from the live site if(!$record) { @@ -743,11 +746,7 @@ JS; 'Root' ); - $actions = new FieldSet( - new FormAction("email", _t('CMSMain.EMAIL',"Email")), - new FormAction("print", _t('CMSMain.PRINT',"Print")), - new FormAction("rollback", _t('CMSMain.ROLLBACK',"Roll back to this version")) - ); + $actions = $record->getCMSActions(); // encode the message to appear in the body of the email $archiveURL = Director::absoluteBaseURL() . $record->URLSegment . '?archiveDate=' . $record->obj('LastEdited')->URLDatetime(); diff --git a/tests/CMSMainTest.php b/tests/CMSMainTest.php index dfdd610b..1a8ca7bd 100644 --- a/tests/CMSMainTest.php +++ b/tests/CMSMainTest.php @@ -132,7 +132,20 @@ class CMSMainTest extends FunctionalTest { $newPage = $cmsMain->getRecord('new-Page-5'); $this->assertType('Page', $newPage); $this->assertEquals('5', $newPage->ParentID); - } -} \ No newline at end of file + function testGetVersionRecord() { + $cmsMain = new CMSMain(); + $page1 = $this->objFromFixture('Page', 'page1'); + $page1->Content = 'this is the old content'; + $page1->write(); + $page1->Content = 'this is new content (new version)'; + $page1->write(); + $versionID = DB::query('SELECT `Version` FROM `SiteTree_versions` WHERE `Content` = \'this is the old content\'')->value(); + $_REQUEST['Version'] = $versionID; + $this->assertEquals($cmsMain->getRecord($page1->ID)->Version, $versionID); + $this->assertEquals($cmsMain->getRecord($page1->ID)->Content, 'this is the old content'); + unset($_REQUEST['Version']); + } + +}