tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-09-28 04:16:25 +02:00
Code Issues Projects Releases Wiki Activity

FIX for #1294 to workaround ErrorPage fatal errors (and undefined var) when publishing.

Browse Source
This commit is contained in:
Patrick Nelson 2015-10-08 17:38:58 -04:00
parent d8915115f8
commit 785f85047f
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
code/model/ErrorPage.php
View File

@ -222,11 +222,10 @@ class ErrorPage extends Page {
* content, so the page can be shown even when SilverStripe is not * content, so the page can be shown even when SilverStripe is not
* functioning correctly before publishing this page normally. * functioning correctly before publishing this page normally.
* *
* @return void * @return bool
*/ */
public function doPublish() { public function doPublish() {
parent::doPublish(); if (!parent::doPublish()) return false;
return $this->writeStaticPage(); return $this->writeStaticPage();
} }
@ -255,10 +254,10 @@ class ErrorPage extends Page {
$fileErrorText = _t( $fileErrorText = _t(
'ErrorPage.ERRORFILEPROBLEM', 'ErrorPage.ERRORFILEPROBLEM',
'Error opening file "{filename}" for writing. Please check file permissions.', 'Error opening file "{filename}" for writing. Please check file permissions.',
array('filename' => $errorFile) array('filename' => $filePath)
); );
$this->response->addHeader('X-Status', rawurlencode($fileErrorText)); user_error($fileErrorText, E_USER_WARNING);
return $this->httpError(405); return false;
} }
return true; return true;
} }