tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity

NEW Add extension hook updateRedirectionLink()

Browse Source
This commit is contained in:
Will Rossiter 2020-01-24 22:07:29 +13:00
parent f092583225
commit 6ee17a83e3
No known key found for this signature in database
GPG Key ID: F24330E3B4B95B75
1 changed files with 32 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
code/Model/RedirectorPage.php
View File

@ -28,18 +28,18 @@ class RedirectorPage extends Page
private static $show_live_link = false; private static $show_live_link = false;
private static $db = array( private static $db = [
"RedirectionType" => "Enum('Internal,External','Internal')", "RedirectionType" => "Enum('Internal,External','Internal')",
"ExternalURL" => "Varchar(2083)" // 2083 is the maximum length of a URL in Internet Explorer. "ExternalURL" => "Varchar(2083)" // 2083 is the maximum length of a URL in Internet Explorer.
); ];
private static $defaults = array( private static $defaults = [
"RedirectionType" => "Internal" "RedirectionType" => "Internal"
); ];
private static $has_one = array( private static $has_one = [
"LinkTo" => SiteTree::class, "LinkTo" => SiteTree::class,
); ];
private static $table_name = 'RedirectorPage'; private static $table_name = 'RedirectorPage';
@ -91,36 +91,44 @@ class RedirectorPage extends Page
/** /**
* Return the link that we should redirect to. * Return the link that we should redirect to.
* Only return a value if there is a legal redirection destination. * Only return a value if there is a legal redirection destination.
*
* @return string
*/ */
public function redirectionLink() public function redirectionLink()
{ {
// Check external redirect // Check external redirect
if ($this->RedirectionType == 'External') { if ($this->RedirectionType == 'External') {
return $this->ExternalURL ?: null; $result = $this->ExternalURL ?: null;
$this->extend('updateRedirectionLink', $result);
return $result;
} }
// Check internal redirect // Check internal redirect
/** @var SiteTree $linkTo */ /** @var SiteTree $linkTo */
$linkTo = $this->LinkToID ? SiteTree::get()->byID($this->LinkToID) : null; $linkTo = $this->LinkToID ? SiteTree::get()->byID($this->LinkToID) : null;
if (empty($linkTo)) { if (empty($linkTo)) {
return null; $link = null;
} elseif ($this->ID == $linkTo->ID) {
// We shouldn't point to ourselves
$link = null;
} elseif ($linkTo instanceof RedirectorPage) {
// If we're linking to another redirectorpage then just return the
// URLSegment, to prevent a cycle of redirector
// pages from causing an infinite loop. Instead, they will cause
// a 30x redirection loop in the browser, but
// this can be handled sufficiently gracefully by the browser.
$link = $linkTo->regularLink();
} else {
// For all other pages, just return the link of the page.
$link = $linkTo->Link();
} }
// We shouldn't point to ourselves - that would create an infinite loop! Return null since we have a $this->extend('updateRedirectionLink', $link);
// bad configuration
if ($this->ID == $linkTo->ID) {
return null;
}
// If we're linking to another redirectorpage then just return the URLSegment, to prevent a cycle of redirector return $link;
// pages from causing an infinite loop. Instead, they will cause a 30x redirection loop in the browser, but
// this can be handled sufficiently gracefully by the browser.
if ($linkTo instanceof RedirectorPage) {
return $linkTo->regularLink();
}
// For all other pages, just return the link of the page.
return $linkTo->Link();
} }
public function syncLinkTracking() public function syncLinkTracking()
@ -194,12 +202,13 @@ class RedirectorPage extends Page
) )
); );
}); });
return parent::getCMSFields(); return parent::getCMSFields();
} }
// Don't cache RedirectorPages // Don't cache RedirectorPages
public function subPagesToCache() public function subPagesToCache()
{ {
return array(); return [];
} }
} }