From 5b993b999082189a3180cd2d4447e4522b5cdf60 Mon Sep 17 00:00:00 2001 From: Sean Harvey Date: Mon, 6 Apr 2009 01:11:41 +0000 Subject: [PATCH] BUGFIX Fixed issue with StaticPublisher->onAfterWrite() failing because of incorrect arguments to Versioned::get_by_stage() MINOR Fixed undefined variable error if $urls doesn't exist and tries to loop through the non-existant array in StaticPublisher->onAfterWrite() git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/branches/2.3@74092 467b73ca-7a2a-4603-9d3b-597d59a354a9 --- code/staticpublisher/StaticPublisher.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/code/staticpublisher/StaticPublisher.php b/code/staticpublisher/StaticPublisher.php index 6c2fe663..ea783ad5 100644 --- a/code/staticpublisher/StaticPublisher.php +++ b/code/staticpublisher/StaticPublisher.php @@ -23,13 +23,16 @@ abstract class StaticPublisher extends DataObjectDecorator { } function onAfterPublish($original) { + $urls = array(); + if($this->owner->hasMethod('pagesAffectedByChanges')) { $urls = $this->owner->pagesAffectedByChanges($original); } else { - // $pages = array(Versioned::get_one_by_stage('SiteTree', 'Live', "`SiteTree`.ID = {$this->owner->ID}")); - $pages = Versioned::get_by_stage('SiteTree', 'Live', '', '', 10); - foreach($pages as $page) { - $urls[] = $page->Link(); + $pages = Versioned::get_by_stage('SiteTree', 'Live', '', '', '', 10); + if($pages) { + foreach($pages as $page) { + $urls[] = $page->Link(); + } } }