From 5024a48f896f4a766aaa9051e89312ad6a1e68b3 Mon Sep 17 00:00:00 2001 From: Simon Welsh Date: Sun, 16 Mar 2014 19:09:47 +1300 Subject: [PATCH] FIX: Reports with Parameter fields override ReportTitle and ReportDescription Fixes #696 --- code/reports/Report.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code/reports/Report.php b/code/reports/Report.php index ee151b40..bb965481 100644 --- a/code/reports/Report.php +++ b/code/reports/Report.php @@ -219,8 +219,8 @@ class SS_Report extends ViewableData { } // Add search fields is available - if($this->hasMethod('parameterFields') && $fields = $this->parameterFields()) { - foreach($fields as $field) { + if($this->hasMethod('parameterFields') && $parameterFields = $this->parameterFields()) { + foreach($parameterFields as $field) { // Namespace fields for easier handling in form submissions $field->setName(sprintf('filters[%s]', $field->getName())); $field->addExtraClass('no-change-track'); // ignore in changetracker