From 4809523bae598f36e5d233fdc3f1b9c8b073f241 Mon Sep 17 00:00:00 2001 From: Ingo Schommer Date: Sat, 21 Nov 2009 02:38:31 +0000 Subject: [PATCH] MINOR JavaScript code indentation and formatting git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92656 467b73ca-7a2a-4603-9d3b-597d59a354a9 --- javascript/CMSMain.js | 515 +++++++++++++++-------------- javascript/LeftAndMain.EditForm.js | 279 ++++++++-------- javascript/LeftAndMain.js | 368 +++++++++++---------- 3 files changed, 586 insertions(+), 576 deletions(-) diff --git a/javascript/CMSMain.js b/javascript/CMSMain.js index 4e1793c9..304b0509 100644 --- a/javascript/CMSMain.js +++ b/javascript/CMSMain.js @@ -14,108 +14,109 @@ var ss_MainLayout; $('body.CMSMain').concrete('ss', function($){ return/** @lends ss.CMSMain */{ - /** - * Reference to jQuery.layout element - * @type Object - */ - MainLayout: null, + /** + * Reference to jQuery.layout element + * @type Object + */ + MainLayout: null, - onmatch: function() { - var self = this; + onmatch: function() { + var self = this; - // Layout - ss_MainLayout = this._setupLayout(); - this.setMainLayout(ss_MainLayout); - layoutState.options.keys = "west.size,west.isClosed"; - $(window).unload(function(){ layoutState.save('ss_MainLayout') }); + // Layout + ss_MainLayout = this._setupLayout(); + this.setMainLayout(ss_MainLayout); + layoutState.options.keys = "west.size,west.isClosed"; + $(window).unload(function(){ layoutState.save('ss_MainLayout');}); - // artificially delay the resize event 200ms - // to avoid overlapping height changes in different onresize() methods - $(window).resize(function () { - var timerID = "timerCMSMainResize"; - if (window[timerID]) clearTimeout(window[timerID]); - window[timerID] = setTimeout(function() {self._resizeChildren();}, 200); - }); + // artificially delay the resize event 200ms + // to avoid overlapping height changes in different onresize() methods + $(window).resize(function () { + var timerID = "timerCMSMainResize"; + if (window[timerID]) clearTimeout(window[timerID]); + window[timerID] = setTimeout(function() {self._resizeChildren();}, 200); + }); - // If tab has no nested tabs, set overflow to auto - $(this).find('.tab').not(':has(.tab)').css('overflow', 'auto'); + // If tab has no nested tabs, set overflow to auto + $(this).find('.tab').not(':has(.tab)').css('overflow', 'auto'); - this._resizeChildren(); + this._resizeChildren(); - this._super(); - }, + this._super(); + }, - _resizeChildren: function() { - $("#treepanes", this).accordion("resize"); - $('#sitetree_and_tools', this).fitHeightToParent(); - $('#contentPanel form', this).fitHeightToParent(); - $('#contentPanel form fieldset', this).fitHeightToParent(); - $('#contentPanel form fieldset .content', this).fitHeightToParent(); + _resizeChildren: function() { + $("#treepanes", this).accordion("resize"); + $('#sitetree_and_tools', this).fitHeightToParent(); + $('#contentPanel form', this).fitHeightToParent(); + $('#contentPanel form fieldset', this).fitHeightToParent(); + $('#contentPanel form fieldset .content', this).fitHeightToParent(); - this._super(); - }, + this._super(); + }, - /** - * Initialize jQuery layout manager with the following panes: - * - east: Tree, Page Version History, Site Reports - * - center: Form - * - west: "Insert Image", "Insert Link", "Insert Flash" panes - * - north: CMS area menu bar - * - south: "Page view", "profile" and "logout" links - */ - _setupLayout: function() { - var self = this; + /** + * Initialize jQuery layout manager with the following panes: + * - east: Tree, Page Version History, Site Reports + * - center: Form + * - west: "Insert Image", "Insert Link", "Insert Flash" panes + * - north: CMS area menu bar + * - south: "Page view", "profile" and "logout" links + */ + _setupLayout: function() { + var self = this; - // layout containing the tree, CMS menu, the main form etc. - var savedLayoutSettings = layoutState.load('ss_MainLayout'); - var layoutSettings = jQuery.extend({ - defaults: { - // TODO Reactivate once we have localized values - togglerTip_open: '', - togglerTip_closed: '', - resizerTip: '', - sliderTip: '', - onresize: function() {self._resizeChildren();}, - onopen: function() {self._resizeChildren();} - }, - north: { - slidable: false, - resizable: false, - size: 35, - togglerLength_open: 0 - }, - south: { - slidable: false, - resizable: false, - size: 23, - togglerLength_open: 0 - }, - west: { - size: 225, - fxName: "none" - }, - east: { - initClosed: true, - // multiple panels which are triggered through tinymce buttons, - // so a user shouldn't be able to toggle this panel manually - initHidden: true, - fxName: "none", - size: 250 - }, - center: {} - }, savedLayoutSettings); - var layout = $('body').layout(layoutSettings); + // layout containing the tree, CMS menu, the main form etc. + var savedLayoutSettings = layoutState.load('ss_MainLayout'); + var layoutSettings = jQuery.extend({ + defaults: { + // TODO Reactivate once we have localized values + togglerTip_open: '', + togglerTip_closed: '', + resizerTip: '', + sliderTip: '', + onresize: function() {self._resizeChildren();}, + onopen: function() {self._resizeChildren();} + }, + north: { + slidable: false, + resizable: false, + size: 35, + togglerLength_open: 0 + }, + south: { + slidable: false, + resizable: false, + size: 23, + togglerLength_open: 0 + }, + west: { + size: 225, + fxName: "none" + }, + east: { + initClosed: true, + // multiple panels which are triggered through tinymce buttons, + // so a user shouldn't be able to toggle this panel manually + initHidden: true, + fxName: "none", + size: 250 + }, + center: {} + }, savedLayoutSettings); + var layout = $('body').layout(layoutSettings); - // Adjust tree accordion etc. in left panel to work correctly - // with jQuery.layout (see http://layout.jquery-dev.net/tips.html#Widget_Accordion) - this.find("#treepanes").accordion({ - fillSpace: true, - animated: false - }); + // Adjust tree accordion etc. in left panel to work correctly + // with jQuery.layout (see http://layout.jquery-dev.net/tips.html#Widget_Accordion) + this.find("#treepanes").accordion({ + fillSpace: true, + animated: false + }); - return layout; - } - }}); + return layout; + } + }; + }); /** * @class CMS-specific form behaviour @@ -123,18 +124,17 @@ var ss_MainLayout; */ $('#Form_EditForm').concrete('ss', function($){ return/** @lends ss.EditForm */{ - onmatch: function() { - // Alert the user on change of page-type - this might have implications - // on the available form fields etc. - this.find(':input[name=ClassName]').bind('change', - function() { - alert('The page type will be updated after the page is saved'); - } - ); - - this.find(':input[name=ParentID]') - } - }}); + onmatch: function() { + // Alert the user on change of page-type - this might have implications + // on the available form fields etc. + this.find(':input[name=ClassName]').bind('change', + function() { + alert('The page type will be updated after the page is saved'); + } + ); + } + }; + }); /** * @class ParentID field combination - mostly toggling between @@ -143,32 +143,33 @@ var ss_MainLayout; */ $('#Form_EditForm_ParentType').concrete('ss', function($){ return/** @lends ss.EditForm.ParentType */{ - onmatch : function() { - var parentTypeRootEl = $('#Form_EditForm_ParentType_root'); - var parentTypeSubpageEl = $('#Form_EditForm_ParentType_subpage'); - if(parentTypeRootEl) { - parentTypeRootEl.onclick = this._rootClick.bind(this); - } - if(parentTypeSubpageEl) { - parentTypeSubpageEl.onclick = this.showHide; - } - this.showHide(); - }, + onmatch : function() { + var parentTypeRootEl = $('#Form_EditForm_ParentType_root'); + var parentTypeSubpageEl = $('#Form_EditForm_ParentType_subpage'); + if(parentTypeRootEl) { + parentTypeRootEl.onclick = this._rootClick.bind(this); + } + if(parentTypeSubpageEl) { + parentTypeSubpageEl.onclick = this.showHide; + } + this.showHide(); + }, - _rootClick : function() { - $('#Form_EditForm_ParentID').val(0); - this.showHide(); - }, + _rootClick : function() { + $('#Form_EditForm_ParentID').val(0); + this.showHide(); + }, - showHide : function() { - var parentTypeRootEl = $('#Form_EditForm_ParentType_root'); - if(parentTypeRootEl && parentTypeRootEl.checked) { - $('#ParentID').hide(); - } else { - $('#ParentID').show(); + showHide : function() { + var parentTypeRootEl = $('#Form_EditForm_ParentType_root'); + if(parentTypeRootEl && parentTypeRootEl.checked) { + $('#ParentID').hide(); + } else { + $('#ParentID').show(); + } } - } - }}); + }; + }); /** * @class Toggle display of group dropdown in "access" tab, @@ -191,7 +192,7 @@ var ss_MainLayout; var currentVal = this.find('input[name=' + this.attr('id') + ']:checked').val(); dropdown.toggle(currentVal == 'OnlyTheseUsers'); } - } + }; }); /** @@ -201,18 +202,19 @@ var ss_MainLayout; */ $('#Form_EditForm .Actions #Form_EditForm_action_email').concrete('ss', function($){ return/** @lends ss.Form_EditForm_action_email */{ - onclick: function(e) { - window.open( - 'mailto:?subject=' - + $('input[name=ArchiveEmailSubject]', this[0].form).val() - + '&body=' - + $(':input[name=ArchiveEmailMessage]', this[0].form).val(), - 'archiveemail' - ); + onclick: function(e) { + window.open( + 'mailto:?subject=' + + $('input[name=ArchiveEmailSubject]', this[0].form).val() + + '&body=' + + $(':input[name=ArchiveEmailMessage]', this[0].form).val(), + 'archiveemail' + ); - return false; - } - }}); + return false; + } + }; + }); /** * @class Open a printable representation of the form in a new window. @@ -221,17 +223,18 @@ var ss_MainLayout; */ $('#Form_EditForm .Actions #Form_EditForm_action_print').concrete('ss', function($){ return/** @lends ss.Form_EditForm_action_print */{ - onclick: function(e) { - var printURL = $(this[0].form).attr('action').replace(/\?.*$/,'') - + '/printable/' - + $(':input[name=ID]',this[0].form).val(); - if(printURL.substr(0,7) != 'http://') printURL = $('base').attr('href') + printURL; + onclick: function(e) { + var printURL = $(this[0].form).attr('action').replace(/\?.*$/,'') + + '/printable/' + + $(':input[name=ID]',this[0].form).val(); + if(printURL.substr(0,7) != 'http://') printURL = $('base').attr('href') + printURL; - window.open(printURL, 'printable'); + window.open(printURL, 'printable'); - return false; - } - }}); + return false; + } + }; + }); /** * @class A "rollback" to a specific version needs user confirmation. @@ -239,11 +242,12 @@ var ss_MainLayout; */ $('#Form_EditForm .Actions #Form_EditForm_action_rollback').concrete('ss', function($){ return/** @lends ss.Form_EditForm_action_rollback */{ - onclick: function(e) { - // @todo i18n - return confirm("Do you really want to copy the published content to the stage site?"); - } - }}); + onclick: function(e) { + // @todo i18n + return confirm("Do you really want to copy the published content to the stage site?"); + } + }; + }); /** * @class All forms in the right content panel should have closeable jQuery UI style titles. @@ -251,19 +255,20 @@ var ss_MainLayout; */ $('#contentPanel form').concrete('ss', function($){ return/** @lends ss.contentPanel.form */{ - onmatch: function() { - // Style as title bar - this.find(':header:first').titlebar({ - closeButton:true - }); - // The close button should close the east panel of the layout - this.find(':header:first .ui-dialog-titlebar-close').bind('click', function(e) { - $('body.CMSMain').concrete('ss').MainLayout().close('east'); + onmatch: function() { + // Style as title bar + this.find(':header:first').titlebar({ + closeButton:true + }); + // The close button should close the east panel of the layout + this.find(':header:first .ui-dialog-titlebar-close').bind('click', function(e) { + $('body.CMSMain').concrete('ss').MainLayout().close('east'); - return false; - }); - } - }}); + return false; + }); + } + }; + }); /** * @class Control the site tree filter. @@ -274,127 +279,127 @@ var ss_MainLayout; $('#Form_SearchTreeForm').concrete('ss', function($) { return/** @lends ss.Form_SeachTreeForm */{ - /** - * @type DOMElement - */ - SelectEl: null, + /** + * @type DOMElement + */ + SelectEl: null, - onmatch: function() { - var self = this; + onmatch: function() { + var self = this; - // TODO Cant bind to onsubmit/onreset directly because of IE6 - this.bind('submit', function(e) {return self._submitForm(e);}); - this.bind('reset', function(e) {return self._resetForm(e);}); + // TODO Cant bind to onsubmit/onreset directly because of IE6 + this.bind('submit', function(e) {return self._submitForm(e);}); + this.bind('reset', function(e) {return self._resetForm(e);}); - // only the first field should be visible by default - this.find('.field').not(':first').hide(); + // only the first field should be visible by default + this.find('.field').not(':first').hide(); - // generate the field dropdown - this.setSelectEl($('') - .appendTo(this.find('fieldset:first')) - .bind('change', function(e) {self._addField(e);}) - ); + // generate the field dropdown + this.setSelectEl($('') + .appendTo(this.find('fieldset:first')) + .bind('change', function(e) {self._addField(e);}) + ); - this._setOptions(); + this._setOptions(); - }, + }, - _setOptions: function() { - var self = this; + _setOptions: function() { + var self = this; - // reset existing elements - self.SelectEl().find('option').remove(); + // reset existing elements + self.SelectEl().find('option').remove(); - // add default option - // TODO i18n - jQuery('').appendTo(self.SelectEl()) + // add default option + // TODO i18n + jQuery('').appendTo(self.SelectEl()); - // populate dropdown values from existing fields - this.find('.field').each(function() { - $('