tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 08:05:56 +02:00
Code Issues Projects Releases Wiki Activity

FIX: Make test comparison less brittle in MigrateSiteTreeLinkingTaskTest

Browse Source 
Comparing every single field is unnecessary and brittle, only the IDs
need to be compared.

Notably this tripped over a potential bug fix in
https://github.com/silverstripe/silverstripe-framework/pull/8591
but the change should be incorporated regardless.
This commit is contained in:
Sam Minnee 2019-05-28 12:51:23 +12:00
parent 60b2947519
commit 469e7ca01b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/php/Tasks/MigrateSiteTreeLinkingTaskTest.php
View File

@ -80,10 +80,10 @@ class MigrateSiteTreeLinkingTaskTest extends SapphireTest
$hash = $this->objFromFixture(SiteTree::class, 'hash_link');
// Ensure all links are created
$this->assertListEquals([$about->toMap(), $staff->toMap()], $home->LinkTracking());
$this->assertListEquals([$home->toMap(), $staff->toMap()], $about->LinkTracking());
$this->assertListEquals([$home->toMap(), $about->toMap()], $staff->LinkTracking());
$this->assertListEquals([$home->toMap()], $action->LinkTracking());
$this->assertListEquals([$home->toMap(), $about->toMap()], $hash->LinkTracking());
$this->assertListEquals([['ID' => $about->ID], ['ID' => $staff->ID]], $home->LinkTracking());
$this->assertListEquals([['ID' => $home->ID], ['ID' => $staff->ID]], $about->LinkTracking());
$this->assertListEquals([['ID' => $home->ID], ['ID' => $about->ID]], $staff->LinkTracking());
$this->assertListEquals([['ID' => $home->ID]], $action->LinkTracking());
$this->assertListEquals([['ID' => $home->ID], ['ID' => $about->ID]], $hash->LinkTracking());
}
}