From 92e0c410b8c3db09c394916ace4ecb89b61f7ddb Mon Sep 17 00:00:00 2001 From: Ingo Schommer Date: Wed, 2 Oct 2013 11:52:14 +0200 Subject: [PATCH] Fixed report link escaping --- code/reports/Report.php | 2 +- tests/behat/features/view-reports.feature | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/code/reports/Report.php b/code/reports/Report.php index 09e3ce0c..54099e2f 100644 --- a/code/reports/Report.php +++ b/code/reports/Report.php @@ -303,7 +303,7 @@ class SS_Report extends ViewableData { if(isset($info['link']) && $info['link']) { $fieldFormatting[$source] = function($value, &$item) { return sprintf( - '%s', + '%s', Controller::join_links(singleton('CMSPageEditController')->Link('show'), $item->ID), Convert::raw2xml($value) ); diff --git a/tests/behat/features/view-reports.feature b/tests/behat/features/view-reports.feature index a51fe80a..837eb66a 100644 --- a/tests/behat/features/view-reports.feature +++ b/tests/behat/features/view-reports.feature @@ -12,4 +12,7 @@ Feature: View Reports Scenario: I can view the "Pages with no content" report When I follow "Pages with no content" Then I should see "Empty Page" - But I should not see "Filled Page" \ No newline at end of file + But I should not see "Filled Page" + When I follow "Empty Page" + Then I should see an edit page form + And the "Page name" field should contain "Empty Page" \ No newline at end of file