diff --git a/.travis.yml b/.travis.yml index 08efce81..7387f80b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,27 +1,24 @@ language: php -php: - - 5.3 - - 5.4 +php: + - 5.3 env: - - DB=MYSQL CORE_RELEASE=master - - DB=PGSQL CORE_RELEASE=master - - DB=SQLITE3 CORE_RELEASE=master - - PHPCS=1 CORE_RELEASE=master + - DB=MYSQL CORE_RELEASE=master matrix: - exclude: - - php: 5.4 + include: + - php: 5.3 env: DB=PGSQL CORE_RELEASE=master + - php: 5.3 + env: DB=SQLITE CORE_RELEASE=master - php: 5.4 - env: DB=SQLITE3 CORE_RELEASE=master - - php: 5.4 - env: PHPCS=1 CORE_RELEASE=master + env: DB=MYSQL CORE_RELEASE=master + - php: 5.5 + env: DB=MYSQL CORE_RELEASE=master allow_failures: - - env: DB=PGSQL CORE_RELEASE=master - - env: DB=SQLITE3 CORE_RELEASE=master - - env: PHPCS=1 CORE_RELEASE=master + - php: 5.5 + env: DB=MYSQL CORE_RELEASE=master before_script: - git clone git://github.com/silverstripe-labs/silverstripe-travis-support.git ~/travis-support diff --git a/code/controllers/AssetAdmin.php b/code/controllers/AssetAdmin.php index c5453026..24ec3ec6 100644 --- a/code/controllers/AssetAdmin.php +++ b/code/controllers/AssetAdmin.php @@ -28,6 +28,7 @@ class AssetAdmin extends LeftAndMain implements PermissionProvider{ 'delete', 'AddForm', 'DeleteItemsForm', + 'SearchForm', 'getsubtree', 'movemarked', 'removefile', @@ -395,7 +396,7 @@ JS public function AddForm() { $folder = singleton('Folder'); - $form = new Form( + $form = CMSForm::create( $this, 'AddForm', new FieldList( @@ -407,7 +408,8 @@ JS ->addExtraClass('ss-ui-action-constructive')->setAttribute('data-icon', 'accept') ->setTitle(_t('AssetAdmin.ActionAdd', 'Add folder')) ) - ); + )->setHTMLID('Form_AddForm'); + $form->setResponseNegotiator($this->getResponseNegotiator()); $form->setTemplate($this->getTemplatesWithSuffix('_EditForm')); // TODO Can't merge $FormAttributes in template at the moment $form->addExtraClass('add-form cms-add-form cms-edit-form cms-panel-padded center ' . $this->BaseCSSClasses()); diff --git a/code/controllers/CMSFileAddController.php b/code/controllers/CMSFileAddController.php index 6c41820a..ef6d1e40 100644 --- a/code/controllers/CMSFileAddController.php +++ b/code/controllers/CMSFileAddController.php @@ -76,15 +76,16 @@ class CMSFileAddController extends LeftAndMain { asort($exts); $uploadField->Extensions = implode(', ', $exts); - $form = new Form( + $form = CMSForm::create( $this, - 'getEditForm', + 'EditForm', new FieldList( $uploadField, new HiddenField('ID') ), new FieldList() - ); + )->setHTMLID('Form_EditForm'); + $form->setResponseNegotiator($this->getResponseNegotiator()); $form->addExtraClass('center cms-edit-form ' . $this->BaseCSSClasses()); // Don't use AssetAdmin_EditForm, as it assumes a different panel structure $form->setTemplate($this->getTemplatesWithSuffix('_EditForm')); diff --git a/code/controllers/CMSMain.php b/code/controllers/CMSMain.php index 87d7358a..c7ae441c 100644 --- a/code/controllers/CMSMain.php +++ b/code/controllers/CMSMain.php @@ -663,7 +663,10 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr $validator = new RequiredFields(); } - $form = new Form($this, "EditForm", $fields, $actions, $validator); + $form = CMSForm::create( + $this, "EditForm", $fields, $actions, $validator + )->setHTMLID('Form_EditForm'); + $form->setResponseNegotiator($this->getResponseNegotiator()); $form->loadDataFrom($record); $form->disableDefaultAction(); $form->addExtraClass('cms-edit-form'); @@ -686,9 +689,11 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr $this->extend('updateEditForm', $form); return $form; } else if($id) { - return new Form($this, "EditForm", new FieldList( + $form = CMSForm::create( $this, "EditForm", new FieldList( new LabelField('PageDoesntExistLabel',_t('CMSMain.PAGENOTEXISTS',"This page doesn't exist"))), new FieldList() - ); + )->setHTMLID('Form_EditForm'); + $form->setResponseNegotiator($this->getResponseNegotiator()); + return $form; } } @@ -788,13 +793,14 @@ class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionPr } )); - $listview = new Form( + $listview = CMSForm::create( $this, 'ListViewForm', new FieldList($gridField), new FieldList() - ); + )->setHTMLID('Form_ListViewForm'); $listview->setAttribute('data-pjax-fragment', 'ListViewForm'); + $listview->setResponseNegotiator($this->getResponseNegotiator()); $this->extend('updateListView', $listview); diff --git a/code/controllers/CMSPageAddController.php b/code/controllers/CMSPageAddController.php index 3824b661..06f5ae48 100644 --- a/code/controllers/CMSPageAddController.php +++ b/code/controllers/CMSPageAddController.php @@ -106,7 +106,10 @@ class CMSPageAddController extends CMSPageEditController { $this->extend('updatePageOptions', $fields); - $form = new Form($this, "AddForm", $fields, $actions); + $form = CMSForm::create( + $this, "AddForm", $fields, $actions + )->setHTMLID('Form_AddForm'); + $form->setResponseNegotiator($this->getResponseNegotiator()); $form->addExtraClass('cms-add-form stacked cms-content center cms-edit-form ' . $this->BaseCSSClasses()); $form->setTemplate($this->getTemplatesWithSuffix('_EditForm')); diff --git a/code/controllers/CMSPageHistoryController.php b/code/controllers/CMSPageHistoryController.php index 9444f141..71de9a8e 100644 --- a/code/controllers/CMSPageHistoryController.php +++ b/code/controllers/CMSPageHistoryController.php @@ -251,13 +251,13 @@ class CMSPageHistoryController extends CMSMain { // Use