tonyair/silverstripe-cms
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-cms synced 2024-10-22 06:05:56 +00:00
Code Issues Projects Releases Wiki Activity

Optimization for SiteTree::allowedChildren()

Browse Source 
Adds an `Object::extend('updateAllowedChildren')` whilst also
  caching the default response

Using `get_class($this)` as cache key as this is what is used
  in `Configurable::stat($name)` to retrieve the candidates
This commit is contained in:
Lee Bradley 2017-02-14 13:48:48 +00:00 committed by Damian Mooyman
parent bd86251043
commit 0570df95a8
1 changed files with 33 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
code/Model/SiteTree.php
View File

@ -2467,8 +2467,8 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
public function allowedChildren() public function allowedChildren()
{ {
if (isset(static::$_allowedChildren[$this->ClassName])) { if (isset(static::$_allowedChildren[$this->ClassName])) {
return static::$_allowedChildren[$this->ClassName]; $allowedChildren = static::$_allowedChildren[$this->ClassName];
} } else {
// Get config based on old FIRST_SET rules // Get config based on old FIRST_SET rules
$candidates = null; $candidates = null;
$class = get_class($this); $class = get_class($this);
@ -2498,9 +2498,12 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
$allowedChildren[] = $subclass; $allowedChildren[] = $subclass;
} }
} }
static::$_allowedChildren[get_class($this)] = $allowedChildren;
} }
}
$this->extend('updateAllowedChildren', $allowedChildren);
return static::$_allowedChildren[$this->ClassName] = $allowedChildren; return $allowedChildren;
} }
/** /**