From 2c4ebd3cb9527a578ecd1ccba604e2d762381383 Mon Sep 17 00:00:00 2001 From: Sean Harvey Date: Sun, 23 Sep 2012 22:49:44 +1200 Subject: [PATCH 1/3] Fixing broken SiteTreeHTMLEditorFieldTest --- tests/model/SiteTreeHTMLEditorFieldTest.php | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tests/model/SiteTreeHTMLEditorFieldTest.php b/tests/model/SiteTreeHTMLEditorFieldTest.php index 6e3eb5f3..1df60d53 100644 --- a/tests/model/SiteTreeHTMLEditorFieldTest.php +++ b/tests/model/SiteTreeHTMLEditorFieldTest.php @@ -53,16 +53,18 @@ class SiteTreeHtmlEditorFieldTest extends FunctionalTest { $editor->setValue(''); $editor->saveInto($sitetree); - $xml = new SimpleXMLElement($sitetree->Content); - $this->assertNotNull($xml['alt'], 'Alt tags are added by default.'); - $this->assertNotNull($xml['title'], 'Title tags are added by default.'); + $parser = new CSSContentParser($sitetree->Content); + $xml = $parser->getByXpath('//img'); + $this->assertEquals('', $xml[0]['alt'], 'Alt tags are added by default.'); + $this->assertEquals('', $xml[0]['title'], 'Title tags are added by default.'); - $editor->setValue('foo'); - $editor->saveInto($sitetree); + $editor->setValue('foo'); + $editor->saveInto($sitetree); - $xml = new SimpleXMLElement($sitetree->Content); - $this->assertNotNull('foo', $xml['alt'], 'Alt tags are preserved.'); - $this->assertNotNull('bar', $xml['title'], 'Title tags are preserved.'); + $parser = new CSSContentParser($sitetree->Content); + $xml = $parser->getByXpath('//img'); + $this->assertEquals('foo', $xml[0]['alt'], 'Alt tags are preserved.'); + $this->assertEquals('bar', $xml[0]['title'], 'Title tags are preserved.'); } public function testImageTracking() { From 548ec241a97ad18ddbc7c0dbd77f7f66dc2625e7 Mon Sep 17 00:00:00 2001 From: Sean Harvey Date: Mon, 24 Sep 2012 15:14:38 +1200 Subject: [PATCH 2/3] BUG Fixing "public function" not allowed in SilverStripeNavigator.js --- javascript/SilverStripeNavigator.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/SilverStripeNavigator.js b/javascript/SilverStripeNavigator.js index 133a339b..f57a78b0 100644 --- a/javascript/SilverStripeNavigator.js +++ b/javascript/SilverStripeNavigator.js @@ -1,4 +1,4 @@ -public function windowName(suffix) { +function windowName(suffix) { var base = document.getElementsByTagName('base')[0].href.replace('http://','').replace(/\//g,'_').replace(/\./g,'_'); return base + suffix; } From 345dbc8a4fa38affc6cc4cc662a58ec01290f5dc Mon Sep 17 00:00:00 2001 From: Sean Harvey Date: Tue, 25 Sep 2012 15:31:42 +1200 Subject: [PATCH 3/3] BUG Fixing broken links "admin/show", should be "admin/pages..." --- code/model/SiteTree.php | 8 ++++---- tasks/RemoveOrphanedPagesTask.php | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/code/model/SiteTree.php b/code/model/SiteTree.php index a54bf141..0ea23c4e 100644 --- a/code/model/SiteTree.php +++ b/code/model/SiteTree.php @@ -1771,9 +1771,9 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid $parentPage = $linkedPage->Parent; if($parentPage) { if($parentPage->ID) { - $parentPageLinks[] = "ID\">{$parentPage->Title}"; + $parentPageLinks[] = "ID\">{$parentPage->Title}"; } else { - $parentPageLinks[] = "ID\">" . + $parentPageLinks[] = "ID\">" . _t('SiteTree.TOPLEVEL', 'Site Content (Top Level)') . ""; } @@ -1821,7 +1821,7 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid ); $dependentTable->getConfig()->getComponentByType('GridFieldDataColumns') ->setFieldFormatting(array( - 'Title' => '$Title', + 'Title' => '$Title', 'AbsoluteLink' => '$value', )); } @@ -2747,4 +2747,4 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid self::$cache_permissions = array(); } -} \ No newline at end of file +} diff --git a/tasks/RemoveOrphanedPagesTask.php b/tasks/RemoveOrphanedPagesTask.php index d2aeaaf5..35fa534a 100644 --- a/tasks/RemoveOrphanedPagesTask.php +++ b/tasks/RemoveOrphanedPagesTask.php @@ -102,7 +102,7 @@ in the other stage:
) ); $label = sprintf( - '%s (#%d, Last Modified Date: %s, Last Modifier: %s, %s)', + '%s (#%d, Last Modified Date: %s, Last Modifier: %s, %s)', $orphan->ID, $orphan->Title, $orphan->ID,