tonyair/silverstripe-behat-extension
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-behat-extension synced 2024-10-22 17:05:32 +02:00
Code Issues Projects Releases Wiki Activity

FIX: Don't load suite twice.

Browse Source 
If the suite is already loaded, you can't call registerSuiteConfiguration
a second time.
This commit is contained in:
Sam Minnee 2017-05-05 10:12:23 +12:00
parent 7fd508b9af
commit 9b48a30e2b
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Controllers/ModuleSuiteLocator.php
View File

@ -101,24 +101,16 @@ class ModuleSuiteLocator implements Controller
// Suite name always omits vendor // Suite name always omits vendor
$suiteName = $module->getShortName(); $suiteName = $module->getShortName();
// If suite is already configured in the root, switch to it and return // Suite doesn't exist, so load dynamically from nested `behat.yml`
if (isset($this->suiteConfigurations[$suiteName])) { if (!isset($this->suiteConfigurations[$suiteName])) {
$config = $this->suiteConfigurations[$suiteName]; $config = $this->loadSuiteConfiguration($suiteName, $module);
$this->registry->registerSuiteConfiguration( $this->registry->registerSuiteConfiguration(
$suiteName, $suiteName,
$config['type'], $config['type'],
$config['settings'] $config['settings']
); );
return null;
} }
// Suite doesn't exist, so load dynamically from nested `behat.yml`
$config = $this->loadSuiteConfiguration($suiteName, $module);
$this->registry->registerSuiteConfiguration(
$suiteName,
$config['type'],
$config['settings']
);
return null; return null;
} }