tonyair/silverstripe-behat-extension
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-behat-extension synced 2024-06-16 17:51:49 +02:00
Code Issues Projects Releases Wiki Activity

FIX logic error where a variable is used for two purposes

Browse Source 
The issue that prompted this change was that at line 361, if an exception needed to be thrown, it would be thrown with $field being a NodeElement rather than a string, causing a Catchable Fatal Error to be thrown in ElementNotFoundException::__construct#46 (can't convert object of type NodeElement to string).
This commit is contained in:
Igor 2015-08-24 14:27:56 +12:00
parent 7f370df19b
commit 2ff6ddeaaa
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/SilverStripe/BehatExtension/Context/SilverStripeContext.php
View File

@ -351,9 +351,9 @@ class SilverStripeContext extends MinkContext implements SilverStripeAwareContex
$fields = $this->getSession()->getPage()->findAll('named', array(
'field', $this->getSession()->getSelectorsHandler()->xpathLiteral($field)
));
if($fields) foreach($fields as $field) {
if($field->isVisible()) {
$field->setValue($value);
if($fields) foreach($fields as $f) {
if($f->isVisible()) {
$f->setValue($value);
return;
}
}