tonyair/recipe-plugin
1
0
Fork 0
mirror of https://github.com/silverstripe/recipe-plugin.git synced 2024-10-22 14:05:55 +02:00
Code Issues Projects Releases Wiki Activity

FIX Only write composer.json if there are changes (#21)

Browse Source 
FIX Only write composer.json if there are changes
This commit is contained in:
Andrew Paxley 2022-05-10 09:40:14 +12:00 committed by GitHub
parent 8a77da94d1
commit 301daf2437
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/RecipeInstaller.php
View File

@ -16,6 +16,10 @@ use RegexIterator;
class RecipeInstaller extends LibraryInstaller class RecipeInstaller extends LibraryInstaller
{ {
/**
* @var bool
*/
private $hasWrittenFiles = false;
public function __construct(IOInterface $io, Composer $composer) public function __construct(IOInterface $io, Composer $composer)
{ {
@ -67,13 +71,15 @@ class RecipeInstaller extends LibraryInstaller
} }
// If any files are written, modify composer.json with newly installed files // If any files are written, modify composer.json with newly installed files
if ($installedFiles) { if ($this->hasWrittenFiles) {
sort($installedFiles); sort($installedFiles);
if (!isset($composerData['extra'])) { if (!isset($composerData['extra'])) {
$composerData['extra'] = []; $composerData['extra'] = [];
} }
$composerData['extra'][$registrationKey] = $installedFiles; $composerData['extra'][$registrationKey] = $installedFiles;
$composerFile->write($composerData); $composerFile->write($composerData);
// Reset the variable so that we can try this trick again later
$this->hasWrittenFiles = false;
} }
} }
@ -115,6 +121,7 @@ class RecipeInstaller extends LibraryInstaller
$this->io->write(" - Copying <info>$relativePath</info>"); $this->io->write(" - Copying <info>$relativePath</info>");
$this->filesystem->ensureDirectoryExists(dirname($destination ?? '')); $this->filesystem->ensureDirectoryExists(dirname($destination ?? ''));
copy($sourcePath ?? '', $destination ?? ''); copy($sourcePath ?? '', $destination ?? '');
$this->hasWrittenFiles = true;
} }
return $relativePath; return $relativePath;
} }