Compare commits

...

2 Commits

Author SHA1 Message Date
Guy Sartorelli
734090af68
Merge pull request #271 from pschiffe/3.1
FIX `HTTPBulkToolsResponse.addSuccessRecords()` fn
2024-03-08 14:13:00 +13:00
Peter Schiffer
379fda091b
FIX HTTPBulkToolsResponse.addSuccessRecords() fn
This function was trying to merge 2 arrays with PHP fn `array_push()`
which was failing if the second parameter was array as well. This fix
replaces `array_push()` with `array_merge()` fn.

Resolves #187
2024-03-04 15:01:35 +01:00

View File

@ -197,7 +197,7 @@ class HTTPBulkToolsResponse extends HTTPResponse
*/ */
public function addSuccessRecords(SS_List $records) public function addSuccessRecords(SS_List $records)
{ {
array_push($this->successRecords, $records->toArray()); $this->successRecords = array_merge($this->successRecords, $records->toArray());
return $this; return $this;
} }