From fe8e41aa405145747d2bb92888661d3cc742255c Mon Sep 17 00:00:00 2001
From: colymba <thierry@colymba.com>
Date: Wed, 8 Aug 2012 00:02:13 +0300
Subject: [PATCH] cleaning up the code

---
 _config.php                               |  2 +-
 code/GridFieldBulkEditingTools.php        |  4 +-
 code/GridFieldBulkImageUpload_Request.php | 65 ++---------------------
 3 files changed, 7 insertions(+), 64 deletions(-)

diff --git a/_config.php b/_config.php
index 8847aef..784962a 100644
--- a/_config.php
+++ b/_config.php
@@ -1,5 +1,5 @@
 <?php
-
+//define global path to Components' root folder
 if(!defined('BULK_EDIT_TOOLS_PATH'))
 {
 	define('BULK_EDIT_TOOLS_PATH', rtrim(basename(dirname(__FILE__))));
diff --git a/code/GridFieldBulkEditingTools.php b/code/GridFieldBulkEditingTools.php
index bd24cbb..e6eeb07 100644
--- a/code/GridFieldBulkEditingTools.php
+++ b/code/GridFieldBulkEditingTools.php
@@ -1,6 +1,7 @@
 <?php
 /**
- * 
+ * Base Component for all 'GridFieldBulkEditingTools'
+ * defines the common HTML fragment
  *
  * @author colymba
  * @package GridFieldBulkEditingTools
@@ -12,7 +13,6 @@ class GridFieldBulkEditingTools implements GridField_HTMLProvider
 			Requirements::css(BULK_EDIT_TOOLS_PATH . '/css/GridFieldBulkEditingTools.css');
 			
 			return array(
-					//"footer" => '<tr><td colspan="'.$columnsCount.'">\$DefineFragment(bulk-edit-tools)</td></tr>'
 					"after" => "<div id=\"bulkEditTools\">\$DefineFragment(bulk-edit-tools)</div>"
 			);
     }
diff --git a/code/GridFieldBulkImageUpload_Request.php b/code/GridFieldBulkImageUpload_Request.php
index f9397f7..9711337 100644
--- a/code/GridFieldBulkImageUpload_Request.php
+++ b/code/GridFieldBulkImageUpload_Request.php
@@ -41,8 +41,7 @@ class GridFieldBulkImageUpload_Request extends RequestHandler {
 	 *
 	 */
 	static $url_handlers = array(
-		'$Action!' => '$Action'/*,
-		'' => 'uploadForm'*/
+		'$Action!' => '$Action'
 	);
 	
 	/**
@@ -121,53 +120,10 @@ class GridFieldBulkImageUpload_Request extends RequestHandler {
 	}
 	
 	/**
-	 * Return a list of the GridField managed DataObject's editable fields: (HTML)Text, (HTML)Varchar and Enum fields
-	 * 
-	 * @return array 
+	 *
+	 * @param type $recordID
+	 * @return type 
 	 */
-	/*
-	function getDefaultRecordEditableFields()
-	{
-		$recordClass = $this->gridField->list->dataClass;
-		$recordDbFields = Config::inst()->get($recordClass, 'db', Config::UNINHERITED);
-		
-		$editableFields = array();
-		foreach ( $recordDbFields as $field => $type )
-		{
-			if ( preg_match( '/(Text|Varchar|Enum)/i', $type ) > 0 ) {
-				array_push($editableFields, $field);
-			}
-		}
-		
-		return $editableFields;
-	}
-	 */
-	
-	/**
-	 * Return the CMS edit field for a given name. As set in the GridField managed DataObject getCMSFields method
-	 * 
-	 * @param string $fieldName
-	 * @return FormField 
-	 */
-	/*
-	function getFieldEditForm($fieldName)
-	{		
-		if ( !$this->recordCMSFieldList ) {
-			$recordClass = $this->gridField->list->dataClass;
-			$this->recordCMSFieldList = singleton($recordClass)->getCMSFields();
-		}		
-		
-		$field = $this->recordCMSFieldList->fieldByName($fieldName);
-				
-		if ( !$field ) {
-			$fields = $this->recordCMSFieldList->dataFields();
-			$field = $fields[$fieldName];
-		}
-		
-		return $field;
-	}
-	*/
-	
 	function getRecordHTMLFormFields( $recordID = 0 )
 	{
 		$config = $this->component->getConfig();
@@ -336,19 +292,6 @@ class GridFieldBulkImageUpload_Request extends RequestHandler {
 					//get record's CMS Fields
 					$recordEditableFormFields = $this->getRecordHTMLFormFields( $record->ID );
 					
-					
-					// collect all editable fields forms	
-					/*
-					$recordEditableFieldsForms = array();
-					foreach ( $this->getRecordEditableFields() as $editableFieldName )
-					{
-						$formField = $this->getFieldEditForm($editableFieldName);
-						if ( $formField ) {
-							array_push($recordEditableFieldsForms, $this->parseFieldHTMLWithRecordID($formField->FieldHolder(), $record->ID) );
-						}						
-					}
-					*/
-					
 					// Collect all output data.
 					$return = array_merge($return, array(
 						'id' => $file->ID,