From 911fc4a0f0e1fd9feb44ffcc1dc9a27562ff09ea Mon Sep 17 00:00:00 2001 From: Jamie Howarth Date: Fri, 10 Dec 2021 23:08:20 +0000 Subject: [PATCH 1/3] Added support for Tweetdeck --- extension/background.ts | 1 + extension/content.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/extension/background.ts b/extension/background.ts index 743efe4..32621e8 100644 --- a/extension/background.ts +++ b/extension/background.ts @@ -272,6 +272,7 @@ const badIdentifiersArray = [ 'tmblr.co', 'tumblr.com', 'twitch.tv=SN', + 'tweetdeck.twitter.com', 'twitter.com', 'twitter.com/explore', 'twitter.com/hashtag', diff --git a/extension/content.ts b/extension/content.ts index 0f86d82..7cbf62b 100644 --- a/extension/content.ts +++ b/extension/content.ts @@ -4,7 +4,7 @@ var hostname = typeof (location) != 'undefined' ? location.hostname : ''; if (hostname.startsWith('www.')) { hostname = hostname.substring(4); } -if (hostname == 'mobile.twitter.com') hostname = 'twitter.com'; +if (hostname == 'mobile.twitter.com' || hostname == 'tweetdeck.twitter.com') hostname = 'twitter.com'; if (hostname.endsWith('.reddit.com')) hostname = 'reddit.com'; if (hostname.endsWith('.facebook.com')) hostname = 'facebook.com'; if (hostname.endsWith('.youtube.com')) hostname = 'youtube.com'; From c4f554cb2004c82507b825151cdc38563e15f8d3 Mon Sep 17 00:00:00 2001 From: Jamie Howarth Date: Fri, 10 Dec 2021 23:47:30 +0000 Subject: [PATCH 2/3] Added some quick instructions for contributors to compile & test locally --- CONTRIBUTING.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..5c31e86 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,19 @@ +# CONTRIBUTING + +## Prerequisites + +* Node.js +* Typescript (`npm i -g typescript`) + +## Compiling + +* Run `tsc` in the `extension` directory, or `tsc --watch` for auto-compilation when you make changes to the codebase + +## Testing + +These instructions are for Chromium-based browsers only (Chrome, Edge, Brave, Vivaldi, etc.), instructions for Firefox would be appreciated. Make sure to hawe compiled your code first. If using live reloading using `--watch`, you will *still* have to manually reload the extension in the Extensions window for any changes to be picked up by the browser. + +* Open [chrome://extensions](chrome://extensions) +* Enable "Developer mode" +* Click "load unpacked" +* Select the `extension` directory From d83ea7e454881b55082cb4e893b3a070315a470c Mon Sep 17 00:00:00 2001 From: Jamie Howarth Date: Fri, 10 Dec 2021 23:48:10 +0000 Subject: [PATCH 3/3] Damnit typo --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5c31e86..4a061df 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,7 +11,7 @@ ## Testing -These instructions are for Chromium-based browsers only (Chrome, Edge, Brave, Vivaldi, etc.), instructions for Firefox would be appreciated. Make sure to hawe compiled your code first. If using live reloading using `--watch`, you will *still* have to manually reload the extension in the Extensions window for any changes to be picked up by the browser. +These instructions are for Chromium-based browsers only (Chrome, Edge, Brave, Vivaldi, etc.), instructions for Firefox would be appreciated. Make sure to have compiled your code first. If using live reloading using `--watch`, you will *still* have to manually reload the extension in the Extensions window for any changes to be picked up by the browser. * Open [chrome://extensions](chrome://extensions) * Enable "Developer mode"