diff --git a/test/parser/README.markdown b/test/parser/README.markdown new file mode 100644 index 00000000..c8f03015 --- /dev/null +++ b/test/parser/README.markdown @@ -0,0 +1,33 @@ +Parsing +------- + +Some sanity is emerging in the testing of parsers + (Parsers are fiddly in respect to space and order, small changes may and do have unexpected effects) + +Parsing is a two step process with parslet: + - parse takes an input and outputs hashes/arrays with basic types + - tramsform takes the output of parse and generates an ast (as specified by the transformation) + +A test tests both phases seperately and again together. +Each test must thus specify (as instance variables): +- the string input +- the parse output +- the transform output + + +For any functionality that we want to work (ie test), there are actually three tests, with the _same_ name +One in each of the parser/transform/ast classes +Parser test that the parser parses and thet the output is correct. Rules are named and and boil down to + hashes and arrays with lots of symbols for the names the rules (actually the reults) were given +Transform test really just test the tranformation. They basically take the output of the parse + and check that correct Ast classes are produced +Ast tests both steps in one. Ie string input to ast classes output + +All threee classes are layed out quite similarly in that they use a check method and +each test assigns @input and @expected which the check methods then checks +The check methods have a pust in it (to be left) which is very handy for checking +also the output of parser.check can actually be used as the input of transform + +Repeat: For every test in parser, there should be one in transform and ast + The test in transform should use the output of parser as input + The test in ast should expect the same result as transform diff --git a/test/parser/helper.rb b/test/parser/helper.rb new file mode 100644 index 00000000..3cc8f1ca --- /dev/null +++ b/test/parser/helper.rb @@ -0,0 +1,29 @@ +require_relative "../helper" + +module ParserTest + + def setup + @parser = Parser::Composed.new + @transform = Parser::Transform.new + end + + def check_parse + is = @parser.parse(@input) + #puts is.inspect + assert_equal @expected , is + end + + def check_transform + is = @transform.apply @input + #puts is.transform + assert_equal @expected , is + end + + def check_ast + syntax = @parser.parse(@input) + tree = @transform.apply(syntax) + # puts tree.inspect + assert_equal @expected , tree + end + +end \ No newline at end of file diff --git a/test/test_ast.rb b/test/test_ast.rb index c01c3708..5bfda4fd 100644 --- a/test/test_ast.rb +++ b/test/test_ast.rb @@ -15,19 +15,19 @@ class TestAst < MiniTest::Test syntax = @parser.parse(@input) tree = @transform.apply(syntax) # puts tree.inspect - assert_equal @expected , tree + assert_equal @transform_output , tree end def test_number @input = '42 ' - @expected = Parser::IntegerExpression.new(42) + @transform_output = Parser::IntegerExpression.new(42) @parser = @parser.integer check end def test_name @input = 'foo ' - @expected = Parser::NameExpression.new('foo') + @transform_output = Parser::NameExpression.new('foo') @parser = @parser.name check end @@ -36,21 +36,21 @@ class TestAst < MiniTest::Test @input = < Parser::IntegerExpression.new(42) } + @transform_output = { :argument_list => Parser::IntegerExpression.new(42) } @parser = @parser.argument_list check end def test_argument_list @input = '(42, foo)' - @expected = [Parser::IntegerExpression.new(42), + @transform_output = [Parser::IntegerExpression.new(42), Parser::NameExpression.new('foo')] @parser = @parser.argument_list check @@ -58,7 +58,7 @@ HERE def test_function_call @input = 'baz(42, foo)' - @expected = Parser::FuncallExpression.new 'baz', [Parser::IntegerExpression.new(42), + @transform_output = Parser::FuncallExpression.new 'baz', [Parser::IntegerExpression.new(42), Parser::NameExpression.new('foo')] @parser = @parser.function_call @@ -71,7 +71,7 @@ HERE 5 else HERE - @expected = {:expressions=>[ Parser::IntegerExpression.new(4), Parser::IntegerExpression.new(5)]} + @transform_output = {:expressions=>[ Parser::IntegerExpression.new(4), Parser::IntegerExpression.new(5)]} @parser = @parser.expressions_else check @@ -84,7 +84,7 @@ name call(4,6) end HERE - @expected = {:expressions=> [Parser::IntegerExpression.new(5), Parser::NameExpression.new("name"), + @transform_output = {:expressions=> [Parser::IntegerExpression.new(5), Parser::NameExpression.new("name"), Parser::FuncallExpression.new("call", [Parser::IntegerExpression.new(4), Parser::IntegerExpression.new(6) ]) ] } @parser = @parser.expressions_end check @@ -98,7 +98,7 @@ else 667 end HERE - @expected = Parser::ConditionalExpression.new( Parser::IntegerExpression.new(0), + @transform_output = Parser::ConditionalExpression.new( Parser::IntegerExpression.new(0), [Parser::IntegerExpression.new(42)], [Parser::IntegerExpression.new(667)]) @parser = @parser.conditional @@ -111,7 +111,7 @@ def foo(x) 5 end HERE - @expected = Parser::FunctionExpression.new('foo', + @transform_output = Parser::FunctionExpression.new('foo', [Parser::NameExpression.new('x')], [Parser::IntegerExpression.new(5)]) @parser = @parser.function_definition @@ -123,7 +123,7 @@ def foo(x) abba = 5 end HERE - @expected = Parser::FunctionExpression.new( "foo", [Parser::NameExpression.new("x")], + @transform_output = Parser::FunctionExpression.new( "foo", [Parser::NameExpression.new("x")], [Parser::AssignmentExpression.new( "abba", Parser::IntegerExpression.new(5) ) ]) check end diff --git a/test/test_parser.rb b/test/test_parser.rb index c5ec0dea..ed4f51dc 100644 --- a/test/test_parser.rb +++ b/test/test_parser.rb @@ -12,7 +12,7 @@ require_relative 'helper' # Ast tests both steps in one. Ie string input to ast classes output # All threee classes are layed out quite similarly in that they use a check method and -# each test assigns @input and @expected which the check methods then checks +# each test assigns @input and @parse_output which the check methods then checks # The check methods have a pust in it (to be left) which is very handy for checking # also the output of parser.check can actually be used as the input of transform @@ -29,18 +29,18 @@ class ParserTest < MiniTest::Test def check is = @parser.parse(@input) #puts is.inspect - assert_equal @expected , is + assert_equal @parse_output , is end def test_number @input = '42 ' - @expected = {:integer => '42'} + @parse_output = {:integer => '42'} @parser = @parser.integer check end def test_name @input = 'foo ' - @expected = {:name => 'foo'} + @parse_output = {:name => 'foo'} @parser = @parser.name check end @@ -49,21 +49,21 @@ class ParserTest < MiniTest::Test @input = <"hello"} + @parse_output = {:string=>"hello"} @parser = @parser.string check end def test_one_argument @input = '(42)' - @expected = {:argument_list => {:argument => {:integer => '42'}} } + @parse_output = {:argument_list => {:argument => {:integer => '42'}} } @parser = @parser.argument_list check end def test_argument_list @input = '(42, foo)' - @expected = {:argument_list => [{:argument => {:integer => '42'}}, + @parse_output = {:argument_list => [{:argument => {:integer => '42'}}, {:argument => {:name => 'foo'}}]} @parser = @parser.argument_list check @@ -71,7 +71,7 @@ HERE def test_function_call @input = 'baz(42, foo)' - @expected = {:function_call => {:name => 'baz' }, + @parse_output = {:function_call => {:name => 'baz' }, :argument_list => [{:argument => {:integer => '42'}}, {:argument => {:name => 'foo'}}]} @@ -83,7 +83,7 @@ HERE @input = < {:name => 'baz' }, + @parse_output = {:function_call => {:name => 'baz' }, :argument_list => [{:argument => {:integer => '42'}}, {:argument => {:name => 'foo'}}]} @@ -97,7 +97,7 @@ HERE 5 else HERE - @expected = {:expressions=>[{:integer=>"4"}, {:integer=>"5"}]} + @parse_output = {:expressions=>[{:integer=>"4"}, {:integer=>"5"}]} @parser = @parser.expressions_else check @@ -110,7 +110,7 @@ name call(4,6) end HERE - @expected = {:expressions => [ { :integer => "5" }, + @parse_output = {:expressions => [ { :integer => "5" }, { :name => "name" }, { :function_call => { :name => "call" } , :argument_list => [ {:argument => { :integer => "4" } } , @@ -127,7 +127,7 @@ else 667 end HERE - @expected = { :conditional => { :integer => "0"}, + @parse_output = { :conditional => { :integer => "0"}, :if_true => { :expressions => [ { :integer => "42" } ] } , :if_false => { :expressions => [ { :integer => "667" } ] } } @parser = @parser.conditional @@ -140,7 +140,7 @@ def foo(x) 5 end HERE - @expected = {:function_definition => {:name => 'foo'}, + @parse_output = {:function_definition => {:name => 'foo'}, :parmeter_list => {:parmeter => {:name => 'x'}}, :expressions => [{:integer => '5'}]} @parser = @parser.function_definition @@ -153,7 +153,7 @@ def foo(x) abba = 5 end HERE - @expected = { :function_definition => { :name => "foo" } , + @parse_output = { :function_definition => { :name => "foo" } , :parmeter_list => { :parmeter => { :name => "x" } }, :expressions => [ { :asignee => { :name => "abba" }, :asigned => { :integer => "5" } } ] } @@ -163,7 +163,7 @@ HERE def test_assignment @input = "a = 5" - @expected = { :asignee => { :name=>"a" } , :asigned => { :integer => "5" } } + @parse_output = { :asignee => { :name=>"a" } , :asigned => { :integer => "5" } } @parser = @parser.assignment check end diff --git a/test/test_transform.rb b/test/test_transform.rb index a6651d6f..2f5ec275 100644 --- a/test/test_transform.rb +++ b/test/test_transform.rb @@ -11,32 +11,31 @@ class TransformTest < MiniTest::Test def check is = @transform.apply @input #puts is.transform - assert_equal @expected , is + assert_equal @transform_output , is end def test_number @input = {:integer => '42'} - @expected = Parser::IntegerExpression.new(42) + @transform_output = Parser::IntegerExpression.new(42) check - assert_equal 42 , @expected.value + assert_equal 42 , @transform_output.value end def test_name @input = {:name => 'foo'} - @expected = Parser::NameExpression.new('foo') + @transform_output = Parser::NameExpression.new('foo') check end def test_string @input = {:string=>"hello"} - @expected = Parser::StringExpression.new('hello') - @parser = @parser.string + @transform_output = Parser::StringExpression.new('hello') check end def test_argument_list @input = {:argument_list => [{:argument => {:integer => '42'}}, {:argument => {:name => 'foo'}}]} - @expected = [Parser::IntegerExpression.new(42), + @transform_output = [Parser::IntegerExpression.new(42), Parser::NameExpression.new('foo')] check end @@ -44,7 +43,7 @@ class TransformTest < MiniTest::Test def test_single_argument @input = {:function_call => {:name => 'foo'}, :argument_list => {:argument => {:integer => '42'} } } - @expected = Parser::FuncallExpression.new 'foo', [Parser::IntegerExpression.new(42)] + @transform_output = Parser::FuncallExpression.new 'foo', [Parser::IntegerExpression.new(42)] check end @@ -53,7 +52,7 @@ class TransformTest < MiniTest::Test @input = {:function_call => {:name => 'baz'}, :argument_list => [{:argument => {:integer => '42'}}, {:argument => {:name => 'foo'}}]} - @expected = Parser::FuncallExpression.new 'baz', [Parser::IntegerExpression.new(42), + @transform_output = Parser::FuncallExpression.new 'baz', [Parser::IntegerExpression.new(42), Parser::NameExpression.new('foo')] check @@ -63,7 +62,7 @@ class TransformTest < MiniTest::Test @input = { :conditional => { :integer => "0"}, :if_true => { :expressions => [ { :integer => "42" } ] } , :if_false => { :expressions => [ { :integer => "667" } ] } } - @expected = Parser::ConditionalExpression.new( Parser::IntegerExpression.new(0), + @transform_output = Parser::ConditionalExpression.new( Parser::IntegerExpression.new(0), [Parser::IntegerExpression.new(42)], [Parser::IntegerExpression.new(667)]) check @@ -71,12 +70,12 @@ class TransformTest < MiniTest::Test def test_parmeter @input = {:parmeter => { :name => "foo"}} - @expected = Parser::NameExpression.new('foo') + @transform_output = Parser::NameExpression.new('foo') check end def test_parmeter_list @input = {:parmeter_list => [{:parmeter => { :name => "foo"}}]} - @expected = [Parser::NameExpression.new('foo')] + @transform_output = [Parser::NameExpression.new('foo')] check end @@ -84,7 +83,7 @@ class TransformTest < MiniTest::Test @input = {:function_definition => {:name => 'foo'}, :parmeter_list => {:parmeter => {:name => 'x'}}, :expressions => [{:integer => '5'}]} - @expected = Parser::FunctionExpression.new('foo', + @transform_output = Parser::FunctionExpression.new('foo', [Parser::NameExpression.new('x')], [Parser::IntegerExpression.new(5)]) check @@ -95,14 +94,14 @@ class TransformTest < MiniTest::Test :parmeter_list => { :parmeter => { :name => "x" } }, :expressions => [ { :asignee => { :name => "abba" }, :asigned => { :integer => "5" } } ] } - @expected = Parser::FunctionExpression.new( "foo", [Parser::NameExpression.new("x")], + @transform_output = Parser::FunctionExpression.new( "foo", [Parser::NameExpression.new("x")], [Parser::AssignmentExpression.new( "abba", Parser::IntegerExpression.new(5) ) ]) check end def test_assignment @input = { :asignee => { :name=>"a" } , :asigned => { :integer => "5" } } - @expected = Parser::AssignmentExpression.new("a", Parser::IntegerExpression.new(5) ) + @transform_output = Parser::AssignmentExpression.new("a", Parser::IntegerExpression.new(5) ) check end end