Commit Graph

664 Commits

Author SHA1 Message Date
bakkeby
954e60b735 Adding proposed view history patch ref. #327 2023-01-18 21:58:32 +01:00
bakkeby
40e2cac4e9 pertag: simplifying implementation by removing prevtag 2023-01-18 21:18:14 +01:00
bakkeby
6c822cbfce emptyview: initialising arrays to 0 is redundant 2023-01-18 21:01:35 +01:00
bakkeby
6b7246cb90 zoomswap: proposed changes to ensure that previous zooms references are cleared when unmanaging a client ref. #324 2023-01-13 16:19:33 +01:00
bakkeby
2a8e68c5df Correcting path to /usr/local/share/xsessions/ ref. #317 2023-01-08 10:22:37 +01:00
bakkeby
3b72e139ec Revert "Hardcoding xsessions directory to /usr/share/xsessions as suggested in #317"
This reverts commit f0ad1117ba.
2023-01-08 10:20:34 +01:00
bakkeby
f0ad1117ba Hardcoding xsessions directory to /usr/share/xsessions as suggested in #317 2023-01-06 08:43:55 +01:00
bakkeby
668e18fddf seamless restart: Fix positioning of hidden scratchpad windows following restart ref. #315 2022-12-14 17:56:50 +01:00
bakkeby
4c32f6f52d Bump to 89f9905.
grabkeys: Avoid missing events when a keysym maps to multiple keycodes

It's not uncommon for one keysym to map to multiple keycodes. For
example, the "play" button on my keyboard sends keycode 172, but my
bluetooth headphones send keycode 208, both of which map back to
XF86AudioPlay:

    % xmodmap -pke | grep XF86AudioPlay
    keycode 172 = XF86AudioPlay XF86AudioPause XF86AudioPlay XF86AudioPause
    keycode 208 = XF86AudioPlay NoSymbol XF86AudioPlay
    keycode 215 = XF86AudioPlay NoSymbol XF86AudioPlay

This is a problem because the current code only grabs a single one of
these keycodes, which means that events for any other keycode also
mapping to the bound keysym will not be handled by dwm. In my case, this
means that binding XF86AudioPlay does the right thing and correctly
handles my keyboard's keys, but does nothing on my headphones. I'm not
the only person affected by this, there are other reports[0].

In order to fix this, we look at the mappings between keycodes and
keysyms at grabkeys() time and pick out all matching keycodes rather
than just the first one. The keypress() side of this doesn't need any
changes because the keycode gets converted back to a canonical keysym
before any action is taken.

0: https://github.com/cdown/dwm/issues/11

Ref.
https://git.suckless.org/dwm/commit/89f9905714c1c1b2e8b09986dfbeca15b68d8af8.html
2022-12-08 10:45:52 +01:00
bakkeby
dc4e535b25 tagpreview: make sure that tagwin is created following configure notify requests ref. #308 2022-11-15 10:31:15 +01:00
bakkeby
b4ae62d21a fakefullscreen: fix for mis-sized fullscreen applications
An example problematic situation would be to open a YouTube video
in Google Chrome and making that video fullscreen. Without this fix
the window will go into fullscreen within its tiled dimension, but
the size of the video will match that of the screen (and it will
be cropped).

With this fix the window will be resized which nudges the
application to adjust the fullscreen size accordingly.
2022-11-01 09:22:00 +01:00
bakkeby
ad56835713 Bump to ba56fe9.
Revert "Remove dmenumon variable"

This reverts commit c2b748e7931e5f28984efc236f9b1a212dbc65e8.

Revert back this change. It seems to not be an edge-case anymore since
multiple users have asked about this new behaviour now.

Ref.
https://git.suckless.org/dwm/commit/ba56fe9fea0a28d8184a727a987836a0903e2682.html
2022-10-30 10:32:43 +01:00
bakkeby
e6a74ad3ea roundedcorners: moving drawroundedcorners logic to resizeclient ref. #304 2022-10-16 21:32:01 +02:00
bakkeby
b732821f7b alttab: fixing crash when clients are on other tags 2022-10-13 12:34:09 +02:00
bakkeby
9a5378440c rounded rectangles: fullscreen compatibility fix ref. #304 2022-10-10 22:58:35 +02:00
bakkeby
cc58ad2ef4 Adding alt-tab patch ref. #303 2022-10-08 22:35:04 +02:00
bakkeby
4912e3129a Bump to 50ad171.
remove workaround for a crash with color emojis on some systems, now fixed in libXft 2.3.5

https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS

bump version to 6.4

Ref.
https://git.suckless.org/dwm/commit/970f37697358574e127019eb0ee2f5725ec05ce0.html
https://git.suckless.org/dwm/commit/50ad171eea9db5ccb36fce2592e047c3282975ff.html

Consequently the color emoji patch has been inverted into no color emoji, keeping the workaround in the code base for those that are on systems with older versions of the Xft library.
2022-10-06 14:44:11 +02:00
monosans
1ac17a4937
Add dwm.desktop file (#301) 2022-09-26 10:03:12 +02:00
bakkeby
82a127630d fullscreen: don't let the (always) center patch interfere with windows that start fullscreen 2022-09-18 20:39:31 +02:00
bakkeby
2c180b8d9c Bump to c2b748e.
Remove dmenumon variable

Reasoning: Since 2011 dmenu has been capable of working out which
monitor currently has focus in a Xinerama setup, making the use
of the -m flag more or less redundant.

This is easily demonstrated by using dmenu in any other window
manager.

There used to be a nodmenu patch that provided these changes:
https://git.suckless.org/sites/commit/ed68e3629de4ef2ca2d3f8893a79fb570b4c0cbc.html

but this was removed on the basis that it was very easy to work
out and apply manually if needed.

The proposal here is to remove this dependency from dwm. The
mechanism of the dmenumon variable could be provided via a patch
if need be.

The edge case scenario that dmenu does not handle on its own, and
the effect of removing this mechanism, is that if the user trigger
focusmon via keybindings to change focus to another monitor that
has no clients, then dmenu will open on the monitor containing the
window with input focus (or the monitor with the mouse cursor if
no windows have input focus).

If this edge case is important to cover then this can be addressed
by setting input focus to selmon->barwin in the focus function if
there is no client to give focus to (rather than giving focus back
to the root window).

Ref.
https://git.suckless.org/dwm/commit/c2b748e7931e5f28984efc236f9b1a212dbc65e8.html
2022-08-29 21:49:41 +02:00
bakkeby
88eb89ab0d Roll back const change for IPCCommands 2022-08-29 21:37:43 +02:00
bakkeby
0f36ba5408 restartsig: call XNextEvent only when there is data to be read ref. #295 2022-08-29 21:37:03 +02:00
bakkeby
90f9b2d982 Bump to 84d7322.
config.def.h: make keys and buttons const

Pretty much all other variables are declared as const when they're not
modified.

Ref.
https://git.suckless.org/dwm/commit/84d7322113c2bf023f5eaa8537fb0e72d4105046.html
2022-08-21 10:33:53 +02:00
bakkeby
b93a5de558 Expose showhideclient to external tools (fsignal, IPC) ref #287 2022-08-13 16:24:55 +02:00
bakkeby
2d34596ad0 Bump to 44adafe.
Make floating windows spawn within the monitor's window area

This is a follow-up on this thread:
https://lists.suckless.org/hackers/2208/18462.html

The orginal code had constraints such that if a window's starting
attributes (position and size) were to place the window outside of
the edges of the monitor, then the window would be moved into view
at the closest monitor edge.

There was an exception to this where if a top bar is used then the
window should not obscure the bar if present, which meant to place
the window within the window area instead.

The proposed change here makes it the general rule that floating
windows should spawn within the window area rather than within the
monitor area. This makes it simple and consistent with no
exceptions and it makes the intention of the code clear.

This has the benefit of making the behaviour consistent regardless
of whether the user is using a top bar or a bottom bar.

Additionally this will have an effect on patches that modify the
size of the window area. For example if the insets patch is used to
reserve space on the left hand side of the monitor for a dock or a
vertical bar then new floating clients will not obscure that area.

Ref.
https://git.suckless.org/dwm/commit/44adafe0069e73aa03a3829d7bb39591cd8b3f1d.html
2022-08-12 15:02:25 +02:00
bakkeby
c438eabdc2 Adding nametag patch 2022-08-12 13:47:25 +02:00
bakkeby
91cb32c3ed Bump to e0dee91.
sync code-style patch from libsl

Ref.
https://git.suckless.org/dwm/commit/e0dee911455cee739a5b05a994828f4a37a2764d.html
2022-08-08 14:41:21 +02:00
bakkeby
d6205e3e89 autostart: upgrading to dwm-autostart-20210120-cb3f58a.diff 2022-08-07 10:50:25 +02:00
bakkeby
6a0e5b884e Bump to 5e76e7e.
code-style: simplify some checks

main change here is making the `zoom()` logic saner. the rest of the
changes are just small stuff which accumulated on my local branch.

pop() must not be called with NULL. and `zoom()` achieves this, but in a
very (unnecessarily) complicated way:

if c == NULL then nexttiled() will return NULL as well, so we enter this
branch:

	if (c == nexttiled(selmon->clients))

in here the !c check fails and the function returns before calling pop()

		if (!c || !(c = nexttiled(c->next)))
			return;

however, none of this was needed. we can simply return early if c was NULL.
Also `c` is set to `selmon->sel` so we can use `c` in the first check
instead which makes things shorter.

Ref.
https://git.suckless.org/dwm/commit/5e76e7e21da042c493c59235ca82d7275f20a7e4.html
2022-08-07 10:41:01 +02:00
bakkeby
10aa27171f Bump to 5b2e5e7.
spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

when calling die and the last character of the string corresponds to
':', die() will call perror(). See util.c

Also change EXIT_SUCCESS to EXIT_FAILURE

Ref.
https://git.suckless.org/dwm/commit/5b2e5e7a4001479e4dc3e245f96e49f7ea0da658.html
2022-08-03 11:20:09 +02:00
bakkeby
4b20c92b4c Adding bidi patch ref. #285 2022-08-02 10:58:10 +02:00
bakkeby
2e496ed931 dwmc: adding string support ref. #284 2022-08-01 10:37:19 +02:00
bakkeby
d9f79bea73 Bump to 9bffa84: use named parameter for func prototype
Ref. https://git.suckless.org/dwm/commit/9bffa845faa181fb3afe05f3dc86ad79c80736be.html
2022-07-28 11:29:50 +02:00
bakkeby
df5eba3f8f cleanup: getting rid of unused argument a 2022-07-11 14:35:32 +02:00
bakkeby
d4ab4400ac restartsig and cool autostart: moving functionality to the cleanup function ref. #276 2022-07-11 11:04:01 +02:00
Stein Gunnar Bakkeby
5f7df0b0dc
Adding tagpreview patch (#271) 2022-07-05 14:55:42 +02:00
bakkeby
20692bea01 Refactoring shift functions ref. #270 2022-07-05 13:51:27 +02:00
bakkeby
274602fa7a Updating readme to refer to shift-tools 2022-07-04 14:07:17 +02:00
bakkeby
197c218304 Adding shiftswaptags patch ref. #270 2022-07-04 13:56:39 +02:00
bakkeby
d3ab291944 Adding shiftboth patch ref. #270 2022-07-04 13:45:06 +02:00
bakkeby
279c571986 Adding shifttagclients patch ref. #270 2022-07-04 13:07:36 +02:00
bakkeby
a15a259926 Adding shifttag patch ref. #270 2022-07-04 11:28:23 +02:00
bakkeby
404401622b systray: hide systray when there are no systray icons to show ref. #268 2022-06-27 11:07:26 +02:00
bakkeby
2f70c42aab Adding renamed scratchpads patch 2022-06-20 14:00:09 +02:00
bakkeby
d7456b235a systray: removing redundant getatomprop declaration in bar_systray.h, ref. #260 2022-06-18 11:04:03 +02:00
bakkeby
39fde74dfd systray: allow systray icons to survive a restart by handing systray icons over to the root window before destroying the systray window 2022-06-17 16:58:47 +02:00
bakkeby
82c72835f6 restartsig + systray: allow systray icons to survive a restart by not destroying the systray window 2022-06-17 16:13:10 +02:00
bakkeby
440c4a6efa Porting the seamless restart feature from dusk into dwm-flexipatch 2022-06-17 14:36:20 +02:00
bakkeby
6f7d9b1bdf unmanage: stop listening for events for unmanaged windows
This is in particular to avoid flickering in dwm (and high CPU usage)
when hovering the mouse over a tabbed window that was previously
managed by dwm.

Consider the following two scenarios:

1)

We start tabbed (window 0xc000003), tabbed is managed by the
window manager.
We start st being embedded into tabbed.

$ st -w 0xc000003

What happens here is that:
   - tabbed gets a MapRequest for the st window
   - tabbed reparents the st window
   - tabbed will receive X events for the window

The window manager will have no awareness of the st window and the
X server will not send X events to the window manager relating to
the st window.

There is no flickering or any other issues relating to focus.

2)

We start tabbed (window 0xc000003), tabbed is managed by the
window manager.
We start st as normal (window 0xd400005).

What happens here is that:
   - the window manager gets a MapRequest for the st window
   - dwm manages the st window as a normal client
   - dwm will receive X events for the window

Now we use xdotool to trigger a reparenting of the st window into
tabbed.

$ xdotool windowreparent 0xd400005 0xc000003

What happens here is that:
   - tabbed gets a MapRequest for the st window
   - tabbed reparents the st window
   - the window manager gets an UnmapNotify
   - the window manager no longer manages the st window
   - both the window manager and tabbed will receive X events
     for the st window

In dwm move the mouse cursor over the tabbed window.

What happens now is that:
   - dwm will receive a FocusIn event for the tabbed window
   - dwm will set input focus for the tabbed window
   - tabbed will receive a FocusIn event for the main window
   - tabbed will give focus to the window on the currently selected
     tab
   - which again triggers a FocusIn event which dwm receives
   - dwm determines that the window that the FocusIn event is for
     (0xd400005) is not the currently selected client (tabbed)
   - dwm sets input focus for the tabbed window
   - this causes an infinite loop as long as the mouse cursor hovers
     the tabbed window, resulting in flickering and high CPU usage

The fix here is to tell the X server that we are no longer interested
in receiving events for this window when the window manager stops
managing the window.
2022-06-12 12:29:04 +02:00
Bakkeby
54070d7e51 vanitygaps + pertag: enablegaps should be retrieved from the current monitor, not the selected monitor ref. #258 2022-06-10 13:25:21 +02:00