Commit Graph

235 Commits

Author SHA1 Message Date
bakkeby
3e97a1d25c Makefile: remove the options target
The Makefile used to suppress output (by using @), so this target made sense at
the time.

But the Makefile should be simple and make debugging with less abstractions or
fancy printing.  The Makefile was made verbose and doesn't hide the build
output, so remove this target.

Prompted by a question on the mailing list about the options target.

ref.
https://git.suckless.org/dwm/commit/9f8855343c881bdc01b9fff5b956537ba1106b76.html
2023-09-22 18:08:42 +02:00
bakkeby
74abea7c70 Adding unmanaged patch ref. #365 2023-06-27 17:24:36 +02:00
bakkeby
99f6f1b52c Adding focusfollowmouse patch ref. #364 2023-06-27 16:07:57 +02:00
bakkeby
10a6640732 Adding the toggletopbar patch ref. #363 2023-06-25 22:52:50 +02:00
bakkeby
ff1f901743 Updating link to rounded corners patch 2023-05-22 10:03:06 +02:00
bakkeby
ace6f1cd88 Bump to e81f17d.
restore SIGCHLD sighandler to default before spawning a program

From sigaction(2):
A child created via fork(2) inherits a copy of its parent's signal dispositions.
During an execve(2), the dispositions of handled signals are reset to the default;
the dispositions of ignored signals are left unchanged.

This refused to start directly some programs from configuring in config.h:

static Key keys[] = {
	MODKEY,                       XK_o,      spawn,          {.v = cmd } },
};

Some reported programs that didn't start were: mpv, anki, dmenu_extended.

Reported by pfx.
Initial patch suggestion by Storkman.

Ref.
https://git.suckless.org/dwm/commit/e81f17d4c196aaed6893fd4beed49991caa3e2a4.html
2023-04-09 21:53:05 +02:00
bakkeby
91551329e9 Bump to 712d663.
Use sigaction(SA_NOCLDWAIT) for SIGCHLD handling

signal() semantics are pretty unclearly specified. For example, depending on OS
kernel and libc, the handler may be returned to SIG_DFL (hence the inner call
to read the signal handler). Moving to sigaction() means the behaviour is
consistently defined.

Using SA_NOCLDWAIT also allows us to avoid calling the non-reentrant function
die() in the handler.

Some addditional notes for archival purposes:

* NRK pointed out errno of waitpid could also theoretically get clobbered.
* The original patch was iterated on and modified by NRK and Hiltjo:
  * SIG_DFL was changed to SIG_IGN, this is required, atleast on older systems
    such as tested on Slackware 11.
  * signals are not blocked using sigprocmask, because in theory it would
    briefly for example also ignore a SIGTERM signal. It is OK if waitpid() is (in
    theory interrupted).

POSIX reference:
"Consequences of Process Termination":
https://pubs.opengroup.org/onlinepubs/9699919799/functions/_Exit.html#tag_16_01_03_01

Ref. https://git.suckless.org/dwm/commit/712d6639ff8e863560328131bbb92b248dc9cde7.html

NB: Cool autostart patch to use prior logic for now
2023-01-30 09:45:51 +01:00
bakkeby
954e60b735 Adding proposed view history patch ref. #327 2023-01-18 21:58:32 +01:00
bakkeby
4c32f6f52d Bump to 89f9905.
grabkeys: Avoid missing events when a keysym maps to multiple keycodes

It's not uncommon for one keysym to map to multiple keycodes. For
example, the "play" button on my keyboard sends keycode 172, but my
bluetooth headphones send keycode 208, both of which map back to
XF86AudioPlay:

    % xmodmap -pke | grep XF86AudioPlay
    keycode 172 = XF86AudioPlay XF86AudioPause XF86AudioPlay XF86AudioPause
    keycode 208 = XF86AudioPlay NoSymbol XF86AudioPlay
    keycode 215 = XF86AudioPlay NoSymbol XF86AudioPlay

This is a problem because the current code only grabs a single one of
these keycodes, which means that events for any other keycode also
mapping to the bound keysym will not be handled by dwm. In my case, this
means that binding XF86AudioPlay does the right thing and correctly
handles my keyboard's keys, but does nothing on my headphones. I'm not
the only person affected by this, there are other reports[0].

In order to fix this, we look at the mappings between keycodes and
keysyms at grabkeys() time and pick out all matching keycodes rather
than just the first one. The keypress() side of this doesn't need any
changes because the keycode gets converted back to a canonical keysym
before any action is taken.

0: https://github.com/cdown/dwm/issues/11

Ref.
https://git.suckless.org/dwm/commit/89f9905714c1c1b2e8b09986dfbeca15b68d8af8.html
2022-12-08 10:45:52 +01:00
bakkeby
ad56835713 Bump to ba56fe9.
Revert "Remove dmenumon variable"

This reverts commit c2b748e7931e5f28984efc236f9b1a212dbc65e8.

Revert back this change. It seems to not be an edge-case anymore since
multiple users have asked about this new behaviour now.

Ref.
https://git.suckless.org/dwm/commit/ba56fe9fea0a28d8184a727a987836a0903e2682.html
2022-10-30 10:32:43 +01:00
bakkeby
cc58ad2ef4 Adding alt-tab patch ref. #303 2022-10-08 22:35:04 +02:00
bakkeby
4912e3129a Bump to 50ad171.
remove workaround for a crash with color emojis on some systems, now fixed in libXft 2.3.5

https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS

bump version to 6.4

Ref.
https://git.suckless.org/dwm/commit/970f37697358574e127019eb0ee2f5725ec05ce0.html
https://git.suckless.org/dwm/commit/50ad171eea9db5ccb36fce2592e047c3282975ff.html

Consequently the color emoji patch has been inverted into no color emoji, keeping the workaround in the code base for those that are on systems with older versions of the Xft library.
2022-10-06 14:44:11 +02:00
bakkeby
2c180b8d9c Bump to c2b748e.
Remove dmenumon variable

Reasoning: Since 2011 dmenu has been capable of working out which
monitor currently has focus in a Xinerama setup, making the use
of the -m flag more or less redundant.

This is easily demonstrated by using dmenu in any other window
manager.

There used to be a nodmenu patch that provided these changes:
https://git.suckless.org/sites/commit/ed68e3629de4ef2ca2d3f8893a79fb570b4c0cbc.html

but this was removed on the basis that it was very easy to work
out and apply manually if needed.

The proposal here is to remove this dependency from dwm. The
mechanism of the dmenumon variable could be provided via a patch
if need be.

The edge case scenario that dmenu does not handle on its own, and
the effect of removing this mechanism, is that if the user trigger
focusmon via keybindings to change focus to another monitor that
has no clients, then dmenu will open on the monitor containing the
window with input focus (or the monitor with the mouse cursor if
no windows have input focus).

If this edge case is important to cover then this can be addressed
by setting input focus to selmon->barwin in the focus function if
there is no client to give focus to (rather than giving focus back
to the root window).

Ref.
https://git.suckless.org/dwm/commit/c2b748e7931e5f28984efc236f9b1a212dbc65e8.html
2022-08-29 21:49:41 +02:00
bakkeby
90f9b2d982 Bump to 84d7322.
config.def.h: make keys and buttons const

Pretty much all other variables are declared as const when they're not
modified.

Ref.
https://git.suckless.org/dwm/commit/84d7322113c2bf023f5eaa8537fb0e72d4105046.html
2022-08-21 10:33:53 +02:00
bakkeby
2d34596ad0 Bump to 44adafe.
Make floating windows spawn within the monitor's window area

This is a follow-up on this thread:
https://lists.suckless.org/hackers/2208/18462.html

The orginal code had constraints such that if a window's starting
attributes (position and size) were to place the window outside of
the edges of the monitor, then the window would be moved into view
at the closest monitor edge.

There was an exception to this where if a top bar is used then the
window should not obscure the bar if present, which meant to place
the window within the window area instead.

The proposed change here makes it the general rule that floating
windows should spawn within the window area rather than within the
monitor area. This makes it simple and consistent with no
exceptions and it makes the intention of the code clear.

This has the benefit of making the behaviour consistent regardless
of whether the user is using a top bar or a bottom bar.

Additionally this will have an effect on patches that modify the
size of the window area. For example if the insets patch is used to
reserve space on the left hand side of the monitor for a dock or a
vertical bar then new floating clients will not obscure that area.

Ref.
https://git.suckless.org/dwm/commit/44adafe0069e73aa03a3829d7bb39591cd8b3f1d.html
2022-08-12 15:02:25 +02:00
bakkeby
c438eabdc2 Adding nametag patch 2022-08-12 13:47:25 +02:00
bakkeby
91cb32c3ed Bump to e0dee91.
sync code-style patch from libsl

Ref.
https://git.suckless.org/dwm/commit/e0dee911455cee739a5b05a994828f4a37a2764d.html
2022-08-08 14:41:21 +02:00
bakkeby
6a0e5b884e Bump to 5e76e7e.
code-style: simplify some checks

main change here is making the `zoom()` logic saner. the rest of the
changes are just small stuff which accumulated on my local branch.

pop() must not be called with NULL. and `zoom()` achieves this, but in a
very (unnecessarily) complicated way:

if c == NULL then nexttiled() will return NULL as well, so we enter this
branch:

	if (c == nexttiled(selmon->clients))

in here the !c check fails and the function returns before calling pop()

		if (!c || !(c = nexttiled(c->next)))
			return;

however, none of this was needed. we can simply return early if c was NULL.
Also `c` is set to `selmon->sel` so we can use `c` in the first check
instead which makes things shorter.

Ref.
https://git.suckless.org/dwm/commit/5e76e7e21da042c493c59235ca82d7275f20a7e4.html
2022-08-07 10:41:01 +02:00
bakkeby
10aa27171f Bump to 5b2e5e7.
spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

when calling die and the last character of the string corresponds to
':', die() will call perror(). See util.c

Also change EXIT_SUCCESS to EXIT_FAILURE

Ref.
https://git.suckless.org/dwm/commit/5b2e5e7a4001479e4dc3e245f96e49f7ea0da658.html
2022-08-03 11:20:09 +02:00
bakkeby
4b20c92b4c Adding bidi patch ref. #285 2022-08-02 10:58:10 +02:00
bakkeby
d9f79bea73 Bump to 9bffa84: use named parameter for func prototype
Ref. https://git.suckless.org/dwm/commit/9bffa845faa181fb3afe05f3dc86ad79c80736be.html
2022-07-28 11:29:50 +02:00
Stein Gunnar Bakkeby
5f7df0b0dc
Adding tagpreview patch (#271) 2022-07-05 14:55:42 +02:00
bakkeby
274602fa7a Updating readme to refer to shift-tools 2022-07-04 14:07:17 +02:00
bakkeby
2f70c42aab Adding renamed scratchpads patch 2022-06-20 14:00:09 +02:00
bakkeby
440c4a6efa Porting the seamless restart feature from dusk into dwm-flexipatch 2022-06-17 14:36:20 +02:00
bakkeby
2ecc15a2ef manage: Make sure c->isfixed is applied before floating checks
Commit 8806b6e23793 ("manage: propertynotify: Reduce cost of unused size
hints") mistakenly removed an early size hints update that's needed to
populate c->isfixed for floating checks at manage() time. This resulted
in fixed (size hint min dimensions == max dimensions) subset of windows
not floating when they should.

See https://lists.suckless.org/dev/2204/34730.html for discussion.

Ref.
https://git.suckless.org/dwm/commit/8b48e309735f5fe49d35f86e967f4b5dea2a2f2d.html
2022-04-26 17:26:35 +02:00
bakkeby
b2fbf08d3c Update monitor positions also on removal
When monitors are removed, the coordinates of existing monitors may
change, if the removed monitors had smaller coordinates than the
remaining ones.

Remove special case handling so that the same update-if-necessary loop
is run also in the case when monitors are removed.

ref.
https://git.suckless.org/dwm/commit/d93ff48803f04f1363bf303af1d7e6ccc5cb8d3f.html#h0-0-21
2022-04-17 10:24:02 +02:00
bakkeby
93f9d97e84 Adding link to map of patches 2022-03-20 16:31:16 +01:00
bakkeby
8f93bb8931 manage: For isfloating/oldstate check/set, ensure trans client actually exists
In certain instances trans may be set to a window that doesn't actually
map to a client via wintoclient; in this case it doesn't make sense
to set isfloating/oldstate since trans is essentially invalid in that
case / correlates to the above condition check where trans is set /
XGetTransientForHint is called.

Ref.
https://git.suckless.org/dwm/commit/bece862a0fc4fc18ef9065b18cd28e2032d0d975.html
2022-03-14 09:41:32 +01:00
bakkeby
96820b2d51 tagsync: adding reference in README.md 2022-02-11 17:02:45 +01:00
bakkeby
065c17de4c Adding the isfreesize version of the sizehints patch ref. #229 2022-02-11 10:10:28 +01:00
bakkeby
0404e12dba bump version to 6.3 2022-01-10 17:24:12 +01:00
bakkeby
a9078fdb4d Adding underlinetags patch ref. #199 2021-11-23 22:49:27 +01:00
bakkeby
63fed59d19 Adding taglabels patch ref. #199 2021-11-23 22:36:53 +01:00
bakkeby
e68f434944 Add a statusallmons and staticstatus easily toggleable in patches.h ref. #188 2021-10-07 11:46:31 +02:00
bakkeby
22bbf1cb13 Adding alwayscenter patch ref. #182 2021-09-08 09:42:47 +02:00
bakkeby
f8ae6714db Adding winicon patch 2021-07-27 13:40:53 +02:00
bakkeby
73a29521e4 Correcting short hash 2021-06-21 13:44:14 +02:00
bakkeby
c968fd9aae Renaming VIEW_SAME_TAG_GIVES_PREVIOUS_TAG_PATCH to TOGGLETAG_PATCH 2021-05-30 19:31:25 +02:00
bakkeby
246f8f7260 Adding togglelayout patch 2021-05-30 19:22:00 +02:00
bakkeby
28c4d0eab2 Adding note about the Known Issues discussion category 2021-05-13 17:13:13 +02:00
bakkeby
ef89eb7c71 nodmenu: updating link 2021-05-09 20:04:13 +02:00
bakkeby
23c76d13b5 vanitygaps: replaced smartgaps with smartgaps_fact, allowing gaps to be increased when there is only one client. 2021-04-16 10:16:04 +02:00
bakkeby
7efb64d685 Upgraded the dwmblocks patch for statuscmd which changes the signalling
mechanism from SIGUSR1 to SIGRTMIN which is likely to cause issues for
those that already have a working setup. A compatibility option has been
added which changes this back to SIGUSR1. Note that configuration was
also changed.

This was ref. reported issue #114.
2021-04-14 10:42:52 +02:00
bakkeby
bd5f5608a3 Adding README changes for xkb patch 2021-04-08 11:58:24 +02:00
bakkeby
0c88a49e27 Adding distributetags patch 2021-04-06 12:47:38 +02:00
bakkeby
521f87af13 Adding proposed changes to have different gaps on a per tag basis ref. #106 2021-04-04 10:49:31 +02:00
bakkeby
647c5935b3 Adding tapresize notes to README.md 2021-03-31 09:18:58 +02:00
bakkeby
012d1f7639 Upgrading to 67d76b and removing alwaysfullscreen patch as it has been merged into mainstream dwm 6.2 2021-03-29 19:33:05 +02:00
bakkeby
72564eb394 Adding LG3D patch 2021-03-09 13:47:21 +01:00