Commit Graph

644 Commits

Author SHA1 Message Date
bakkeby
88eb89ab0d Roll back const change for IPCCommands 2022-08-29 21:37:43 +02:00
bakkeby
0f36ba5408 restartsig: call XNextEvent only when there is data to be read ref. #295 2022-08-29 21:37:03 +02:00
bakkeby
90f9b2d982 Bump to 84d7322.
config.def.h: make keys and buttons const

Pretty much all other variables are declared as const when they're not
modified.

Ref.
https://git.suckless.org/dwm/commit/84d7322113c2bf023f5eaa8537fb0e72d4105046.html
2022-08-21 10:33:53 +02:00
bakkeby
b93a5de558 Expose showhideclient to external tools (fsignal, IPC) ref #287 2022-08-13 16:24:55 +02:00
bakkeby
2d34596ad0 Bump to 44adafe.
Make floating windows spawn within the monitor's window area

This is a follow-up on this thread:
https://lists.suckless.org/hackers/2208/18462.html

The orginal code had constraints such that if a window's starting
attributes (position and size) were to place the window outside of
the edges of the monitor, then the window would be moved into view
at the closest monitor edge.

There was an exception to this where if a top bar is used then the
window should not obscure the bar if present, which meant to place
the window within the window area instead.

The proposed change here makes it the general rule that floating
windows should spawn within the window area rather than within the
monitor area. This makes it simple and consistent with no
exceptions and it makes the intention of the code clear.

This has the benefit of making the behaviour consistent regardless
of whether the user is using a top bar or a bottom bar.

Additionally this will have an effect on patches that modify the
size of the window area. For example if the insets patch is used to
reserve space on the left hand side of the monitor for a dock or a
vertical bar then new floating clients will not obscure that area.

Ref.
https://git.suckless.org/dwm/commit/44adafe0069e73aa03a3829d7bb39591cd8b3f1d.html
2022-08-12 15:02:25 +02:00
bakkeby
c438eabdc2 Adding nametag patch 2022-08-12 13:47:25 +02:00
bakkeby
91cb32c3ed Bump to e0dee91.
sync code-style patch from libsl

Ref.
https://git.suckless.org/dwm/commit/e0dee911455cee739a5b05a994828f4a37a2764d.html
2022-08-08 14:41:21 +02:00
bakkeby
d6205e3e89 autostart: upgrading to dwm-autostart-20210120-cb3f58a.diff 2022-08-07 10:50:25 +02:00
bakkeby
6a0e5b884e Bump to 5e76e7e.
code-style: simplify some checks

main change here is making the `zoom()` logic saner. the rest of the
changes are just small stuff which accumulated on my local branch.

pop() must not be called with NULL. and `zoom()` achieves this, but in a
very (unnecessarily) complicated way:

if c == NULL then nexttiled() will return NULL as well, so we enter this
branch:

	if (c == nexttiled(selmon->clients))

in here the !c check fails and the function returns before calling pop()

		if (!c || !(c = nexttiled(c->next)))
			return;

however, none of this was needed. we can simply return early if c was NULL.
Also `c` is set to `selmon->sel` so we can use `c` in the first check
instead which makes things shorter.

Ref.
https://git.suckless.org/dwm/commit/5e76e7e21da042c493c59235ca82d7275f20a7e4.html
2022-08-07 10:41:01 +02:00
bakkeby
10aa27171f Bump to 5b2e5e7.
spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

when calling die and the last character of the string corresponds to
':', die() will call perror(). See util.c

Also change EXIT_SUCCESS to EXIT_FAILURE

Ref.
https://git.suckless.org/dwm/commit/5b2e5e7a4001479e4dc3e245f96e49f7ea0da658.html
2022-08-03 11:20:09 +02:00
bakkeby
4b20c92b4c Adding bidi patch ref. #285 2022-08-02 10:58:10 +02:00
bakkeby
2e496ed931 dwmc: adding string support ref. #284 2022-08-01 10:37:19 +02:00
bakkeby
d9f79bea73 Bump to 9bffa84: use named parameter for func prototype
Ref. https://git.suckless.org/dwm/commit/9bffa845faa181fb3afe05f3dc86ad79c80736be.html
2022-07-28 11:29:50 +02:00
bakkeby
df5eba3f8f cleanup: getting rid of unused argument a 2022-07-11 14:35:32 +02:00
bakkeby
d4ab4400ac restartsig and cool autostart: moving functionality to the cleanup function ref. #276 2022-07-11 11:04:01 +02:00
Stein Gunnar Bakkeby
5f7df0b0dc
Adding tagpreview patch (#271) 2022-07-05 14:55:42 +02:00
bakkeby
20692bea01 Refactoring shift functions ref. #270 2022-07-05 13:51:27 +02:00
bakkeby
274602fa7a Updating readme to refer to shift-tools 2022-07-04 14:07:17 +02:00
bakkeby
197c218304 Adding shiftswaptags patch ref. #270 2022-07-04 13:56:39 +02:00
bakkeby
d3ab291944 Adding shiftboth patch ref. #270 2022-07-04 13:45:06 +02:00
bakkeby
279c571986 Adding shifttagclients patch ref. #270 2022-07-04 13:07:36 +02:00
bakkeby
a15a259926 Adding shifttag patch ref. #270 2022-07-04 11:28:23 +02:00
bakkeby
404401622b systray: hide systray when there are no systray icons to show ref. #268 2022-06-27 11:07:26 +02:00
bakkeby
2f70c42aab Adding renamed scratchpads patch 2022-06-20 14:00:09 +02:00
bakkeby
d7456b235a systray: removing redundant getatomprop declaration in bar_systray.h, ref. #260 2022-06-18 11:04:03 +02:00
bakkeby
39fde74dfd systray: allow systray icons to survive a restart by handing systray icons over to the root window before destroying the systray window 2022-06-17 16:58:47 +02:00
bakkeby
82c72835f6 restartsig + systray: allow systray icons to survive a restart by not destroying the systray window 2022-06-17 16:13:10 +02:00
bakkeby
440c4a6efa Porting the seamless restart feature from dusk into dwm-flexipatch 2022-06-17 14:36:20 +02:00
bakkeby
6f7d9b1bdf unmanage: stop listening for events for unmanaged windows
This is in particular to avoid flickering in dwm (and high CPU usage)
when hovering the mouse over a tabbed window that was previously
managed by dwm.

Consider the following two scenarios:

1)

We start tabbed (window 0xc000003), tabbed is managed by the
window manager.
We start st being embedded into tabbed.

$ st -w 0xc000003

What happens here is that:
   - tabbed gets a MapRequest for the st window
   - tabbed reparents the st window
   - tabbed will receive X events for the window

The window manager will have no awareness of the st window and the
X server will not send X events to the window manager relating to
the st window.

There is no flickering or any other issues relating to focus.

2)

We start tabbed (window 0xc000003), tabbed is managed by the
window manager.
We start st as normal (window 0xd400005).

What happens here is that:
   - the window manager gets a MapRequest for the st window
   - dwm manages the st window as a normal client
   - dwm will receive X events for the window

Now we use xdotool to trigger a reparenting of the st window into
tabbed.

$ xdotool windowreparent 0xd400005 0xc000003

What happens here is that:
   - tabbed gets a MapRequest for the st window
   - tabbed reparents the st window
   - the window manager gets an UnmapNotify
   - the window manager no longer manages the st window
   - both the window manager and tabbed will receive X events
     for the st window

In dwm move the mouse cursor over the tabbed window.

What happens now is that:
   - dwm will receive a FocusIn event for the tabbed window
   - dwm will set input focus for the tabbed window
   - tabbed will receive a FocusIn event for the main window
   - tabbed will give focus to the window on the currently selected
     tab
   - which again triggers a FocusIn event which dwm receives
   - dwm determines that the window that the FocusIn event is for
     (0xd400005) is not the currently selected client (tabbed)
   - dwm sets input focus for the tabbed window
   - this causes an infinite loop as long as the mouse cursor hovers
     the tabbed window, resulting in flickering and high CPU usage

The fix here is to tell the X server that we are no longer interested
in receiving events for this window when the window manager stops
managing the window.
2022-06-12 12:29:04 +02:00
Bakkeby
54070d7e51 vanitygaps + pertag: enablegaps should be retrieved from the current monitor, not the selected monitor ref. #258 2022-06-10 13:25:21 +02:00
Bakkeby
c553f93b52 shiftview + scrachpads compatibility 2022-05-08 21:43:57 +02:00
bakkeby
2ecc15a2ef manage: Make sure c->isfixed is applied before floating checks
Commit 8806b6e23793 ("manage: propertynotify: Reduce cost of unused size
hints") mistakenly removed an early size hints update that's needed to
populate c->isfixed for floating checks at manage() time. This resulted
in fixed (size hint min dimensions == max dimensions) subset of windows
not floating when they should.

See https://lists.suckless.org/dev/2204/34730.html for discussion.

Ref.
https://git.suckless.org/dwm/commit/8b48e309735f5fe49d35f86e967f4b5dea2a2f2d.html
2022-04-26 17:26:35 +02:00
bakkeby
f2b37c411c LICENSE: add Chris Down
Ref.
https://git.suckless.org/dwm/commit/a83dc2031050d786ddf5f329b57d658a931c94b7.html
2022-04-26 17:23:19 +02:00
bakkeby
38f709fea5 Revert "manage: For isfloating/oldstate check/set, ensure trans client actually exists"
This reverts commit bece862a0fc4fc18ef9065b18cd28e2032d0d975.

It caused a regression, for example:
https://lists.suckless.org/hackers/2203/18220.html

Ref.
https://git.suckless.org/dwm/commit/a4771de5ba54a38b062a7d748635f21c141b5c7e.html
2022-04-26 17:22:11 +02:00
bakkeby
49fc922f0d For all intensive purposes the monitor index is the same as monitor num, thus refactoring to use the latter 2022-04-17 10:33:26 +02:00
bakkeby
b2fbf08d3c Update monitor positions also on removal
When monitors are removed, the coordinates of existing monitors may
change, if the removed monitors had smaller coordinates than the
remaining ones.

Remove special case handling so that the same update-if-necessary loop
is run also in the case when monitors are removed.

ref.
https://git.suckless.org/dwm/commit/d93ff48803f04f1363bf303af1d7e6ccc5cb8d3f.html#h0-0-21
2022-04-17 10:24:02 +02:00
bakkeby
53d71de38d manage: propertynotify: Reduce cost of unused size hints
This patch defers all size hint calculations until they are actually
needed, drastically reducing the number of calls to updatesizehints(),
which can be expensive when called repeatedly (as it currently is during
resizes).

In my unscientific testing this reduces calls to updatesizehints() by
over 90% during a typical work session. There are no functional changes
for users other than an increase in responsiveness after resizes and
a reduction in CPU time.

In slower environments or X servers, this patch also offers an
improvement in responsiveness that is often tangible after resizing a
client that changes hints during resizes.

There are two main motivations to defer this work to the time of hint
application:

1. Some clients, especially terminals using incremental size hints,
   resend XA_WM_NORMAL_HINTS events on resize to avoid fighting with the
   WM or mouse resizing. For example, some terminals like urxvt clear
   PBaseSize and PResizeInc during XResizeWindow and restore them
   afterwards.

   For this reason, after the resize is concluded, we typically receive
   a backlogged XA_WM_NORMAL_HINTS message for each update period with
   movement, which is useless. In some cases one may get hundreds or
   thousands of XA_WM_NORMAL_HINTS messages on large resizes, and
   currently all of these result in a separate updatesizehints() call,
   of which all but the final one are immediately outdated.

   (We can't just blindly discard these messages during resizes like we
   do for EnterNotify, because some of them might actually be for other
   windows, and may not be XA_WM_NORMAL_HINTS events.)

2. For users which use resizehints=0 most of these updates are unused
   anyway -- in the normal case where the client is not floating these
   values won't be used, so there's no need to calculate them up front.

A synthetic test using the mouse to resize a floating terminal window
from roughly 256x256 to 1024x1024 and back again shows that the number
of calls to updatesizehints() goes from over 500 before this patch (one
for each update interval with movement) to 2 after this patch (one for
each hint application), with no change in user visible behaviour.

This also reduces the delay before dwm is ready to process new events
again after a large resize on such a client, as it avoids the thundering
herd of updatesizehints() calls when hundreds of backlogged
XA_WM_NORMAL_HINTS messages appear at once after a resize is finished.

ref.
https://git.suckless.org/dwm/commit/8806b6e2379372900e3d9e0bf6604bc7f727350b.html#h0-0-4
2022-04-17 10:15:22 +02:00
bakkeby
6a0f5b4250 setborderpx: refactoring patch 2022-03-30 14:20:27 +02:00
bakkeby
93f9d97e84 Adding link to map of patches 2022-03-20 16:31:16 +01:00
bakkeby
8f93bb8931 manage: For isfloating/oldstate check/set, ensure trans client actually exists
In certain instances trans may be set to a window that doesn't actually
map to a client via wintoclient; in this case it doesn't make sense
to set isfloating/oldstate since trans is essentially invalid in that
case / correlates to the above condition check where trans is set /
XGetTransientForHint is called.

Ref.
https://git.suckless.org/dwm/commit/bece862a0fc4fc18ef9065b18cd28e2032d0d975.html
2022-03-14 09:41:32 +01:00
bakkeby
da5e69c4a7 holdbar + systray compatibility - make systray follow the bar when being revealed and hidden ref. #239 2022-03-10 09:35:12 +01:00
bakkeby
adc05c2332 Upgrading winicon patch to v2.1 ref. #238 2022-03-06 11:38:22 +01:00
dev-null-undefined
5c321794f1
Fixed moving window tag issue (#237)
+ when moving window from monitor with different tags selected the moved
  window would not get the tags set properly if multiple windows are
  already on that monitor
2022-02-24 12:49:52 +01:00
bakkeby
55592623f5 focusadjacenttags + scratchpad compatibility issue ref. #236 2022-02-20 13:24:52 +01:00
bakkeby
96820b2d51 tagsync: adding reference in README.md 2022-02-11 17:02:45 +01:00
Bagellll
ae67378b20
Tag-Sync patch (for syncing tags across all monitors) (#219)
* Tag-Sync patch
* Major compatibility updates
* SWITCHTAG/TAGSYNC compatibility
* tagsync: refactoring

Co-authored-by: bakkeby <bakkeby@gmail.com>
2022-02-11 16:57:53 +01:00
bakkeby
8f986a4e3b Merge branch 'UtkarshVerma-bar-gaps' ref. #208 2022-02-11 11:48:27 +01:00
bakkeby
282dc2ad22 barpadding: adding vanitygaps variant 2022-02-11 11:43:36 +01:00
bakkeby
90e4dfc0cf Adding the isfreesize version of the sizehints patch ref. #229 2022-02-11 11:43:36 +01:00
bakkeby
a0751271bc sizehints ruled: have rule checks take window type and role into account ref. #229 2022-02-11 11:43:36 +01:00