Commit Graph

669 Commits

Author SHA1 Message Date
bakkeby
39fde74dfd systray: allow systray icons to survive a restart by handing systray icons over to the root window before destroying the systray window 2022-06-17 16:58:47 +02:00
bakkeby
82c72835f6 restartsig + systray: allow systray icons to survive a restart by not destroying the systray window 2022-06-17 16:13:10 +02:00
bakkeby
440c4a6efa Porting the seamless restart feature from dusk into dwm-flexipatch 2022-06-17 14:36:20 +02:00
bakkeby
6f7d9b1bdf unmanage: stop listening for events for unmanaged windows
This is in particular to avoid flickering in dwm (and high CPU usage)
when hovering the mouse over a tabbed window that was previously
managed by dwm.

Consider the following two scenarios:

1)

We start tabbed (window 0xc000003), tabbed is managed by the
window manager.
We start st being embedded into tabbed.

$ st -w 0xc000003

What happens here is that:
   - tabbed gets a MapRequest for the st window
   - tabbed reparents the st window
   - tabbed will receive X events for the window

The window manager will have no awareness of the st window and the
X server will not send X events to the window manager relating to
the st window.

There is no flickering or any other issues relating to focus.

2)

We start tabbed (window 0xc000003), tabbed is managed by the
window manager.
We start st as normal (window 0xd400005).

What happens here is that:
   - the window manager gets a MapRequest for the st window
   - dwm manages the st window as a normal client
   - dwm will receive X events for the window

Now we use xdotool to trigger a reparenting of the st window into
tabbed.

$ xdotool windowreparent 0xd400005 0xc000003

What happens here is that:
   - tabbed gets a MapRequest for the st window
   - tabbed reparents the st window
   - the window manager gets an UnmapNotify
   - the window manager no longer manages the st window
   - both the window manager and tabbed will receive X events
     for the st window

In dwm move the mouse cursor over the tabbed window.

What happens now is that:
   - dwm will receive a FocusIn event for the tabbed window
   - dwm will set input focus for the tabbed window
   - tabbed will receive a FocusIn event for the main window
   - tabbed will give focus to the window on the currently selected
     tab
   - which again triggers a FocusIn event which dwm receives
   - dwm determines that the window that the FocusIn event is for
     (0xd400005) is not the currently selected client (tabbed)
   - dwm sets input focus for the tabbed window
   - this causes an infinite loop as long as the mouse cursor hovers
     the tabbed window, resulting in flickering and high CPU usage

The fix here is to tell the X server that we are no longer interested
in receiving events for this window when the window manager stops
managing the window.
2022-06-12 12:29:04 +02:00
Bakkeby
54070d7e51 vanitygaps + pertag: enablegaps should be retrieved from the current monitor, not the selected monitor ref. #258 2022-06-10 13:25:21 +02:00
Bakkeby
c553f93b52 shiftview + scrachpads compatibility 2022-05-08 21:43:57 +02:00
bakkeby
2ecc15a2ef manage: Make sure c->isfixed is applied before floating checks
Commit 8806b6e23793 ("manage: propertynotify: Reduce cost of unused size
hints") mistakenly removed an early size hints update that's needed to
populate c->isfixed for floating checks at manage() time. This resulted
in fixed (size hint min dimensions == max dimensions) subset of windows
not floating when they should.

See https://lists.suckless.org/dev/2204/34730.html for discussion.

Ref.
https://git.suckless.org/dwm/commit/8b48e309735f5fe49d35f86e967f4b5dea2a2f2d.html
2022-04-26 17:26:35 +02:00
bakkeby
f2b37c411c LICENSE: add Chris Down
Ref.
https://git.suckless.org/dwm/commit/a83dc2031050d786ddf5f329b57d658a931c94b7.html
2022-04-26 17:23:19 +02:00
bakkeby
38f709fea5 Revert "manage: For isfloating/oldstate check/set, ensure trans client actually exists"
This reverts commit bece862a0fc4fc18ef9065b18cd28e2032d0d975.

It caused a regression, for example:
https://lists.suckless.org/hackers/2203/18220.html

Ref.
https://git.suckless.org/dwm/commit/a4771de5ba54a38b062a7d748635f21c141b5c7e.html
2022-04-26 17:22:11 +02:00
bakkeby
49fc922f0d For all intensive purposes the monitor index is the same as monitor num, thus refactoring to use the latter 2022-04-17 10:33:26 +02:00
bakkeby
b2fbf08d3c Update monitor positions also on removal
When monitors are removed, the coordinates of existing monitors may
change, if the removed monitors had smaller coordinates than the
remaining ones.

Remove special case handling so that the same update-if-necessary loop
is run also in the case when monitors are removed.

ref.
https://git.suckless.org/dwm/commit/d93ff48803f04f1363bf303af1d7e6ccc5cb8d3f.html#h0-0-21
2022-04-17 10:24:02 +02:00
bakkeby
53d71de38d manage: propertynotify: Reduce cost of unused size hints
This patch defers all size hint calculations until they are actually
needed, drastically reducing the number of calls to updatesizehints(),
which can be expensive when called repeatedly (as it currently is during
resizes).

In my unscientific testing this reduces calls to updatesizehints() by
over 90% during a typical work session. There are no functional changes
for users other than an increase in responsiveness after resizes and
a reduction in CPU time.

In slower environments or X servers, this patch also offers an
improvement in responsiveness that is often tangible after resizing a
client that changes hints during resizes.

There are two main motivations to defer this work to the time of hint
application:

1. Some clients, especially terminals using incremental size hints,
   resend XA_WM_NORMAL_HINTS events on resize to avoid fighting with the
   WM or mouse resizing. For example, some terminals like urxvt clear
   PBaseSize and PResizeInc during XResizeWindow and restore them
   afterwards.

   For this reason, after the resize is concluded, we typically receive
   a backlogged XA_WM_NORMAL_HINTS message for each update period with
   movement, which is useless. In some cases one may get hundreds or
   thousands of XA_WM_NORMAL_HINTS messages on large resizes, and
   currently all of these result in a separate updatesizehints() call,
   of which all but the final one are immediately outdated.

   (We can't just blindly discard these messages during resizes like we
   do for EnterNotify, because some of them might actually be for other
   windows, and may not be XA_WM_NORMAL_HINTS events.)

2. For users which use resizehints=0 most of these updates are unused
   anyway -- in the normal case where the client is not floating these
   values won't be used, so there's no need to calculate them up front.

A synthetic test using the mouse to resize a floating terminal window
from roughly 256x256 to 1024x1024 and back again shows that the number
of calls to updatesizehints() goes from over 500 before this patch (one
for each update interval with movement) to 2 after this patch (one for
each hint application), with no change in user visible behaviour.

This also reduces the delay before dwm is ready to process new events
again after a large resize on such a client, as it avoids the thundering
herd of updatesizehints() calls when hundreds of backlogged
XA_WM_NORMAL_HINTS messages appear at once after a resize is finished.

ref.
https://git.suckless.org/dwm/commit/8806b6e2379372900e3d9e0bf6604bc7f727350b.html#h0-0-4
2022-04-17 10:15:22 +02:00
bakkeby
6a0f5b4250 setborderpx: refactoring patch 2022-03-30 14:20:27 +02:00
bakkeby
93f9d97e84 Adding link to map of patches 2022-03-20 16:31:16 +01:00
bakkeby
8f93bb8931 manage: For isfloating/oldstate check/set, ensure trans client actually exists
In certain instances trans may be set to a window that doesn't actually
map to a client via wintoclient; in this case it doesn't make sense
to set isfloating/oldstate since trans is essentially invalid in that
case / correlates to the above condition check where trans is set /
XGetTransientForHint is called.

Ref.
https://git.suckless.org/dwm/commit/bece862a0fc4fc18ef9065b18cd28e2032d0d975.html
2022-03-14 09:41:32 +01:00
bakkeby
da5e69c4a7 holdbar + systray compatibility - make systray follow the bar when being revealed and hidden ref. #239 2022-03-10 09:35:12 +01:00
bakkeby
adc05c2332 Upgrading winicon patch to v2.1 ref. #238 2022-03-06 11:38:22 +01:00
dev-null-undefined
5c321794f1
Fixed moving window tag issue (#237)
+ when moving window from monitor with different tags selected the moved
  window would not get the tags set properly if multiple windows are
  already on that monitor
2022-02-24 12:49:52 +01:00
bakkeby
55592623f5 focusadjacenttags + scratchpad compatibility issue ref. #236 2022-02-20 13:24:52 +01:00
bakkeby
96820b2d51 tagsync: adding reference in README.md 2022-02-11 17:02:45 +01:00
Bagellll
ae67378b20
Tag-Sync patch (for syncing tags across all monitors) (#219)
* Tag-Sync patch
* Major compatibility updates
* SWITCHTAG/TAGSYNC compatibility
* tagsync: refactoring

Co-authored-by: bakkeby <bakkeby@gmail.com>
2022-02-11 16:57:53 +01:00
bakkeby
8f986a4e3b Merge branch 'UtkarshVerma-bar-gaps' ref. #208 2022-02-11 11:48:27 +01:00
bakkeby
282dc2ad22 barpadding: adding vanitygaps variant 2022-02-11 11:43:36 +01:00
bakkeby
90e4dfc0cf Adding the isfreesize version of the sizehints patch ref. #229 2022-02-11 11:43:36 +01:00
bakkeby
a0751271bc sizehints ruled: have rule checks take window type and role into account ref. #229 2022-02-11 11:43:36 +01:00
bakkeby
8e36c36bcf Fix for drw_text cropping one characters too many when the text is too long and replacing with ... ref. #216 2022-02-11 11:43:36 +01:00
bakkeby
d1662b6636 Ignoring unused functions warnings.
This is achieved by adding the -Wno-unused-function flag to the compiler.
The warnings are suppressed to avoid confusion for users new to dwm.

Removing the static declaration from the header files works too, but adds
unnecessary data into the compiled object.
2022-02-11 11:43:35 +01:00
bakkeby
5c80a54b62 Refactoring restack to allow it to work without having the bar as a reference ref. #214 2022-02-11 11:43:35 +01:00
bakkeby
b17ea8e2de Refactoring window title drawing with regards to icons ref. #216 2022-02-11 11:43:35 +01:00
bakkeby
a0d5ba9369 tags bar module: fix for wrong click offset ref. #215 2022-02-11 11:43:35 +01:00
bakkeby
2771f3d1c9 bump version to 6.3 2022-02-11 11:43:35 +01:00
bakkeby
094c8ff363 Add a configuration option for fullscreen locking
Some people are annoyed to have this new behaviour forced for some
application which use fake fullscreen.

Ref. https://git.suckless.org/dwm/commit/138b405f0c8aa24d8a040cc1a1cf6e3eb5a0ebc7.html
2022-02-11 11:43:34 +01:00
bakkeby
1920595795 drawbar: Don't expend effort drawing bar if it is occluded
I noticed that a non-trivial amount of dwm's work on my machine was from
drw_text, which seemed weird, because I have the bar disabled and we
only use drw_text as part of bar drawing.

Looking more closely, I realised that while we use m->showbar when
updating the monitor bar margins, but don't skip actually drawing the
bar if it is hidden. This patch skips drawing it entirely if that is the
case.

On my machine, this takes 10% of dwm's on-CPU time, primarily from
restack() and focus().

When the bar is toggled on again, the X server will generate an Expose
event, and we'll redraw the bar as normal as part of expose().

Ref. https://git.suckless.org/dwm/commit/8657affa2a61e85ca8df76b62e43cb02897d1d80.html
2022-02-11 11:43:34 +01:00
bakkeby
aa1a7ff708 Fix for infinite loop when there is only one client and pushup is run twice 2022-02-11 11:43:34 +01:00
bakkeby
065c17de4c Adding the isfreesize version of the sizehints patch ref. #229 2022-02-11 10:10:28 +01:00
bakkeby
24ca9b4243 sizehints ruled: have rule checks take window type and role into account ref. #229 2022-02-11 09:44:40 +01:00
bakkeby
4366f72390 Fix for drw_text cropping one characters too many when the text is too long and replacing with ... ref. #216 2022-01-20 22:21:55 +01:00
bakkeby
2c5f877bd2 Ignoring unused functions warnings.
This is achieved by adding the -Wno-unused-function flag to the compiler.
The warnings are suppressed to avoid confusion for users new to dwm.

Removing the static declaration from the header files works too, but adds
unnecessary data into the compiled object.
2022-01-18 14:29:11 +01:00
bakkeby
e6dc6a3016 Refactoring restack to allow it to work without having the bar as a reference ref. #214 2022-01-18 11:08:34 +01:00
bakkeby
489ac30092 Refactoring window title drawing with regards to icons ref. #216 2022-01-18 11:04:35 +01:00
bakkeby
406faa9cc3 tags bar module: fix for wrong click offset ref. #215 2022-01-14 21:12:36 +01:00
bakkeby
0404e12dba bump version to 6.3 2022-01-10 17:24:12 +01:00
bakkeby
0a4e6de597 Add a configuration option for fullscreen locking
Some people are annoyed to have this new behaviour forced for some
application which use fake fullscreen.

Ref. https://git.suckless.org/dwm/commit/138b405f0c8aa24d8a040cc1a1cf6e3eb5a0ebc7.html
2022-01-10 17:18:45 +01:00
bakkeby
0350db1b39 drawbar: Don't expend effort drawing bar if it is occluded
I noticed that a non-trivial amount of dwm's work on my machine was from
drw_text, which seemed weird, because I have the bar disabled and we
only use drw_text as part of bar drawing.

Looking more closely, I realised that while we use m->showbar when
updating the monitor bar margins, but don't skip actually drawing the
bar if it is hidden. This patch skips drawing it entirely if that is the
case.

On my machine, this takes 10% of dwm's on-CPU time, primarily from
restack() and focus().

When the bar is toggled on again, the X server will generate an Expose
event, and we'll redraw the bar as normal as part of expose().

Ref. https://git.suckless.org/dwm/commit/8657affa2a61e85ca8df76b62e43cb02897d1d80.html
2022-01-10 17:16:09 +01:00
bakkeby
9ea0cb6c7c Fix for infinite loop when there is only one client and pushup is run twice 2022-01-07 22:27:08 +01:00
Utkarsh Verma
6667f1030b
Make sure it plays well with pertag patch 2021-12-26 21:26:32 +05:30
Utkarsh Verma
3d081ef5f9
Loop through all bars 2021-12-26 19:30:01 +05:30
Utkarsh Verma
0cd25db5af
Fix resizing of bar 2021-12-26 18:53:53 +05:30
Utkarsh Verma
8f401e1d81
Add a new patch to integrate vanity gaps with bar padding 2021-12-26 18:30:37 +05:30
bakkeby
40d30e5d1b Adding the one line of bloat that would have saved a lot of time for a lot of people 2021-11-25 09:15:27 +01:00