Commit Graph

685 Commits

Author SHA1 Message Date
bakkeby
5865c68c0e systray + unmanaged: fixed compatibility issue 2023-09-22 18:05:25 +02:00
Mahdi Nayef
7849eaa08b
Use pkg-config to locate fribidi library's files (#369) 2023-08-24 18:18:03 +02:00
bakkeby
74abea7c70 Adding unmanaged patch ref. #365 2023-06-27 17:24:36 +02:00
bakkeby
ab7d28ff0f bar border - allow for the border size to be explicitly set ref. #364 2023-06-27 16:31:02 +02:00
bakkeby
99f6f1b52c Adding focusfollowmouse patch ref. #364 2023-06-27 16:07:57 +02:00
bakkeby
1a1ce47917 layoutmenu: fixing warning from original patch 2023-06-27 14:59:48 +02:00
bakkeby
10a6640732 Adding the toggletopbar patch ref. #363 2023-06-25 22:52:50 +02:00
bakkeby
3881ad4ad1 config.mk - dropping __XSI_VISIBLE from CPPFLAGS, should no longer be necessary 2023-05-24 15:27:12 +02:00
bakkeby
ff1f901743 Updating link to rounded corners patch 2023-05-22 10:03:06 +02:00
bakkeby
6ef80c09ff switchtag + pertag conflict: the view would not actually change ref. #355 2023-05-20 16:21:55 +02:00
bakkeby
eca757eeea pertag + vanitygaps: store signed ints rather than unsigned in case negative gap values are used 2023-05-14 22:28:15 +02:00
bakkeby
5fefbfee64 cool autostart: restore SIGCHLD sighandler to default before spawning a program 2023-04-09 22:08:41 +02:00
bakkeby
ace6f1cd88 Bump to e81f17d.
restore SIGCHLD sighandler to default before spawning a program

From sigaction(2):
A child created via fork(2) inherits a copy of its parent's signal dispositions.
During an execve(2), the dispositions of handled signals are reset to the default;
the dispositions of ignored signals are left unchanged.

This refused to start directly some programs from configuring in config.h:

static Key keys[] = {
	MODKEY,                       XK_o,      spawn,          {.v = cmd } },
};

Some reported programs that didn't start were: mpv, anki, dmenu_extended.

Reported by pfx.
Initial patch suggestion by Storkman.

Ref.
https://git.suckless.org/dwm/commit/e81f17d4c196aaed6893fd4beed49991caa3e2a4.html
2023-04-09 21:53:05 +02:00
bakkeby
5498fed42b Bump to 348f655.
config.mk: update to _XOPEN_SOURCE=700L

SA_NOCLDWAIT is marked as XSI in the posix spec [0] and FreeBSD and NetBSD
seems to more be strict about the feature test macro [1].

so update the macro to use _XOPEN_SOURCE=700L instead, which is equivalent to
_POSIX_C_SOURCE=200809L except that it also unlocks the X/Open System
Interfaces.

[0]: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html#tag_13_42
[1]: https://lists.suckless.org/dev/2302/35111.html

Tested on:
* NetBSD 9.3 (fixed).
* FreeBSD 13 (fixed).
* Void Linux musl.
* Void Linux glibc.
* OpenBSD 7.2 (stable).
* Slackware 11.

Reported-by: beastie <pufferfish@riseup.net>

Ref.
https://git.suckless.org/dwm/commit/348f6559ab0d4793db196ffa56ba96ab95a594a6.html
2023-04-09 21:51:26 +02:00
bakkeby
816487f4bb Adding workaround for gnu core utils treating cp -n as an error ref. #347
Changes to core utils had the side effect of treating the no-clobber option
as an error if the file was not copied if it already exists, thus causing
make to error as well.

Adding this workaround until that issue is addressed.

Alternative solutions:
   - always overwrite the file using the -f / --force option
   - prefix the cp command with a hyphen which will cause make to ignore
     the error, but still report it
   - never copy dwm.desktop during the installation process
2023-03-26 13:00:54 +02:00
bakkeby
fcbe686ff2 pertag vanitygaps patch - adjust description ref. #342 2023-02-18 10:31:32 +01:00
bakkeby
c613917d6b config.mk - passing __XSI_VISIBLE=1 via CPPFLAGS as needed for compilation on BSD systems ref. #340 2023-02-16 10:10:02 +01:00
speedie1337
e206d65f1e
Add swallow/window icon compatibility (#336)
* Add swallow/window icon compatibility. Without this, after a client is
swallowed the old icon (usually from the terminal emulator) is
preserved. This is noticeable if you, say run `mpv` from a terminal
emulator which is a common use case.

---------

Co-authored-by: speedie <speedie@duck.com>
2023-02-03 20:04:00 +00:00
bakkeby
e424e87c40 Patch toggle BAR_TITLE_LEFT_PAD_PATCH to be disabled by default ref. #335 2023-02-02 21:14:42 +01:00
bakkeby
91551329e9 Bump to 712d663.
Use sigaction(SA_NOCLDWAIT) for SIGCHLD handling

signal() semantics are pretty unclearly specified. For example, depending on OS
kernel and libc, the handler may be returned to SIG_DFL (hence the inner call
to read the signal handler). Moving to sigaction() means the behaviour is
consistently defined.

Using SA_NOCLDWAIT also allows us to avoid calling the non-reentrant function
die() in the handler.

Some addditional notes for archival purposes:

* NRK pointed out errno of waitpid could also theoretically get clobbered.
* The original patch was iterated on and modified by NRK and Hiltjo:
  * SIG_DFL was changed to SIG_IGN, this is required, atleast on older systems
    such as tested on Slackware 11.
  * signals are not blocked using sigprocmask, because in theory it would
    briefly for example also ignore a SIGTERM signal. It is OK if waitpid() is (in
    theory interrupted).

POSIX reference:
"Consequences of Process Termination":
https://pubs.opengroup.org/onlinepubs/9699919799/functions/_Exit.html#tag_16_01_03_01

Ref. https://git.suckless.org/dwm/commit/712d6639ff8e863560328131bbb92b248dc9cde7.html

NB: Cool autostart patch to use prior logic for now
2023-01-30 09:45:51 +01:00
bakkeby
f713ddee39 cyclelayouts: reimplementing patch to not require the NULL layout, addresses #331 2023-01-29 22:13:50 +01:00
bakkeby
954e60b735 Adding proposed view history patch ref. #327 2023-01-18 21:58:32 +01:00
bakkeby
40e2cac4e9 pertag: simplifying implementation by removing prevtag 2023-01-18 21:18:14 +01:00
bakkeby
6c822cbfce emptyview: initialising arrays to 0 is redundant 2023-01-18 21:01:35 +01:00
bakkeby
6b7246cb90 zoomswap: proposed changes to ensure that previous zooms references are cleared when unmanaging a client ref. #324 2023-01-13 16:19:33 +01:00
bakkeby
2a8e68c5df Correcting path to /usr/local/share/xsessions/ ref. #317 2023-01-08 10:22:37 +01:00
bakkeby
3b72e139ec Revert "Hardcoding xsessions directory to /usr/share/xsessions as suggested in #317"
This reverts commit f0ad1117ba.
2023-01-08 10:20:34 +01:00
bakkeby
f0ad1117ba Hardcoding xsessions directory to /usr/share/xsessions as suggested in #317 2023-01-06 08:43:55 +01:00
bakkeby
668e18fddf seamless restart: Fix positioning of hidden scratchpad windows following restart ref. #315 2022-12-14 17:56:50 +01:00
bakkeby
4c32f6f52d Bump to 89f9905.
grabkeys: Avoid missing events when a keysym maps to multiple keycodes

It's not uncommon for one keysym to map to multiple keycodes. For
example, the "play" button on my keyboard sends keycode 172, but my
bluetooth headphones send keycode 208, both of which map back to
XF86AudioPlay:

    % xmodmap -pke | grep XF86AudioPlay
    keycode 172 = XF86AudioPlay XF86AudioPause XF86AudioPlay XF86AudioPause
    keycode 208 = XF86AudioPlay NoSymbol XF86AudioPlay
    keycode 215 = XF86AudioPlay NoSymbol XF86AudioPlay

This is a problem because the current code only grabs a single one of
these keycodes, which means that events for any other keycode also
mapping to the bound keysym will not be handled by dwm. In my case, this
means that binding XF86AudioPlay does the right thing and correctly
handles my keyboard's keys, but does nothing on my headphones. I'm not
the only person affected by this, there are other reports[0].

In order to fix this, we look at the mappings between keycodes and
keysyms at grabkeys() time and pick out all matching keycodes rather
than just the first one. The keypress() side of this doesn't need any
changes because the keycode gets converted back to a canonical keysym
before any action is taken.

0: https://github.com/cdown/dwm/issues/11

Ref.
https://git.suckless.org/dwm/commit/89f9905714c1c1b2e8b09986dfbeca15b68d8af8.html
2022-12-08 10:45:52 +01:00
bakkeby
dc4e535b25 tagpreview: make sure that tagwin is created following configure notify requests ref. #308 2022-11-15 10:31:15 +01:00
bakkeby
b4ae62d21a fakefullscreen: fix for mis-sized fullscreen applications
An example problematic situation would be to open a YouTube video
in Google Chrome and making that video fullscreen. Without this fix
the window will go into fullscreen within its tiled dimension, but
the size of the video will match that of the screen (and it will
be cropped).

With this fix the window will be resized which nudges the
application to adjust the fullscreen size accordingly.
2022-11-01 09:22:00 +01:00
bakkeby
ad56835713 Bump to ba56fe9.
Revert "Remove dmenumon variable"

This reverts commit c2b748e7931e5f28984efc236f9b1a212dbc65e8.

Revert back this change. It seems to not be an edge-case anymore since
multiple users have asked about this new behaviour now.

Ref.
https://git.suckless.org/dwm/commit/ba56fe9fea0a28d8184a727a987836a0903e2682.html
2022-10-30 10:32:43 +01:00
bakkeby
e6a74ad3ea roundedcorners: moving drawroundedcorners logic to resizeclient ref. #304 2022-10-16 21:32:01 +02:00
bakkeby
b732821f7b alttab: fixing crash when clients are on other tags 2022-10-13 12:34:09 +02:00
bakkeby
9a5378440c rounded rectangles: fullscreen compatibility fix ref. #304 2022-10-10 22:58:35 +02:00
bakkeby
cc58ad2ef4 Adding alt-tab patch ref. #303 2022-10-08 22:35:04 +02:00
bakkeby
4912e3129a Bump to 50ad171.
remove workaround for a crash with color emojis on some systems, now fixed in libXft 2.3.5

https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS

bump version to 6.4

Ref.
https://git.suckless.org/dwm/commit/970f37697358574e127019eb0ee2f5725ec05ce0.html
https://git.suckless.org/dwm/commit/50ad171eea9db5ccb36fce2592e047c3282975ff.html

Consequently the color emoji patch has been inverted into no color emoji, keeping the workaround in the code base for those that are on systems with older versions of the Xft library.
2022-10-06 14:44:11 +02:00
monosans
1ac17a4937
Add dwm.desktop file (#301) 2022-09-26 10:03:12 +02:00
bakkeby
82a127630d fullscreen: don't let the (always) center patch interfere with windows that start fullscreen 2022-09-18 20:39:31 +02:00
bakkeby
2c180b8d9c Bump to c2b748e.
Remove dmenumon variable

Reasoning: Since 2011 dmenu has been capable of working out which
monitor currently has focus in a Xinerama setup, making the use
of the -m flag more or less redundant.

This is easily demonstrated by using dmenu in any other window
manager.

There used to be a nodmenu patch that provided these changes:
https://git.suckless.org/sites/commit/ed68e3629de4ef2ca2d3f8893a79fb570b4c0cbc.html

but this was removed on the basis that it was very easy to work
out and apply manually if needed.

The proposal here is to remove this dependency from dwm. The
mechanism of the dmenumon variable could be provided via a patch
if need be.

The edge case scenario that dmenu does not handle on its own, and
the effect of removing this mechanism, is that if the user trigger
focusmon via keybindings to change focus to another monitor that
has no clients, then dmenu will open on the monitor containing the
window with input focus (or the monitor with the mouse cursor if
no windows have input focus).

If this edge case is important to cover then this can be addressed
by setting input focus to selmon->barwin in the focus function if
there is no client to give focus to (rather than giving focus back
to the root window).

Ref.
https://git.suckless.org/dwm/commit/c2b748e7931e5f28984efc236f9b1a212dbc65e8.html
2022-08-29 21:49:41 +02:00
bakkeby
88eb89ab0d Roll back const change for IPCCommands 2022-08-29 21:37:43 +02:00
bakkeby
0f36ba5408 restartsig: call XNextEvent only when there is data to be read ref. #295 2022-08-29 21:37:03 +02:00
bakkeby
90f9b2d982 Bump to 84d7322.
config.def.h: make keys and buttons const

Pretty much all other variables are declared as const when they're not
modified.

Ref.
https://git.suckless.org/dwm/commit/84d7322113c2bf023f5eaa8537fb0e72d4105046.html
2022-08-21 10:33:53 +02:00
bakkeby
b93a5de558 Expose showhideclient to external tools (fsignal, IPC) ref #287 2022-08-13 16:24:55 +02:00
bakkeby
2d34596ad0 Bump to 44adafe.
Make floating windows spawn within the monitor's window area

This is a follow-up on this thread:
https://lists.suckless.org/hackers/2208/18462.html

The orginal code had constraints such that if a window's starting
attributes (position and size) were to place the window outside of
the edges of the monitor, then the window would be moved into view
at the closest monitor edge.

There was an exception to this where if a top bar is used then the
window should not obscure the bar if present, which meant to place
the window within the window area instead.

The proposed change here makes it the general rule that floating
windows should spawn within the window area rather than within the
monitor area. This makes it simple and consistent with no
exceptions and it makes the intention of the code clear.

This has the benefit of making the behaviour consistent regardless
of whether the user is using a top bar or a bottom bar.

Additionally this will have an effect on patches that modify the
size of the window area. For example if the insets patch is used to
reserve space on the left hand side of the monitor for a dock or a
vertical bar then new floating clients will not obscure that area.

Ref.
https://git.suckless.org/dwm/commit/44adafe0069e73aa03a3829d7bb39591cd8b3f1d.html
2022-08-12 15:02:25 +02:00
bakkeby
c438eabdc2 Adding nametag patch 2022-08-12 13:47:25 +02:00
bakkeby
91cb32c3ed Bump to e0dee91.
sync code-style patch from libsl

Ref.
https://git.suckless.org/dwm/commit/e0dee911455cee739a5b05a994828f4a37a2764d.html
2022-08-08 14:41:21 +02:00
bakkeby
d6205e3e89 autostart: upgrading to dwm-autostart-20210120-cb3f58a.diff 2022-08-07 10:50:25 +02:00
bakkeby
6a0e5b884e Bump to 5e76e7e.
code-style: simplify some checks

main change here is making the `zoom()` logic saner. the rest of the
changes are just small stuff which accumulated on my local branch.

pop() must not be called with NULL. and `zoom()` achieves this, but in a
very (unnecessarily) complicated way:

if c == NULL then nexttiled() will return NULL as well, so we enter this
branch:

	if (c == nexttiled(selmon->clients))

in here the !c check fails and the function returns before calling pop()

		if (!c || !(c = nexttiled(c->next)))
			return;

however, none of this was needed. we can simply return early if c was NULL.
Also `c` is set to `selmon->sel` so we can use `c` in the first check
instead which makes things shorter.

Ref.
https://git.suckless.org/dwm/commit/5e76e7e21da042c493c59235ca82d7275f20a7e4.html
2022-08-07 10:41:01 +02:00