Adds the unified-review integration that fuses CRG graph context with the ai-code-review scoring methodology and gstack-review fix-first workflow: - scoring.py: objective Layer-2 metrics (sql_risk, exception_coverage, redundancy_rate, high_risk_density, vulnerability_risk) with good/warn/fail grades, plus dedupe_findings (fingerprint merge, multi-source confidence boost, PR quality score) and report data builder - tools/scoring_tools.py + main.py: three new MCP tools (score_review_tool, dedupe_findings_tool, generate_report_tool) - assets/report-template.html: self-contained HTML report template - skills.py + skills/unified-review/: new read-only unified-review skill with language/manual-review/specialist checklists - docs and CHANGELOG updated; tests added (test_scoring, test_report, test_unified_review) and test_skills updated for 5 skills
609 B
609 B
Distributed Lock — Manual Review Checklist
High-risk module: distributed-lock changes require architecture confirmation.
- Lock has a TTL / expiry — no permanent deadlock after crash
- Lock release is atomic and ownership-checked (compare-and-delete)
- Lock scope is correct (key includes the right entity identifiers)
- Renewal / watchdog exists for long critical sections
- Locking order is consistent across paths (no lock-ordering deadlock)
- Fencing tokens / version check prevents stale-holder writes
- Fail-open vs fail-closed behavior is intentional and documented