fix: code review — 7 issues resolved

(C1) Add dimensionScores/radarData/passed columns to AssessmentSession
(C2) Mock DataSource in service.spec.ts + app.e2e-spec.ts
(C3) Mock AuditLogService in controller.spec.ts
(C4) Rewrite deleteSession tests for dataSource.transaction
(I1) batchDeleteSessions uses transaction with certificate cleanup
(I2) extractDimensionScores reads from session property
(I3/I5) PDF generator supports multi-page + newline splitting
(I4) findOne inside transaction uses deleteCondition
This commit is contained in:
Developer
2026-05-19 10:06:30 +08:00
parent 7f8e7214b3
commit 82a9e75842
7 changed files with 164 additions and 63 deletions
@@ -6,6 +6,7 @@ import { TenantService } from '../tenant/tenant.service';
import { UserService } from '../user/user.service';
import { CombinedAuthGuard } from '../auth/combined-auth.guard';
import { ExportService } from './services/export.service';
import { AuditLogService } from './services/audit-log.service';
describe('AssessmentController', () => {
let controller: AssessmentController;
@@ -27,6 +28,7 @@ describe('AssessmentController', () => {
{ provide: UserService, useFactory: mockService },
{ provide: TenantService, useFactory: mockService },
{ provide: ExportService, useFactory: mockService },
{ provide: AuditLogService, useFactory: () => ({ log: jest.fn() }) },
{ provide: Reflector, useFactory: mockReflector },
{ provide: CombinedAuthGuard, useFactory: mockGuard },
],